Add linux mlslabel support
[zfs.git] / module / zfs / zfs_ioctl.c
index d032648..2302c0f 100644 (file)
@@ -19,8 +19,7 @@
  * CDDL HEADER END
  */
 /*
- * Copyright 2009 Sun Microsystems, Inc.  All rights reserved.
- * Use is subject to license terms.
+ * Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved.
  */
 
 #include <sys/types.h>
 #include <sys/cmn_err.h>
 #include <sys/stat.h>
 #include <sys/zfs_ioctl.h>
+#include <sys/zfs_vfsops.h>
 #include <sys/zfs_znode.h>
 #include <sys/zap.h>
 #include <sys/spa.h>
 #include <sys/spa_impl.h>
 #include <sys/vdev.h>
-#include <sys/vdev_impl.h>
+#include <sys/priv_impl.h>
 #include <sys/dmu.h>
 #include <sys/dsl_dir.h>
 #include <sys/dsl_dataset.h>
 #include <sys/fs/zfs.h>
 #include <sys/zfs_ctldir.h>
 #include <sys/zfs_dir.h>
+#include <sys/zfs_onexit.h>
 #include <sys/zvol.h>
+#include <sys/dsl_scan.h>
 #include <sharefs/share.h>
 #include <sys/dmu_objset.h>
 
 #include "zfs_namecheck.h"
 #include "zfs_prop.h"
 #include "zfs_deleg.h"
+#include "zfs_comutil.h"
 
 extern struct modlfs zfs_modlfs;
 
@@ -79,28 +82,49 @@ dev_info_t *zfs_dip;
 typedef int zfs_ioc_func_t(zfs_cmd_t *);
 typedef int zfs_secpolicy_func_t(zfs_cmd_t *, cred_t *);
 
+typedef enum {
+       NO_NAME,
+       POOL_NAME,
+       DATASET_NAME
+} zfs_ioc_namecheck_t;
+
+typedef enum {
+       POOL_CHECK_NONE         = 1 << 0,
+       POOL_CHECK_SUSPENDED    = 1 << 1,
+       POOL_CHECK_READONLY     = 1 << 2
+} zfs_ioc_poolcheck_t;
+
 typedef struct zfs_ioc_vec {
        zfs_ioc_func_t          *zvec_func;
        zfs_secpolicy_func_t    *zvec_secpolicy;
-       enum {
-               NO_NAME,
-               POOL_NAME,
-               DATASET_NAME
-       } zvec_namecheck;
+       zfs_ioc_namecheck_t     zvec_namecheck;
        boolean_t               zvec_his_log;
+       zfs_ioc_poolcheck_t     zvec_pool_check;
 } zfs_ioc_vec_t;
 
-static void clear_props(char *dataset, nvlist_t *props, nvlist_t *newprops);
+/* This array is indexed by zfs_userquota_prop_t */
+static const char *userquota_perms[] = {
+       ZFS_DELEG_PERM_USERUSED,
+       ZFS_DELEG_PERM_USERQUOTA,
+       ZFS_DELEG_PERM_GROUPUSED,
+       ZFS_DELEG_PERM_GROUPQUOTA,
+};
+
+static int zfs_ioc_userspace_upgrade(zfs_cmd_t *zc);
+static int zfs_check_settable(const char *name, nvpair_t *property,
+    cred_t *cr);
+static int zfs_check_clearable(char *dataset, nvlist_t *props,
+    nvlist_t **errors);
 static int zfs_fill_zplprops_root(uint64_t, nvlist_t *, nvlist_t *,
     boolean_t *);
-int zfs_set_prop_nvlist(const char *, nvlist_t *);
+int zfs_set_prop_nvlist(const char *, zprop_source_t, nvlist_t *, nvlist_t **);
 
 /* _NOTE(PRINTFLIKE(4)) - this is printf-like, but lint is too whiney */
 void
 __dprintf(const char *file, const char *func, int line, const char *fmt, ...)
 {
        const char *newfile;
-       char buf[256];
+       char buf[512];
        va_list adx;
 
        /*
@@ -142,7 +166,7 @@ history_str_get(zfs_cmd_t *zc)
 {
        char *buf;
 
-       if (zc->zc_history == NULL)
+       if (zc->zc_history == 0)
                return (NULL);
 
        buf = kmem_alloc(HIS_MAX_RECORD_LEN, KM_SLEEP);
@@ -163,22 +187,15 @@ history_str_get(zfs_cmd_t *zc)
 static boolean_t
 zfs_is_bootfs(const char *name)
 {
-       spa_t *spa;
-       boolean_t ret = B_FALSE;
-
-       if (spa_open(name, &spa, FTAG) == 0) {
-               if (spa->spa_bootfs) {
-                       objset_t *os;
+       objset_t *os;
 
-                       if (dmu_objset_open(name, DMU_OST_ZFS,
-                           DS_MODE_USER | DS_MODE_READONLY, &os) == 0) {
-                               ret = (dmu_objset_id(os) == spa->spa_bootfs);
-                               dmu_objset_close(os);
-                       }
-               }
-               spa_close(spa, FTAG);
+       if (dmu_objset_hold(name, FTAG, &os) == 0) {
+               boolean_t ret;
+               ret = (dmu_objset_id(os) == spa_bootfs(dmu_objset_spa(os)));
+               dmu_objset_rele(os, FTAG);
+               return (ret);
        }
-       return (ret);
+       return (B_FALSE);
 }
 
 /*
@@ -212,13 +229,17 @@ zpl_earlier_version(const char *name, int version)
        objset_t *os;
        boolean_t rc = B_TRUE;
 
-       if (dmu_objset_open(name, DMU_OST_ANY,
-           DS_MODE_USER | DS_MODE_READONLY, &os) == 0) {
+       if (dmu_objset_hold(name, FTAG, &os) == 0) {
                uint64_t zplversion;
 
+               if (dmu_objset_type(os) != DMU_OST_ZFS) {
+                       dmu_objset_rele(os, FTAG);
+                       return (B_TRUE);
+               }
+               /* XXX reading from non-owned objset */
                if (zfs_get_zplprop(os, ZFS_PROP_VERSION, &zplversion) == 0)
                        rc = zplversion < version;
-               dmu_objset_close(os);
+               dmu_objset_rele(os, FTAG);
        }
        return (rc);
 }
@@ -267,9 +288,8 @@ zfs_secpolicy_read(zfs_cmd_t *zc, cred_t *cr)
 }
 
 static int
-zfs_dozonecheck(const char *dataset, cred_t *cr)
+zfs_dozonecheck_impl(const char *dataset, uint64_t zoned, cred_t *cr)
 {
-       uint64_t zoned;
        int writable = 1;
 
        /*
@@ -280,9 +300,6 @@ zfs_dozonecheck(const char *dataset, cred_t *cr)
            !zone_dataset_visible(dataset, &writable))
                return (ENOENT);
 
-       if (dsl_prop_get_integer(dataset, "zoned", &zoned, NULL))
-               return (ENOENT);
-
        if (INGLOBALZONE(curproc)) {
                /*
                 * If the fs is zoned, only root can access it from the
@@ -304,6 +321,32 @@ zfs_dozonecheck(const char *dataset, cred_t *cr)
        return (0);
 }
 
+static int
+zfs_dozonecheck(const char *dataset, cred_t *cr)
+{
+       uint64_t zoned;
+
+       if (dsl_prop_get_integer(dataset, "zoned", &zoned, NULL))
+               return (ENOENT);
+
+       return (zfs_dozonecheck_impl(dataset, zoned, cr));
+}
+
+static int
+zfs_dozonecheck_ds(const char *dataset, dsl_dataset_t *ds, cred_t *cr)
+{
+       uint64_t zoned;
+
+       rw_enter(&ds->ds_dir->dd_pool->dp_config_rwlock, RW_READER);
+       if (dsl_prop_get_ds(ds, "zoned", 8, 1, &zoned, NULL)) {
+               rw_exit(&ds->ds_dir->dd_pool->dp_config_rwlock);
+               return (ENOENT);
+       }
+       rw_exit(&ds->ds_dir->dd_pool->dp_config_rwlock);
+
+       return (zfs_dozonecheck_impl(dataset, zoned, cr));
+}
+
 int
 zfs_secpolicy_write_perms(const char *name, const char *perm, cred_t *cr)
 {
@@ -318,13 +361,134 @@ zfs_secpolicy_write_perms(const char *name, const char *perm, cred_t *cr)
        return (error);
 }
 
+int
+zfs_secpolicy_write_perms_ds(const char *name, dsl_dataset_t *ds,
+    const char *perm, cred_t *cr)
+{
+       int error;
+
+       error = zfs_dozonecheck_ds(name, ds, cr);
+       if (error == 0) {
+               error = secpolicy_zfs(cr);
+               if (error)
+                       error = dsl_deleg_access_impl(ds, perm, cr);
+       }
+       return (error);
+}
+
+/*
+ * Policy for setting the security label property.
+ *
+ * Returns 0 for success, non-zero for access and other errors.
+ */
+static int
+zfs_set_slabel_policy(const char *name, char *strval, cred_t *cr)
+{
+#ifdef HAVE_MLSLABEL
+       char            ds_hexsl[MAXNAMELEN];
+       bslabel_t       ds_sl, new_sl;
+       boolean_t       new_default = FALSE;
+       uint64_t        zoned;
+       int             needed_priv = -1;
+       int             error;
+
+       /* First get the existing dataset label. */
+       error = dsl_prop_get(name, zfs_prop_to_name(ZFS_PROP_MLSLABEL),
+           1, sizeof (ds_hexsl), &ds_hexsl, NULL);
+       if (error)
+               return (EPERM);
+
+       if (strcasecmp(strval, ZFS_MLSLABEL_DEFAULT) == 0)
+               new_default = TRUE;
+
+       /* The label must be translatable */
+       if (!new_default && (hexstr_to_label(strval, &new_sl) != 0))
+               return (EINVAL);
+
+       /*
+        * In a non-global zone, disallow attempts to set a label that
+        * doesn't match that of the zone; otherwise no other checks
+        * are needed.
+        */
+       if (!INGLOBALZONE(curproc)) {
+               if (new_default || !blequal(&new_sl, CR_SL(CRED())))
+                       return (EPERM);
+               return (0);
+       }
+
+       /*
+        * For global-zone datasets (i.e., those whose zoned property is
+        * "off", verify that the specified new label is valid for the
+        * global zone.
+        */
+       if (dsl_prop_get_integer(name,
+           zfs_prop_to_name(ZFS_PROP_ZONED), &zoned, NULL))
+               return (EPERM);
+       if (!zoned) {
+               if (zfs_check_global_label(name, strval) != 0)
+                       return (EPERM);
+       }
+
+       /*
+        * If the existing dataset label is nondefault, check if the
+        * dataset is mounted (label cannot be changed while mounted).
+        * Get the zfsvfs; if there isn't one, then the dataset isn't
+        * mounted (or isn't a dataset, doesn't exist, ...).
+        */
+       if (strcasecmp(ds_hexsl, ZFS_MLSLABEL_DEFAULT) != 0) {
+               objset_t *os;
+               static char *setsl_tag = "setsl_tag";
+
+               /*
+                * Try to own the dataset; abort if there is any error,
+                * (e.g., already mounted, in use, or other error).
+                */
+               error = dmu_objset_own(name, DMU_OST_ZFS, B_TRUE,
+                   setsl_tag, &os);
+               if (error)
+                       return (EPERM);
+
+               dmu_objset_disown(os, setsl_tag);
+
+               if (new_default) {
+                       needed_priv = PRIV_FILE_DOWNGRADE_SL;
+                       goto out_check;
+               }
+
+               if (hexstr_to_label(strval, &new_sl) != 0)
+                       return (EPERM);
+
+               if (blstrictdom(&ds_sl, &new_sl))
+                       needed_priv = PRIV_FILE_DOWNGRADE_SL;
+               else if (blstrictdom(&new_sl, &ds_sl))
+                       needed_priv = PRIV_FILE_UPGRADE_SL;
+       } else {
+               /* dataset currently has a default label */
+               if (!new_default)
+                       needed_priv = PRIV_FILE_UPGRADE_SL;
+       }
+
+out_check:
+       if (needed_priv != -1)
+               return (PRIV_POLICY(cr, needed_priv, B_FALSE, EPERM, NULL));
+       return (0);
+#else
+       return ENOTSUP;
+#endif /* HAVE_MLSLABEL */
+}
+
 static int
-zfs_secpolicy_setprop(const char *name, zfs_prop_t prop, cred_t *cr)
+zfs_secpolicy_setprop(const char *dsname, zfs_prop_t prop, nvpair_t *propval,
+    cred_t *cr)
 {
+       char *strval;
+
        /*
         * Check permissions for special properties.
         */
        switch (prop) {
+       default:
+               break;
        case ZFS_PROP_ZONED:
                /*
                 * Disallow setting of 'zoned' from within a local zone.
@@ -342,16 +506,29 @@ zfs_secpolicy_setprop(const char *name, zfs_prop_t prop, cred_t *cr)
                         * quota on things *under* (ie. contained by)
                         * the thing they own.
                         */
-                       if (dsl_prop_get_integer(name, "zoned", &zoned,
+                       if (dsl_prop_get_integer(dsname, "zoned", &zoned,
                            setpoint))
                                return (EPERM);
-                       if (!zoned || strlen(name) <= strlen(setpoint))
+                       if (!zoned || strlen(dsname) <= strlen(setpoint))
                                return (EPERM);
                }
                break;
+
+       case ZFS_PROP_MLSLABEL:
+               if (!is_system_labeled())
+                       return (EPERM);
+
+               if (nvpair_value_string(propval, &strval) == 0) {
+                       int err;
+
+                       err = zfs_set_slabel_policy(dsname, strval, CRED());
+                       if (err != 0)
+                               return (err);
+               }
+               break;
        }
 
-       return (zfs_secpolicy_write_perms(name, zfs_prop_to_name(prop), cr));
+       return (zfs_secpolicy_write_perms(dsname, zfs_prop_to_name(prop), cr));
 }
 
 int
@@ -373,20 +550,69 @@ zfs_secpolicy_fsacl(zfs_cmd_t *zc, cred_t *cr)
 int
 zfs_secpolicy_rollback(zfs_cmd_t *zc, cred_t *cr)
 {
-       int error;
-       error = zfs_secpolicy_write_perms(zc->zc_name,
-           ZFS_DELEG_PERM_ROLLBACK, cr);
-       if (error == 0)
-               error = zfs_secpolicy_write_perms(zc->zc_name,
-                   ZFS_DELEG_PERM_MOUNT, cr);
-       return (error);
+       return (zfs_secpolicy_write_perms(zc->zc_name,
+           ZFS_DELEG_PERM_ROLLBACK, cr));
 }
 
 int
 zfs_secpolicy_send(zfs_cmd_t *zc, cred_t *cr)
 {
-       return (zfs_secpolicy_write_perms(zc->zc_name,
-           ZFS_DELEG_PERM_SEND, cr));
+       spa_t *spa;
+       dsl_pool_t *dp;
+       dsl_dataset_t *ds;
+       char *cp;
+       int error;
+
+       /*
+        * Generate the current snapshot name from the given objsetid, then
+        * use that name for the secpolicy/zone checks.
+        */
+       cp = strchr(zc->zc_name, '@');
+       if (cp == NULL)
+               return (EINVAL);
+       error = spa_open(zc->zc_name, &spa, FTAG);
+       if (error)
+               return (error);
+
+       dp = spa_get_dsl(spa);
+       rw_enter(&dp->dp_config_rwlock, RW_READER);
+       error = dsl_dataset_hold_obj(dp, zc->zc_sendobj, FTAG, &ds);
+       rw_exit(&dp->dp_config_rwlock);
+       spa_close(spa, FTAG);
+       if (error)
+               return (error);
+
+       dsl_dataset_name(ds, zc->zc_name);
+
+       error = zfs_secpolicy_write_perms_ds(zc->zc_name, ds,
+           ZFS_DELEG_PERM_SEND, cr);
+       dsl_dataset_rele(ds, FTAG);
+
+       return (error);
+}
+
+static int
+zfs_secpolicy_deleg_share(zfs_cmd_t *zc, cred_t *cr)
+{
+       vnode_t *vp;
+       int error;
+
+       if ((error = lookupname(zc->zc_value, UIO_SYSSPACE,
+           NO_FOLLOW, NULL, &vp)) != 0)
+               return (error);
+
+       /* Now make sure mntpnt and dataset are ZFS */
+
+       if (vp->v_vfsp->vfs_fstype != zfsfstype ||
+           (strcmp((char *)refstr_value(vp->v_vfsp->vfs_resource),
+           zc->zc_name) != 0)) {
+               VN_RELE(vp);
+               return (EPERM);
+       }
+
+       VN_RELE(vp);
+       return (dsl_deleg_access(zc->zc_name,
+           ZFS_DELEG_PERM_SHARE, cr));
 }
 
 int
@@ -398,25 +624,20 @@ zfs_secpolicy_share(zfs_cmd_t *zc, cred_t *cr)
        if (secpolicy_nfs(cr) == 0) {
                return (0);
        } else {
-               vnode_t *vp;
-               int error;
-
-               if ((error = lookupname(zc->zc_value, UIO_SYSSPACE,
-                   NO_FOLLOW, NULL, &vp)) != 0)
-                       return (error);
-
-               /* Now make sure mntpnt and dataset are ZFS */
+               return (zfs_secpolicy_deleg_share(zc, cr));
+       }
+}
 
-               if (vp->v_vfsp->vfs_fstype != zfsfstype ||
-                   (strcmp((char *)refstr_value(vp->v_vfsp->vfs_resource),
-                   zc->zc_name) != 0)) {
-                       VN_RELE(vp);
-                       return (EPERM);
-               }
+int
+zfs_secpolicy_smb_acl(zfs_cmd_t *zc, cred_t *cr)
+{
+       if (!INGLOBALZONE(curproc))
+               return (EPERM);
 
-               VN_RELE(vp);
-               return (dsl_deleg_access(zc->zc_name,
-                   ZFS_DELEG_PERM_SHARE, cr));
+       if (secpolicy_smb(cr) == 0) {
+               return (0);
+       } else {
+               return (zfs_secpolicy_deleg_share(zc, cr));
        }
 }
 
@@ -461,19 +682,34 @@ zfs_secpolicy_destroy(zfs_cmd_t *zc, cred_t *cr)
 }
 
 /*
- * Must have sys_config privilege to check the iscsi permission
+ * Destroying snapshots with delegated permissions requires
+ * descendent mount and destroy permissions.
+ * Reassemble the full filesystem@snap name so dsl_deleg_access()
+ * can do the correct permission check.
+ *
+ * Since this routine is used when doing a recursive destroy of snapshots
+ * and destroying snapshots requires descendent permissions, a successfull
+ * check of the top level snapshot applies to snapshots of all descendent
+ * datasets as well.
  */
-/* ARGSUSED */
 static int
-zfs_secpolicy_iscsi(zfs_cmd_t *zc, cred_t *cr)
+zfs_secpolicy_destroy_snaps(zfs_cmd_t *zc, cred_t *cr)
 {
-       return (secpolicy_zfs(cr));
+       int error;
+       char *dsname;
+
+       dsname = kmem_asprintf("%s@%s", zc->zc_name, zc->zc_value);
+
+       error = zfs_secpolicy_destroy_perms(dsname, cr);
+
+       strfree(dsname);
+       return (error);
 }
 
 int
 zfs_secpolicy_rename_perms(const char *from, const char *to, cred_t *cr)
 {
-       char    parentname[MAXNAMELEN];
+       char    parentname[MAXNAMELEN];
        int     error;
 
        if ((error = zfs_secpolicy_write_perms(from,
@@ -508,7 +744,7 @@ zfs_secpolicy_rename(zfs_cmd_t *zc, cred_t *cr)
 static int
 zfs_secpolicy_promote(zfs_cmd_t *zc, cred_t *cr)
 {
-       char    parentname[MAXNAMELEN];
+       char    parentname[MAXNAMELEN];
        objset_t *clone;
        int error;
 
@@ -517,20 +753,19 @@ zfs_secpolicy_promote(zfs_cmd_t *zc, cred_t *cr)
        if (error)
                return (error);
 
-       error = dmu_objset_open(zc->zc_name, DMU_OST_ANY,
-           DS_MODE_USER | DS_MODE_READONLY, &clone);
+       error = dmu_objset_hold(zc->zc_name, FTAG, &clone);
 
        if (error == 0) {
                dsl_dataset_t *pclone = NULL;
                dsl_dir_t *dd;
-               dd = clone->os->os_dsl_dataset->ds_dir;
+               dd = clone->os_dsl_dataset->ds_dir;
 
                rw_enter(&dd->dd_pool->dp_config_rwlock, RW_READER);
                error = dsl_dataset_hold_obj(dd->dd_pool,
                    dd->dd_phys->dd_origin_obj, FTAG, &pclone);
                rw_exit(&dd->dd_pool->dp_config_rwlock);
                if (error) {
-                       dmu_objset_close(clone);
+                       dmu_objset_rele(clone, FTAG);
                        return (error);
                }
 
@@ -538,7 +773,7 @@ zfs_secpolicy_promote(zfs_cmd_t *zc, cred_t *cr)
                    ZFS_DELEG_PERM_MOUNT, cr);
 
                dsl_dataset_name(pclone, parentname);
-               dmu_objset_close(clone);
+               dmu_objset_rele(clone, FTAG);
                dsl_dataset_rele(pclone, FTAG);
                if (error == 0)
                        error = zfs_secpolicy_write_perms(parentname,
@@ -567,16 +802,8 @@ zfs_secpolicy_receive(zfs_cmd_t *zc, cred_t *cr)
 int
 zfs_secpolicy_snapshot_perms(const char *name, cred_t *cr)
 {
-       int error;
-
-       if ((error = zfs_secpolicy_write_perms(name,
-           ZFS_DELEG_PERM_SNAPSHOT, cr)) != 0)
-               return (error);
-
-       error = zfs_secpolicy_write_perms(name,
-           ZFS_DELEG_PERM_MOUNT, cr);
-
-       return (error);
+       return (zfs_secpolicy_write_perms(name,
+           ZFS_DELEG_PERM_SNAPSHOT, cr));
 }
 
 static int
@@ -589,8 +816,8 @@ zfs_secpolicy_snapshot(zfs_cmd_t *zc, cred_t *cr)
 static int
 zfs_secpolicy_create(zfs_cmd_t *zc, cred_t *cr)
 {
-       char    parentname[MAXNAMELEN];
-       int     error;
+       char    parentname[MAXNAMELEN];
+       int     error;
 
        if ((error = zfs_get_parent(zc->zc_name, parentname,
            sizeof (parentname))) != 0)
@@ -639,19 +866,19 @@ zfs_secpolicy_config(zfs_cmd_t *zc, cred_t *cr)
 }
 
 /*
- * Just like zfs_secpolicy_config, except that we will check for
- * mount permission on the dataset for permission to create/remove
- * the minor nodes.
+ * Policy for object to name lookups.
  */
+/* ARGSUSED */
 static int
-zfs_secpolicy_minor(zfs_cmd_t *zc, cred_t *cr)
+zfs_secpolicy_diff(zfs_cmd_t *zc, cred_t *cr)
 {
-       if (secpolicy_sys_config(cr, B_FALSE) != 0) {
-               return (dsl_deleg_access(zc->zc_name,
-                   ZFS_DELEG_PERM_MOUNT, cr));
-       }
+       int error;
 
-       return (0);
+       if ((error = secpolicy_sys_config(cr, B_FALSE)) == 0)
+               return (0);
+
+       error = zfs_secpolicy_write_perms(zc->zc_name, ZFS_DELEG_PERM_DIFF, cr);
+       return (error);
 }
 
 /*
@@ -675,17 +902,107 @@ zfs_secpolicy_inherit(zfs_cmd_t *zc, cred_t *cr)
                return (zfs_secpolicy_write_perms(zc->zc_name,
                    ZFS_DELEG_PERM_USERPROP, cr));
        } else {
-               if (!zfs_prop_inheritable(prop))
-                       return (EINVAL);
-               return (zfs_secpolicy_setprop(zc->zc_name, prop, cr));
+               return (zfs_secpolicy_setprop(zc->zc_name, prop,
+                   NULL, cr));
+       }
+}
+
+static int
+zfs_secpolicy_userspace_one(zfs_cmd_t *zc, cred_t *cr)
+{
+       int err = zfs_secpolicy_read(zc, cr);
+       if (err)
+               return (err);
+
+       if (zc->zc_objset_type >= ZFS_NUM_USERQUOTA_PROPS)
+               return (EINVAL);
+
+       if (zc->zc_value[0] == 0) {
+               /*
+                * They are asking about a posix uid/gid.  If it's
+                * themself, allow it.
+                */
+               if (zc->zc_objset_type == ZFS_PROP_USERUSED ||
+                   zc->zc_objset_type == ZFS_PROP_USERQUOTA) {
+                       if (zc->zc_guid == crgetuid(cr))
+                               return (0);
+               } else {
+                       if (groupmember(zc->zc_guid, cr))
+                               return (0);
+               }
        }
+
+       return (zfs_secpolicy_write_perms(zc->zc_name,
+           userquota_perms[zc->zc_objset_type], cr));
+}
+
+static int
+zfs_secpolicy_userspace_many(zfs_cmd_t *zc, cred_t *cr)
+{
+       int err = zfs_secpolicy_read(zc, cr);
+       if (err)
+               return (err);
+
+       if (zc->zc_objset_type >= ZFS_NUM_USERQUOTA_PROPS)
+               return (EINVAL);
+
+       return (zfs_secpolicy_write_perms(zc->zc_name,
+           userquota_perms[zc->zc_objset_type], cr));
+}
+
+static int
+zfs_secpolicy_userspace_upgrade(zfs_cmd_t *zc, cred_t *cr)
+{
+       return (zfs_secpolicy_setprop(zc->zc_name, ZFS_PROP_VERSION,
+           NULL, cr));
+}
+
+static int
+zfs_secpolicy_hold(zfs_cmd_t *zc, cred_t *cr)
+{
+       return (zfs_secpolicy_write_perms(zc->zc_name,
+           ZFS_DELEG_PERM_HOLD, cr));
+}
+
+static int
+zfs_secpolicy_release(zfs_cmd_t *zc, cred_t *cr)
+{
+       return (zfs_secpolicy_write_perms(zc->zc_name,
+           ZFS_DELEG_PERM_RELEASE, cr));
+}
+
+/*
+ * Policy for allowing temporary snapshots to be taken or released
+ */
+static int
+zfs_secpolicy_tmp_snapshot(zfs_cmd_t *zc, cred_t *cr)
+{
+       /*
+        * A temporary snapshot is the same as a snapshot,
+        * hold, destroy and release all rolled into one.
+        * Delegated diff alone is sufficient that we allow this.
+        */
+       int error;
+
+       if ((error = zfs_secpolicy_write_perms(zc->zc_name,
+           ZFS_DELEG_PERM_DIFF, cr)) == 0)
+               return (0);
+
+       error = zfs_secpolicy_snapshot(zc, cr);
+       if (!error)
+               error = zfs_secpolicy_hold(zc, cr);
+       if (!error)
+               error = zfs_secpolicy_release(zc, cr);
+       if (!error)
+               error = zfs_secpolicy_destroy(zc, cr);
+       return (error);
 }
 
 /*
  * Returns the nvlist as specified by the user in the zfs_cmd_t.
  */
 static int
-get_nvlist(uint64_t nvl, uint64_t size, nvlist_t **nvp)
+get_nvlist(uint64_t nvl, uint64_t size, int iflag, nvlist_t **nvp)
 {
        char *packed;
        int error;
@@ -699,7 +1016,8 @@ get_nvlist(uint64_t nvl, uint64_t size, nvlist_t **nvp)
 
        packed = kmem_alloc(size, KM_SLEEP);
 
-       if ((error = xcopyin((void *)(uintptr_t)nvl, packed, size)) != 0) {
+       if ((error = ddi_copyin((void *)(uintptr_t)nvl, packed, size,
+           iflag)) != 0) {
                kmem_free(packed, size);
                return (error);
        }
@@ -716,11 +1034,46 @@ get_nvlist(uint64_t nvl, uint64_t size, nvlist_t **nvp)
 }
 
 static int
+fit_error_list(zfs_cmd_t *zc, nvlist_t **errors)
+{
+       size_t size;
+
+       VERIFY(nvlist_size(*errors, &size, NV_ENCODE_NATIVE) == 0);
+
+       if (size > zc->zc_nvlist_dst_size) {
+               nvpair_t *more_errors;
+               int n = 0;
+
+               if (zc->zc_nvlist_dst_size < 1024)
+                       return (ENOMEM);
+
+               VERIFY(nvlist_add_int32(*errors, ZPROP_N_MORE_ERRORS, 0) == 0);
+               more_errors = nvlist_prev_nvpair(*errors, NULL);
+
+               do {
+                       nvpair_t *pair = nvlist_prev_nvpair(*errors,
+                           more_errors);
+                       VERIFY(nvlist_remove_nvpair(*errors, pair) == 0);
+                       n++;
+                       VERIFY(nvlist_size(*errors, &size,
+                           NV_ENCODE_NATIVE) == 0);
+               } while (size > zc->zc_nvlist_dst_size);
+
+               VERIFY(nvlist_remove_nvpair(*errors, more_errors) == 0);
+               VERIFY(nvlist_add_int32(*errors, ZPROP_N_MORE_ERRORS, n) == 0);
+               ASSERT(nvlist_size(*errors, &size, NV_ENCODE_NATIVE) == 0);
+               ASSERT(size <= zc->zc_nvlist_dst_size);
+       }
+
+       return (0);
+}
+
+static int
 put_nvlist(zfs_cmd_t *zc, nvlist_t *nvl)
 {
        char *packed = NULL;
+       int error = 0;
        size_t size;
-       int error;
 
        VERIFY(nvlist_size(nvl, &size, NV_ENCODE_NATIVE) == 0);
 
@@ -730,8 +1083,9 @@ put_nvlist(zfs_cmd_t *zc, nvlist_t *nvl)
                packed = kmem_alloc(size, KM_SLEEP);
                VERIFY(nvlist_pack(nvl, &packed, &size, NV_ENCODE_NATIVE,
                    KM_SLEEP) == 0);
-               error = xcopyout(packed, (void *)(uintptr_t)zc->zc_nvlist_dst,
-                   size);
+               if (ddi_copyout(packed, (void *)(uintptr_t)zc->zc_nvlist_dst,
+                   size, zc->zc_iflags) != 0)
+                       error = EFAULT;
                kmem_free(packed, size);
        }
 
@@ -740,20 +1094,87 @@ put_nvlist(zfs_cmd_t *zc, nvlist_t *nvl)
 }
 
 static int
-zfs_ioc_pool_create(zfs_cmd_t *zc)
+getzfsvfs(const char *dsname, zfsvfs_t **zfvp)
 {
+       objset_t *os;
        int error;
-       nvlist_t *config, *props = NULL;
-       nvlist_t *rootprops = NULL;
-       nvlist_t *zplprops = NULL;
-       char *buf;
 
-       if (error = get_nvlist(zc->zc_nvlist_conf, zc->zc_nvlist_conf_size,
-           &config))
+       error = dmu_objset_hold(dsname, FTAG, &os);
+       if (error)
                return (error);
+       if (dmu_objset_type(os) != DMU_OST_ZFS) {
+               dmu_objset_rele(os, FTAG);
+               return (EINVAL);
+       }
 
-       if (zc->zc_nvlist_src_size != 0 && (error =
-           get_nvlist(zc->zc_nvlist_src, zc->zc_nvlist_src_size, &props))) {
+       mutex_enter(&os->os_user_ptr_lock);
+       *zfvp = dmu_objset_get_user(os);
+       if (*zfvp) {
+               VFS_HOLD((*zfvp)->z_vfs);
+       } else {
+               error = ESRCH;
+       }
+       mutex_exit(&os->os_user_ptr_lock);
+       dmu_objset_rele(os, FTAG);
+       return (error);
+}
+
+/*
+ * Find a zfsvfs_t for a mounted filesystem, or create our own, in which
+ * case its z_vfs will be NULL, and it will be opened as the owner.
+ */
+static int
+zfsvfs_hold(const char *name, void *tag, zfsvfs_t **zfvp, boolean_t writer)
+{
+       int error = 0;
+
+       if (getzfsvfs(name, zfvp) != 0)
+               error = zfsvfs_create(name, zfvp);
+       if (error == 0) {
+               rrw_enter(&(*zfvp)->z_teardown_lock, (writer) ? RW_WRITER :
+                   RW_READER, tag);
+               if ((*zfvp)->z_unmounted) {
+                       /*
+                        * XXX we could probably try again, since the unmounting
+                        * thread should be just about to disassociate the
+                        * objset from the zfsvfs.
+                        */
+                       rrw_exit(&(*zfvp)->z_teardown_lock, tag);
+                       return (EBUSY);
+               }
+       }
+       return (error);
+}
+
+static void
+zfsvfs_rele(zfsvfs_t *zfsvfs, void *tag)
+{
+       rrw_exit(&zfsvfs->z_teardown_lock, tag);
+
+       if (zfsvfs->z_vfs) {
+               VFS_RELE(zfsvfs->z_vfs);
+       } else {
+               dmu_objset_disown(zfsvfs->z_os, zfsvfs);
+               zfsvfs_free(zfsvfs);
+       }
+}
+
+static int
+zfs_ioc_pool_create(zfs_cmd_t *zc)
+{
+       int error;
+       nvlist_t *config, *props = NULL;
+       nvlist_t *rootprops = NULL;
+       nvlist_t *zplprops = NULL;
+       char *buf;
+
+       if ((error = get_nvlist(zc->zc_nvlist_conf, zc->zc_nvlist_conf_size,
+           zc->zc_iflags, &config)))
+               return (error);
+
+       if (zc->zc_nvlist_src_size != 0 && (error =
+           get_nvlist(zc->zc_nvlist_src, zc->zc_nvlist_src_size,
+           zc->zc_iflags, &props))) {
                nvlist_free(config);
                return (error);
        }
@@ -792,8 +1213,8 @@ zfs_ioc_pool_create(zfs_cmd_t *zc)
        /*
         * Set the remaining root properties
         */
-       if (!error &&
-           (error = zfs_set_prop_nvlist(zc->zc_name, rootprops)) != 0)
+       if (!error && (error = zfs_set_prop_nvlist(zc->zc_name,
+           ZPROP_SRC_LOCAL, rootprops, NULL)) != 0)
                (void) spa_destroy(zc->zc_name);
 
        if (buf != NULL)
@@ -814,22 +1235,25 @@ zfs_ioc_pool_destroy(zfs_cmd_t *zc)
        int error;
        zfs_log_history(zc);
        error = spa_destroy(zc->zc_name);
+       if (error == 0)
+               zvol_remove_minors(zc->zc_name);
        return (error);
 }
 
 static int
 zfs_ioc_pool_import(zfs_cmd_t *zc)
 {
-       int error;
        nvlist_t *config, *props = NULL;
        uint64_t guid;
+       int error;
 
        if ((error = get_nvlist(zc->zc_nvlist_conf, zc->zc_nvlist_conf_size,
-           &config)) != 0)
+           zc->zc_iflags, &config)) != 0)
                return (error);
 
        if (zc->zc_nvlist_src_size != 0 && (error =
-           get_nvlist(zc->zc_nvlist_src, zc->zc_nvlist_src_size, &props))) {
+           get_nvlist(zc->zc_nvlist_src, zc->zc_nvlist_src_size,
+           zc->zc_iflags, &props))) {
                nvlist_free(config);
                return (error);
        }
@@ -837,11 +1261,15 @@ zfs_ioc_pool_import(zfs_cmd_t *zc)
        if (nvlist_lookup_uint64(config, ZPOOL_CONFIG_POOL_GUID, &guid) != 0 ||
            guid != zc->zc_guid)
                error = EINVAL;
-       else if (zc->zc_cookie)
-               error = spa_import_faulted(zc->zc_name, config,
-                   props);
        else
-               error = spa_import(zc->zc_name, config, props);
+               error = spa_import(zc->zc_name, config, props, zc->zc_cookie);
+
+       if (zc->zc_nvlist_dst != 0) {
+               int err;
+
+               if ((err = put_nvlist(zc, config)) != 0)
+                       error = err;
+       }
 
        nvlist_free(config);
 
@@ -860,6 +1288,8 @@ zfs_ioc_pool_export(zfs_cmd_t *zc)
 
        zfs_log_history(zc);
        error = spa_export(zc->zc_name, NULL, force, hardforce);
+       if (error == 0)
+               zvol_remove_minors(zc->zc_name);
        return (error);
 }
 
@@ -917,7 +1347,7 @@ zfs_ioc_pool_tryimport(zfs_cmd_t *zc)
        int error;
 
        if ((error = get_nvlist(zc->zc_nvlist_conf, zc->zc_nvlist_conf_size,
-           &tryconfig)) != 0)
+           zc->zc_iflags, &tryconfig)) != 0)
                return (error);
 
        config = spa_tryimport(tryconfig);
@@ -933,8 +1363,13 @@ zfs_ioc_pool_tryimport(zfs_cmd_t *zc)
        return (error);
 }
 
+/*
+ * inputs:
+ * zc_name              name of the pool
+ * zc_cookie            scan func (pool_scan_func_t)
+ */
 static int
-zfs_ioc_pool_scrub(zfs_cmd_t *zc)
+zfs_ioc_pool_scan(zfs_cmd_t *zc)
 {
        spa_t *spa;
        int error;
@@ -942,7 +1377,10 @@ zfs_ioc_pool_scrub(zfs_cmd_t *zc)
        if ((error = spa_open(zc->zc_name, &spa, FTAG)) != 0)
                return (error);
 
-       error = spa_scrub(spa, zc->zc_cookie);
+       if (zc->zc_cookie == POOL_SCAN_NONE)
+               error = spa_scan_stop(spa);
+       else
+               error = spa_scan(spa, zc->zc_cookie);
 
        spa_close(spa, FTAG);
 
@@ -1005,9 +1443,9 @@ zfs_ioc_pool_get_history(zfs_cmd_t *zc)
        hist_buf = kmem_alloc(size, KM_SLEEP);
        if ((error = spa_history_get(spa, &zc->zc_history_offset,
            &zc->zc_history_len, hist_buf)) == 0) {
-               error = xcopyout(hist_buf,
-                   (char *)(uintptr_t)zc->zc_history,
-                   zc->zc_history_len);
+               error = ddi_copyout(hist_buf,
+                   (void *)(uintptr_t)zc->zc_history,
+                   zc->zc_history_len, zc->zc_iflags);
        }
 
        spa_close(spa, FTAG);
@@ -1020,24 +1458,65 @@ zfs_ioc_dsobj_to_dsname(zfs_cmd_t *zc)
 {
        int error;
 
-       if (error = dsl_dsobj_to_dsname(zc->zc_name, zc->zc_obj, zc->zc_value))
+       if ((error = dsl_dsobj_to_dsname(zc->zc_name,zc->zc_obj,zc->zc_value)))
                return (error);
 
        return (0);
 }
 
+/*
+ * inputs:
+ * zc_name             name of filesystem
+ * zc_obj              object to find
+ *
+ * outputs:
+ * zc_value            name of object
+ */
 static int
 zfs_ioc_obj_to_path(zfs_cmd_t *zc)
 {
-       objset_t *osp;
+       objset_t *os;
+       int error;
+
+       /* XXX reading from objset not owned */
+       if ((error = dmu_objset_hold(zc->zc_name, FTAG, &os)) != 0)
+               return (error);
+       if (dmu_objset_type(os) != DMU_OST_ZFS) {
+               dmu_objset_rele(os, FTAG);
+               return (EINVAL);
+       }
+       error = zfs_obj_to_path(os, zc->zc_obj, zc->zc_value,
+           sizeof (zc->zc_value));
+       dmu_objset_rele(os, FTAG);
+
+       return (error);
+}
+
+/*
+ * inputs:
+ * zc_name             name of filesystem
+ * zc_obj              object to find
+ *
+ * outputs:
+ * zc_stat             stats on object
+ * zc_value            path to object
+ */
+static int
+zfs_ioc_obj_to_stats(zfs_cmd_t *zc)
+{
+       objset_t *os;
        int error;
 
-       if ((error = dmu_objset_open(zc->zc_name, DMU_OST_ZFS,
-           DS_MODE_USER | DS_MODE_READONLY, &osp)) != 0)
+       /* XXX reading from objset not owned */
+       if ((error = dmu_objset_hold(zc->zc_name, FTAG, &os)) != 0)
                return (error);
-       error = zfs_obj_to_path(osp, zc->zc_obj, zc->zc_value,
+       if (dmu_objset_type(os) != DMU_OST_ZFS) {
+               dmu_objset_rele(os, FTAG);
+               return (EINVAL);
+       }
+       error = zfs_obj_to_stats(os, zc->zc_obj, &zc->zc_stat, zc->zc_value,
            sizeof (zc->zc_value));
-       dmu_objset_close(osp);
+       dmu_objset_rele(os, FTAG);
 
        return (error);
 }
@@ -1055,7 +1534,7 @@ zfs_ioc_vdev_add(zfs_cmd_t *zc)
                return (error);
 
        error = get_nvlist(zc->zc_nvlist_conf, zc->zc_nvlist_conf_size,
-           &config);
+           zc->zc_iflags, &config);
        (void) nvlist_lookup_nvlist_array(config, ZPOOL_CONFIG_L2CACHE,
            &l2cache, &nl2cache);
 
@@ -1072,7 +1551,8 @@ zfs_ioc_vdev_add(zfs_cmd_t *zc)
         *
         * l2cache and spare devices are ok to be added to a rootpool.
         */
-       if (spa->spa_bootfs != 0 && nl2cache == 0 && nspares == 0) {
+       if (spa_bootfs(spa) != 0 && nl2cache == 0 && nspares == 0) {
+               nvlist_free(config);
                spa_close(spa, FTAG);
                return (EDOM);
        }
@@ -1085,6 +1565,12 @@ zfs_ioc_vdev_add(zfs_cmd_t *zc)
        return (error);
 }
 
+/*
+ * inputs:
+ * zc_name             name of the pool
+ * zc_nvlist_conf      nvlist of devices to remove
+ * zc_cookie           to stop the remove?
+ */
 static int
 zfs_ioc_vdev_remove(zfs_cmd_t *zc)
 {
@@ -1118,11 +1604,19 @@ zfs_ioc_vdev_set_state(zfs_cmd_t *zc)
                break;
 
        case VDEV_STATE_FAULTED:
-               error = vdev_fault(spa, zc->zc_guid);
+               if (zc->zc_obj != VDEV_AUX_ERR_EXCEEDED &&
+                   zc->zc_obj != VDEV_AUX_EXTERNAL)
+                       zc->zc_obj = VDEV_AUX_ERR_EXCEEDED;
+
+               error = vdev_fault(spa, zc->zc_guid, zc->zc_obj);
                break;
 
        case VDEV_STATE_DEGRADED:
-               error = vdev_degrade(spa, zc->zc_guid);
+               if (zc->zc_obj != VDEV_AUX_ERR_EXCEEDED &&
+                   zc->zc_obj != VDEV_AUX_EXTERNAL)
+                       zc->zc_obj = VDEV_AUX_ERR_EXCEEDED;
+
+               error = vdev_degrade(spa, zc->zc_guid, zc->zc_obj);
                break;
 
        default:
@@ -1145,7 +1639,7 @@ zfs_ioc_vdev_attach(zfs_cmd_t *zc)
                return (error);
 
        if ((error = get_nvlist(zc->zc_nvlist_conf, zc->zc_nvlist_conf_size,
-           &config)) == 0) {
+           zc->zc_iflags, &config)) == 0) {
                error = spa_vdev_attach(spa, zc->zc_guid, config, replacing);
                nvlist_free(config);
        }
@@ -1170,6 +1664,41 @@ zfs_ioc_vdev_detach(zfs_cmd_t *zc)
 }
 
 static int
+zfs_ioc_vdev_split(zfs_cmd_t *zc)
+{
+       spa_t *spa;
+       nvlist_t *config, *props = NULL;
+       int error;
+       boolean_t exp = !!(zc->zc_cookie & ZPOOL_EXPORT_AFTER_SPLIT);
+
+       if ((error = spa_open(zc->zc_name, &spa, FTAG)) != 0)
+               return (error);
+
+       if ((error = get_nvlist(zc->zc_nvlist_conf, zc->zc_nvlist_conf_size,
+           zc->zc_iflags, &config))) {
+               spa_close(spa, FTAG);
+               return (error);
+       }
+
+       if (zc->zc_nvlist_src_size != 0 && (error =
+           get_nvlist(zc->zc_nvlist_src, zc->zc_nvlist_src_size,
+           zc->zc_iflags, &props))) {
+               spa_close(spa, FTAG);
+               nvlist_free(config);
+               return (error);
+       }
+
+       error = spa_vdev_split_mirror(spa, zc->zc_string, config, props, exp);
+
+       spa_close(spa, FTAG);
+
+       nvlist_free(config);
+       nvlist_free(props);
+
+       return (error);
+}
+
+static int
 zfs_ioc_vdev_setpath(zfs_cmd_t *zc)
 {
        spa_t *spa;
@@ -1186,6 +1715,53 @@ zfs_ioc_vdev_setpath(zfs_cmd_t *zc)
        return (error);
 }
 
+static int
+zfs_ioc_vdev_setfru(zfs_cmd_t *zc)
+{
+       spa_t *spa;
+       char *fru = zc->zc_value;
+       uint64_t guid = zc->zc_guid;
+       int error;
+
+       error = spa_open(zc->zc_name, &spa, FTAG);
+       if (error != 0)
+               return (error);
+
+       error = spa_vdev_setfru(spa, guid, fru);
+       spa_close(spa, FTAG);
+       return (error);
+}
+
+static int
+zfs_ioc_objset_stats_impl(zfs_cmd_t *zc, objset_t *os)
+{
+       int error = 0;
+       nvlist_t *nv;
+
+       dmu_objset_fast_stat(os, &zc->zc_objset_stats);
+
+       if (zc->zc_nvlist_dst != 0 &&
+           (error = dsl_prop_get_all(os, &nv)) == 0) {
+               dmu_objset_stats(os, nv);
+               /*
+                * NB: zvol_get_stats() will read the objset contents,
+                * which we aren't supposed to do with a
+                * DS_MODE_USER hold, because it could be
+                * inconsistent.  So this is a bit of a workaround...
+                * XXX reading with out owning
+                */
+               if (!zc->zc_objset_stats.dds_inconsistent) {
+                       if (dmu_objset_type(os) == DMU_OST_ZVOL)
+                               error = zvol_get_stats(os, nv);
+               }
+               if (error == 0)
+                       error = put_nvlist(zc, nv);
+               nvlist_free(nv);
+       }
+
+       return (error);
+}
+
 /*
  * inputs:
  * zc_name             name of filesystem
@@ -1201,32 +1777,57 @@ zfs_ioc_objset_stats(zfs_cmd_t *zc)
 {
        objset_t *os = NULL;
        int error;
+
+       if ((error = dmu_objset_hold(zc->zc_name, FTAG, &os)))
+               return (error);
+
+       error = zfs_ioc_objset_stats_impl(zc, os);
+
+       dmu_objset_rele(os, FTAG);
+
+       return (error);
+}
+
+/*
+ * inputs:
+ * zc_name             name of filesystem
+ * zc_nvlist_dst_size  size of buffer for property nvlist
+ *
+ * outputs:
+ * zc_nvlist_dst       received property nvlist
+ * zc_nvlist_dst_size  size of received property nvlist
+ *
+ * Gets received properties (distinct from local properties on or after
+ * SPA_VERSION_RECVD_PROPS) for callers who want to differentiate received from
+ * local property values.
+ */
+static int
+zfs_ioc_objset_recvd_props(zfs_cmd_t *zc)
+{
+       objset_t *os = NULL;
+       int error;
        nvlist_t *nv;
 
-       if (error = dmu_objset_open(zc->zc_name,
-           DMU_OST_ANY, DS_MODE_USER | DS_MODE_READONLY, &os))
+       if ((error = dmu_objset_hold(zc->zc_name, FTAG, &os)))
                return (error);
 
-       dmu_objset_fast_stat(os, &zc->zc_objset_stats);
+       /*
+        * Without this check, we would return local property values if the
+        * caller has not already received properties on or after
+        * SPA_VERSION_RECVD_PROPS.
+        */
+       if (!dsl_prop_get_hasrecvd(os)) {
+               dmu_objset_rele(os, FTAG);
+               return (ENOTSUP);
+       }
 
        if (zc->zc_nvlist_dst != 0 &&
-           (error = dsl_prop_get_all(os, &nv, FALSE)) == 0) {
-               dmu_objset_stats(os, nv);
-               /*
-                * NB: zvol_get_stats() will read the objset contents,
-                * which we aren't supposed to do with a
-                * DS_MODE_USER hold, because it could be
-                * inconsistent.  So this is a bit of a workaround...
-                */
-               if (!zc->zc_objset_stats.dds_inconsistent) {
-                       if (dmu_objset_type(os) == DMU_OST_ZVOL)
-                               VERIFY(zvol_get_stats(os, nv) == 0);
-               }
+           (error = dsl_prop_get_received(os, &nv)) == 0) {
                error = put_nvlist(zc, nv);
                nvlist_free(nv);
        }
 
-       dmu_objset_close(os);
+       dmu_objset_rele(os, FTAG);
        return (error);
 }
 
@@ -1261,8 +1862,8 @@ zfs_ioc_objset_zplprops(zfs_cmd_t *zc)
        objset_t *os;
        int err;
 
-       if (err = dmu_objset_open(zc->zc_name,
-           DMU_OST_ANY, DS_MODE_USER | DS_MODE_READONLY, &os))
+       /* XXX reading without owning */
+       if ((err = dmu_objset_hold(zc->zc_name, FTAG, &os)))
                return (err);
 
        dmu_objset_fast_stat(os, &zc->zc_objset_stats);
@@ -1272,7 +1873,7 @@ zfs_ioc_objset_zplprops(zfs_cmd_t *zc)
         * which we aren't supposed to do with a DS_MODE_USER
         * hold, because it could be inconsistent.
         */
-       if (zc->zc_nvlist_dst != NULL &&
+       if (zc->zc_nvlist_dst != 0 &&
            !zc->zc_objset_stats.dds_inconsistent &&
            dmu_objset_type(os) == DMU_OST_ZFS) {
                nvlist_t *nv;
@@ -1287,10 +1888,27 @@ zfs_ioc_objset_zplprops(zfs_cmd_t *zc)
        } else {
                err = ENOENT;
        }
-       dmu_objset_close(os);
+       dmu_objset_rele(os, FTAG);
        return (err);
 }
 
+static boolean_t
+dataset_name_hidden(const char *name)
+{
+       /*
+        * Skip over datasets that are not visible in this zone,
+        * internal datasets (which have a $ in their name), and
+        * temporary datasets (which have a % in their name).
+        */
+       if (strchr(name, '$') != NULL)
+               return (B_TRUE);
+       if (strchr(name, '%') != NULL)
+               return (B_TRUE);
+       if (!INGLOBALZONE(curproc) && !zone_dataset_visible(name, NULL))
+               return (B_TRUE);
+       return (B_FALSE);
+}
+
 /*
  * inputs:
  * zc_name             name of filesystem
@@ -1299,6 +1917,7 @@ zfs_ioc_objset_zplprops(zfs_cmd_t *zc)
  *
  * outputs:
  * zc_name             name of next filesystem
+ * zc_cookie           zap cursor
  * zc_objset_stats     stats
  * zc_nvlist_dst       property nvlist
  * zc_nvlist_dst_size  size of property nvlist
@@ -1309,9 +1928,10 @@ zfs_ioc_dataset_list_next(zfs_cmd_t *zc)
        objset_t *os;
        int error;
        char *p;
+       size_t orig_len = strlen(zc->zc_name);
 
-       if (error = dmu_objset_open(zc->zc_name,
-           DMU_OST_ANY, DS_MODE_USER | DS_MODE_READONLY, &os)) {
+top:
+       if ((error = dmu_objset_hold(zc->zc_name, FTAG, &os))) {
                if (error == ENOENT)
                        error = ESRCH;
                return (error);
@@ -1322,12 +1942,16 @@ zfs_ioc_dataset_list_next(zfs_cmd_t *zc)
                (void) strlcat(zc->zc_name, "/", sizeof (zc->zc_name));
        p = zc->zc_name + strlen(zc->zc_name);
 
+       /*
+        * Pre-fetch the datasets.  dmu_objset_prefetch() always returns 0
+        * but is not declared void because its called by dmu_objset_find().
+        */
        if (zc->zc_cookie == 0) {
                uint64_t cookie = 0;
                int len = sizeof (zc->zc_name) - (p - zc->zc_name);
 
                while (dmu_dir_list_next(os, len, p, NULL, &cookie) == 0)
-                       dmu_objset_prefetch(p, NULL);
+                       (void) dmu_objset_prefetch(p, NULL);
        }
 
        do {
@@ -1336,17 +1960,22 @@ zfs_ioc_dataset_list_next(zfs_cmd_t *zc)
                    NULL, &zc->zc_cookie);
                if (error == ENOENT)
                        error = ESRCH;
-       } while (error == 0 && !INGLOBALZONE(curproc) &&
-           !zone_dataset_visible(zc->zc_name, NULL));
-       dmu_objset_close(os);
+       } while (error == 0 && dataset_name_hidden(zc->zc_name) &&
+           !(zc->zc_iflags & FKIOCTL));
+       dmu_objset_rele(os, FTAG);
 
        /*
-        * If it's a hidden dataset (ie. with a '$' in its name), don't
-        * try to get stats for it.  Userland will skip over it.
+        * If it's an internal dataset (ie. with a '$' in its name),
+        * don't try to get stats for it, otherwise we'll return ENOENT.
         */
-       if (error == 0 && strchr(zc->zc_name, '$') == NULL)
+       if (error == 0 && strchr(zc->zc_name, '$') == NULL) {
                error = zfs_ioc_objset_stats(zc); /* fill in the stats */
-
+               if (error == ENOENT) {
+                       /* We lost a race with destroy, get the next one. */
+                       zc->zc_name[orig_len] = '\0';
+                       goto top;
+               }
+       }
        return (error);
 }
 
@@ -1368,265 +1997,479 @@ zfs_ioc_snapshot_list_next(zfs_cmd_t *zc)
        objset_t *os;
        int error;
 
-       error = dmu_objset_open(zc->zc_name,
-           DMU_OST_ANY, DS_MODE_USER | DS_MODE_READONLY, &os);
+top:
+       if (zc->zc_cookie == 0)
+               (void) dmu_objset_find(zc->zc_name, dmu_objset_prefetch,
+                   NULL, DS_FIND_SNAPSHOTS);
+
+       error = dmu_objset_hold(zc->zc_name, FTAG, &os);
        if (error)
                return (error == ENOENT ? ESRCH : error);
 
-       if (zc->zc_cookie == 0)
-               dmu_objset_find(zc->zc_name, dmu_objset_prefetch,
-                   NULL, DS_FIND_SNAPSHOTS);
        /*
         * A dataset name of maximum length cannot have any snapshots,
         * so exit immediately.
         */
        if (strlcat(zc->zc_name, "@", sizeof (zc->zc_name)) >= MAXNAMELEN) {
-               dmu_objset_close(os);
+               dmu_objset_rele(os, FTAG);
                return (ESRCH);
        }
 
        error = dmu_snapshot_list_next(os,
            sizeof (zc->zc_name) - strlen(zc->zc_name),
-           zc->zc_name + strlen(zc->zc_name), NULL, &zc->zc_cookie, NULL);
-       dmu_objset_close(os);
-       if (error == 0)
-               error = zfs_ioc_objset_stats(zc); /* fill in the stats */
-       else if (error == ENOENT)
+           zc->zc_name + strlen(zc->zc_name), &zc->zc_obj, &zc->zc_cookie,
+           NULL);
+
+       if (error == 0) {
+               dsl_dataset_t *ds;
+               dsl_pool_t *dp = os->os_dsl_dataset->ds_dir->dd_pool;
+
+               /*
+                * Since we probably don't have a hold on this snapshot,
+                * it's possible that the objsetid could have been destroyed
+                * and reused for a new objset. It's OK if this happens during
+                * a zfs send operation, since the new createtxg will be
+                * beyond the range we're interested in.
+                */
+               rw_enter(&dp->dp_config_rwlock, RW_READER);
+               error = dsl_dataset_hold_obj(dp, zc->zc_obj, FTAG, &ds);
+               rw_exit(&dp->dp_config_rwlock);
+               if (error) {
+                       if (error == ENOENT) {
+                               /* Racing with destroy, get the next one. */
+                               *strchr(zc->zc_name, '@') = '\0';
+                               dmu_objset_rele(os, FTAG);
+                               goto top;
+                       }
+               } else {
+                       objset_t *ossnap;
+
+                       error = dmu_objset_from_ds(ds, &ossnap);
+                       if (error == 0)
+                               error = zfs_ioc_objset_stats_impl(zc, ossnap);
+                       dsl_dataset_rele(ds, FTAG);
+               }
+       } else if (error == ENOENT) {
                error = ESRCH;
+       }
 
+       dmu_objset_rele(os, FTAG);
        /* if we failed, undo the @ that we tacked on to zc_name */
        if (error)
                *strchr(zc->zc_name, '@') = '\0';
        return (error);
 }
 
-int
-zfs_set_prop_nvlist(const char *name, nvlist_t *nvl)
+static int
+zfs_prop_set_userquota(const char *dsname, nvpair_t *pair)
 {
-       nvpair_t *elem;
-       int error;
-       uint64_t intval;
-       char *strval;
+       const char *propname = nvpair_name(pair);
+       uint64_t *valary;
+       unsigned int vallen;
+       const char *domain;
+       char *dash;
+       zfs_userquota_prop_t type;
+       uint64_t rid;
+       uint64_t quota;
+       zfsvfs_t *zfsvfs;
+       int err;
+
+       if (nvpair_type(pair) == DATA_TYPE_NVLIST) {
+               nvlist_t *attrs;
+               VERIFY(nvpair_value_nvlist(pair, &attrs) == 0);
+               if (nvlist_lookup_nvpair(attrs, ZPROP_VALUE,
+                   &pair) != 0)
+                       return (EINVAL);
+       }
 
        /*
-        * First validate permission to set all of the properties
+        * A correctly constructed propname is encoded as
+        * userquota@<rid>-<domain>.
         */
-       elem = NULL;
-       while ((elem = nvlist_next_nvpair(nvl, elem)) != NULL) {
-               const char *propname = nvpair_name(elem);
-               zfs_prop_t prop = zfs_name_to_prop(propname);
+       if ((dash = strchr(propname, '-')) == NULL ||
+           nvpair_value_uint64_array(pair, &valary, &vallen) != 0 ||
+           vallen != 3)
+               return (EINVAL);
 
-               if (prop == ZPROP_INVAL) {
-                       /*
-                        * If this is a user-defined property, it must be a
-                        * string, and there is no further validation to do.
-                        */
-                       if (!zfs_prop_user(propname) ||
-                           nvpair_type(elem) != DATA_TYPE_STRING)
-                               return (EINVAL);
+       domain = dash + 1;
+       type = valary[0];
+       rid = valary[1];
+       quota = valary[2];
 
-                       if (error = zfs_secpolicy_write_perms(name,
-                           ZFS_DELEG_PERM_USERPROP, CRED()))
-                               return (error);
-                       continue;
-               }
+       err = zfsvfs_hold(dsname, FTAG, &zfsvfs, B_FALSE);
+       if (err == 0) {
+               err = zfs_set_userquota(zfsvfs, type, domain, rid, quota);
+               zfsvfs_rele(zfsvfs, FTAG);
+       }
 
-               if ((error = zfs_secpolicy_setprop(name, prop, CRED())) != 0)
-                       return (error);
+       return (err);
+}
 
-               /*
-                * Check that this value is valid for this pool version
-                */
-               switch (prop) {
-               case ZFS_PROP_COMPRESSION:
-                       /*
-                        * If the user specified gzip compression, make sure
-                        * the SPA supports it. We ignore any errors here since
-                        * we'll catch them later.
-                        */
-                       if (nvpair_type(elem) == DATA_TYPE_UINT64 &&
-                           nvpair_value_uint64(elem, &intval) == 0) {
-                               if (intval >= ZIO_COMPRESS_GZIP_1 &&
-                                   intval <= ZIO_COMPRESS_GZIP_9 &&
-                                   zfs_earlier_version(name,
-                                   SPA_VERSION_GZIP_COMPRESSION))
-                                       return (ENOTSUP);
+/*
+ * If the named property is one that has a special function to set its value,
+ * return 0 on success and a positive error code on failure; otherwise if it is
+ * not one of the special properties handled by this function, return -1.
+ *
+ * XXX: It would be better for callers of the property interface if we handled
+ * these special cases in dsl_prop.c (in the dsl layer).
+ */
+static int
+zfs_prop_set_special(const char *dsname, zprop_source_t source,
+    nvpair_t *pair)
+{
+       const char *propname = nvpair_name(pair);
+       zfs_prop_t prop = zfs_name_to_prop(propname);
+       uint64_t intval;
+       int err;
 
-                               /*
-                                * If this is a bootable dataset then
-                                * verify that the compression algorithm
-                                * is supported for booting. We must return
-                                * something other than ENOTSUP since it
-                                * implies a downrev pool version.
-                                */
-                               if (zfs_is_bootfs(name) &&
-                                   !BOOTFS_COMPRESS_VALID(intval))
-                                       return (ERANGE);
-                       }
-                       break;
-
-               case ZFS_PROP_COPIES:
-                       if (zfs_earlier_version(name,
-                           SPA_VERSION_DITTO_BLOCKS))
-                               return (ENOTSUP);
-                       break;
-
-               case ZFS_PROP_SHARESMB:
-                       if (zpl_earlier_version(name, ZPL_VERSION_FUID))
-                               return (ENOTSUP);
-                       break;
+       if (prop == ZPROP_INVAL) {
+               if (zfs_prop_userquota(propname))
+                       return (zfs_prop_set_userquota(dsname, pair));
+               return (-1);
+       }
 
-               case ZFS_PROP_ACLINHERIT:
-                       if (nvpair_type(elem) == DATA_TYPE_UINT64 &&
-                           nvpair_value_uint64(elem, &intval) == 0)
-                               if (intval == ZFS_ACL_PASSTHROUGH_X &&
-                                   zfs_earlier_version(name,
-                                   SPA_VERSION_PASSTHROUGH_X))
-                                       return (ENOTSUP);
-               }
+       if (nvpair_type(pair) == DATA_TYPE_NVLIST) {
+               nvlist_t *attrs;
+               VERIFY(nvpair_value_nvlist(pair, &attrs) == 0);
+               VERIFY(nvlist_lookup_nvpair(attrs, ZPROP_VALUE,
+                   &pair) == 0);
        }
 
-       elem = NULL;
-       while ((elem = nvlist_next_nvpair(nvl, elem)) != NULL) {
-               const char *propname = nvpair_name(elem);
-               zfs_prop_t prop = zfs_name_to_prop(propname);
+       if (zfs_prop_get_type(prop) == PROP_TYPE_STRING)
+               return (-1);
 
-               if (prop == ZPROP_INVAL) {
-                       VERIFY(nvpair_value_string(elem, &strval) == 0);
-                       error = dsl_prop_set(name, propname, 1,
-                           strlen(strval) + 1, strval);
-                       if (error == 0)
-                               continue;
-                       else
-                               return (error);
-               }
+       VERIFY(0 == nvpair_value_uint64(pair, &intval));
 
-               switch (prop) {
-               case ZFS_PROP_QUOTA:
-                       if ((error = nvpair_value_uint64(elem, &intval)) != 0 ||
-                           (error = dsl_dir_set_quota(name, intval)) != 0)
-                               return (error);
-                       break;
+       switch (prop) {
+       case ZFS_PROP_QUOTA:
+               err = dsl_dir_set_quota(dsname, source, intval);
+               break;
+       case ZFS_PROP_REFQUOTA:
+               err = dsl_dataset_set_quota(dsname, source, intval);
+               break;
+       case ZFS_PROP_RESERVATION:
+               err = dsl_dir_set_reservation(dsname, source, intval);
+               break;
+       case ZFS_PROP_REFRESERVATION:
+               err = dsl_dataset_set_reservation(dsname, source, intval);
+               break;
+       case ZFS_PROP_VOLSIZE:
+               err = zvol_set_volsize(dsname, ddi_driver_major(zfs_dip),
+                   intval);
+               break;
+       case ZFS_PROP_VERSION:
+       {
+               zfsvfs_t *zfsvfs;
 
-               case ZFS_PROP_REFQUOTA:
-                       if ((error = nvpair_value_uint64(elem, &intval)) != 0 ||
-                           (error = dsl_dataset_set_quota(name, intval)) != 0)
-                               return (error);
+               if ((err = zfsvfs_hold(dsname, FTAG, &zfsvfs, B_TRUE)) != 0)
                        break;
 
-               case ZFS_PROP_RESERVATION:
-                       if ((error = nvpair_value_uint64(elem, &intval)) != 0 ||
-                           (error = dsl_dir_set_reservation(name,
-                           intval)) != 0)
-                               return (error);
-                       break;
+               err = zfs_set_version(zfsvfs, intval);
+               zfsvfs_rele(zfsvfs, FTAG);
 
-               case ZFS_PROP_REFRESERVATION:
-                       if ((error = nvpair_value_uint64(elem, &intval)) != 0 ||
-                           (error = dsl_dataset_set_reservation(name,
-                           intval)) != 0)
-                               return (error);
-                       break;
+               if (err == 0 && intval >= ZPL_VERSION_USERSPACE) {
+                       zfs_cmd_t *zc;
 
-               case ZFS_PROP_VOLSIZE:
-                       if ((error = nvpair_value_uint64(elem, &intval)) != 0 ||
-                           (error = zvol_set_volsize(name,
-                           ddi_driver_major(zfs_dip), intval)) != 0)
-                               return (error);
-                       break;
+                       zc = kmem_zalloc(sizeof (zfs_cmd_t), KM_SLEEP);
+                       (void) strcpy(zc->zc_name, dsname);
+                       (void) zfs_ioc_userspace_upgrade(zc);
+                       kmem_free(zc, sizeof (zfs_cmd_t));
+               }
+               break;
+       }
 
-               case ZFS_PROP_VOLBLOCKSIZE:
-                       if ((error = nvpair_value_uint64(elem, &intval)) != 0 ||
-                           (error = zvol_set_volblocksize(name, intval)) != 0)
-                               return (error);
-                       break;
+       default:
+               err = -1;
+       }
 
-               case ZFS_PROP_VERSION:
-                       if ((error = nvpair_value_uint64(elem, &intval)) != 0 ||
-                           (error = zfs_set_version(name, intval)) != 0)
-                               return (error);
-                       break;
+       return (err);
+}
 
-               default:
-                       if (nvpair_type(elem) == DATA_TYPE_STRING) {
-                               if (zfs_prop_get_type(prop) !=
-                                   PROP_TYPE_STRING)
-                                       return (EINVAL);
-                               VERIFY(nvpair_value_string(elem, &strval) == 0);
-                               if ((error = dsl_prop_set(name,
-                                   nvpair_name(elem), 1, strlen(strval) + 1,
-                                   strval)) != 0)
-                                       return (error);
-                       } else if (nvpair_type(elem) == DATA_TYPE_UINT64) {
+/*
+ * This function is best effort. If it fails to set any of the given properties,
+ * it continues to set as many as it can and returns the first error
+ * encountered. If the caller provides a non-NULL errlist, it also gives the
+ * complete list of names of all the properties it failed to set along with the
+ * corresponding error numbers. The caller is responsible for freeing the
+ * returned errlist.
+ *
+ * If every property is set successfully, zero is returned and the list pointed
+ * at by errlist is NULL.
+ */
+int
+zfs_set_prop_nvlist(const char *dsname, zprop_source_t source, nvlist_t *nvl,
+    nvlist_t **errlist)
+{
+       nvpair_t *pair;
+       nvpair_t *propval;
+       int rv = 0;
+       uint64_t intval;
+       char *strval;
+       nvlist_t *genericnvl;
+       nvlist_t *errors;
+       nvlist_t *retrynvl;
+
+       VERIFY(nvlist_alloc(&genericnvl, NV_UNIQUE_NAME, KM_SLEEP) == 0);
+       VERIFY(nvlist_alloc(&errors, NV_UNIQUE_NAME, KM_SLEEP) == 0);
+       VERIFY(nvlist_alloc(&retrynvl, NV_UNIQUE_NAME, KM_SLEEP) == 0);
+
+retry:
+       pair = NULL;
+       while ((pair = nvlist_next_nvpair(nvl, pair)) != NULL) {
+               const char *propname = nvpair_name(pair);
+               zfs_prop_t prop = zfs_name_to_prop(propname);
+               int err = 0;
+
+               /* decode the property value */
+               propval = pair;
+               if (nvpair_type(pair) == DATA_TYPE_NVLIST) {
+                       nvlist_t *attrs;
+                       VERIFY(nvpair_value_nvlist(pair, &attrs) == 0);
+                       if (nvlist_lookup_nvpair(attrs, ZPROP_VALUE,
+                           &propval) != 0)
+                               err = EINVAL;
+               }
+
+               /* Validate value type */
+               if (err == 0 && prop == ZPROP_INVAL) {
+                       if (zfs_prop_user(propname)) {
+                               if (nvpair_type(propval) != DATA_TYPE_STRING)
+                                       err = EINVAL;
+                       } else if (zfs_prop_userquota(propname)) {
+                               if (nvpair_type(propval) !=
+                                   DATA_TYPE_UINT64_ARRAY)
+                                       err = EINVAL;
+                       }
+               } else if (err == 0) {
+                       if (nvpair_type(propval) == DATA_TYPE_STRING) {
+                               if (zfs_prop_get_type(prop) != PROP_TYPE_STRING)
+                                       err = EINVAL;
+                       } else if (nvpair_type(propval) == DATA_TYPE_UINT64) {
                                const char *unused;
 
-                               VERIFY(nvpair_value_uint64(elem, &intval) == 0);
+                               VERIFY(nvpair_value_uint64(propval,
+                                   &intval) == 0);
 
                                switch (zfs_prop_get_type(prop)) {
                                case PROP_TYPE_NUMBER:
                                        break;
                                case PROP_TYPE_STRING:
-                                       return (EINVAL);
+                                       err = EINVAL;
+                                       break;
                                case PROP_TYPE_INDEX:
                                        if (zfs_prop_index_to_string(prop,
                                            intval, &unused) != 0)
-                                               return (EINVAL);
+                                               err = EINVAL;
                                        break;
                                default:
                                        cmn_err(CE_PANIC,
                                            "unknown property type");
-                                       break;
                                }
+                       } else {
+                               err = EINVAL;
+                       }
+               }
+
+               /* Validate permissions */
+               if (err == 0)
+                       err = zfs_check_settable(dsname, pair, CRED());
+
+               if (err == 0) {
+                       err = zfs_prop_set_special(dsname, source, pair);
+                       if (err == -1) {
+                               /*
+                                * For better performance we build up a list of
+                                * properties to set in a single transaction.
+                                */
+                               err = nvlist_add_nvpair(genericnvl, pair);
+                       } else if (err != 0 && nvl != retrynvl) {
+                               /*
+                                * This may be a spurious error caused by
+                                * receiving quota and reservation out of order.
+                                * Try again in a second pass.
+                                */
+                               err = nvlist_add_nvpair(retrynvl, pair);
+                       }
+               }
+
+               if (err != 0)
+                       VERIFY(nvlist_add_int32(errors, propname, err) == 0);
+       }
+
+       if (nvl != retrynvl && !nvlist_empty(retrynvl)) {
+               nvl = retrynvl;
+               goto retry;
+       }
+
+       if (!nvlist_empty(genericnvl) &&
+           dsl_props_set(dsname, source, genericnvl) != 0) {
+               /*
+                * If this fails, we still want to set as many properties as we
+                * can, so try setting them individually.
+                */
+               pair = NULL;
+               while ((pair = nvlist_next_nvpair(genericnvl, pair)) != NULL) {
+                       const char *propname = nvpair_name(pair);
+                       int err = 0;
+
+                       propval = pair;
+                       if (nvpair_type(pair) == DATA_TYPE_NVLIST) {
+                               nvlist_t *attrs;
+                               VERIFY(nvpair_value_nvlist(pair, &attrs) == 0);
+                               VERIFY(nvlist_lookup_nvpair(attrs, ZPROP_VALUE,
+                                   &propval) == 0);
+                       }
 
-                               if ((error = dsl_prop_set(name, propname,
-                                   8, 1, &intval)) != 0)
-                                       return (error);
+                       if (nvpair_type(propval) == DATA_TYPE_STRING) {
+                               VERIFY(nvpair_value_string(propval,
+                                   &strval) == 0);
+                               err = dsl_prop_set(dsname, propname, source, 1,
+                                   strlen(strval) + 1, strval);
                        } else {
-                               return (EINVAL);
+                               VERIFY(nvpair_value_uint64(propval,
+                                   &intval) == 0);
+                               err = dsl_prop_set(dsname, propname, source, 8,
+                                   1, &intval);
+                       }
+
+                       if (err != 0) {
+                               VERIFY(nvlist_add_int32(errors, propname,
+                                   err) == 0);
                        }
-                       break;
                }
        }
+       nvlist_free(genericnvl);
+       nvlist_free(retrynvl);
+
+       if ((pair = nvlist_next_nvpair(errors, NULL)) == NULL) {
+               nvlist_free(errors);
+               errors = NULL;
+       } else {
+               VERIFY(nvpair_value_int32(pair, &rv) == 0);
+       }
+
+       if (errlist == NULL)
+               nvlist_free(errors);
+       else
+               *errlist = errors;
+
+       return (rv);
+}
+
+/*
+ * Check that all the properties are valid user properties.
+ */
+static int
+zfs_check_userprops(char *fsname, nvlist_t *nvl)
+{
+       nvpair_t *pair = NULL;
+       int error = 0;
+
+       while ((pair = nvlist_next_nvpair(nvl, pair)) != NULL) {
+               const char *propname = nvpair_name(pair);
+               char *valstr;
+
+               if (!zfs_prop_user(propname) ||
+                   nvpair_type(pair) != DATA_TYPE_STRING)
+                       return (EINVAL);
+
+               if ((error = zfs_secpolicy_write_perms(fsname,
+                   ZFS_DELEG_PERM_USERPROP, CRED())))
+                       return (error);
+
+               if (strlen(propname) >= ZAP_MAXNAMELEN)
+                       return (ENAMETOOLONG);
 
+               VERIFY(nvpair_value_string(pair, &valstr) == 0);
+               if (strlen(valstr) >= ZAP_MAXVALUELEN)
+                       return (E2BIG);
+       }
        return (0);
 }
 
+static void
+props_skip(nvlist_t *props, nvlist_t *skipped, nvlist_t **newprops)
+{
+       nvpair_t *pair;
+
+       VERIFY(nvlist_alloc(newprops, NV_UNIQUE_NAME, KM_SLEEP) == 0);
+
+       pair = NULL;
+       while ((pair = nvlist_next_nvpair(props, pair)) != NULL) {
+               if (nvlist_exists(skipped, nvpair_name(pair)))
+                       continue;
+
+               VERIFY(nvlist_add_nvpair(*newprops, pair) == 0);
+       }
+}
+
+static int
+clear_received_props(objset_t *os, const char *fs, nvlist_t *props,
+    nvlist_t *skipped)
+{
+       int err = 0;
+       nvlist_t *cleared_props = NULL;
+       props_skip(props, skipped, &cleared_props);
+       if (!nvlist_empty(cleared_props)) {
+               /*
+                * Acts on local properties until the dataset has received
+                * properties at least once on or after SPA_VERSION_RECVD_PROPS.
+                */
+               zprop_source_t flags = (ZPROP_SRC_NONE |
+                   (dsl_prop_get_hasrecvd(os) ? ZPROP_SRC_RECEIVED : 0));
+               err = zfs_set_prop_nvlist(fs, flags, cleared_props, NULL);
+       }
+       nvlist_free(cleared_props);
+       return (err);
+}
+
 /*
  * inputs:
  * zc_name             name of filesystem
- * zc_value            name of property to inherit
+ * zc_value            name of property to set
  * zc_nvlist_src{_size}        nvlist of properties to apply
- * zc_cookie           clear existing local props?
+ * zc_cookie           received properties flag
  *
- * outputs:            none
+ * outputs:
+ * zc_nvlist_dst{_size} error for each unapplied received property
  */
 static int
 zfs_ioc_set_prop(zfs_cmd_t *zc)
 {
        nvlist_t *nvl;
+       boolean_t received = zc->zc_cookie;
+       zprop_source_t source = (received ? ZPROP_SRC_RECEIVED :
+           ZPROP_SRC_LOCAL);
+       nvlist_t *errors = NULL;
        int error;
 
        if ((error = get_nvlist(zc->zc_nvlist_src, zc->zc_nvlist_src_size,
-           &nvl)) != 0)
+           zc->zc_iflags, &nvl)) != 0)
                return (error);
 
-       if (zc->zc_cookie) {
+       if (received) {
                nvlist_t *origprops;
                objset_t *os;
 
-               if (dmu_objset_open(zc->zc_name, DMU_OST_ANY,
-                   DS_MODE_USER | DS_MODE_READONLY, &os) == 0) {
-                       if (dsl_prop_get_all(os, &origprops, TRUE) == 0) {
-                               clear_props(zc->zc_name, origprops, nvl);
+               if (dmu_objset_hold(zc->zc_name, FTAG, &os) == 0) {
+                       if (dsl_prop_get_received(os, &origprops) == 0) {
+                               (void) clear_received_props(os,
+                                   zc->zc_name, origprops, nvl);
                                nvlist_free(origprops);
                        }
-                       dmu_objset_close(os);
-               }
 
+                       dsl_prop_set_hasrecvd(os);
+                       dmu_objset_rele(os, FTAG);
+               }
        }
 
-       error = zfs_set_prop_nvlist(zc->zc_name, nvl);
+       error = zfs_set_prop_nvlist(zc->zc_name, source, nvl, &errors);
+
+       if (zc->zc_nvlist_dst != 0 && errors != NULL) {
+               (void) put_nvlist(zc, errors);
+       }
 
+       nvlist_free(errors);
        nvlist_free(nvl);
        return (error);
 }
@@ -1635,14 +2478,75 @@ zfs_ioc_set_prop(zfs_cmd_t *zc)
  * inputs:
  * zc_name             name of filesystem
  * zc_value            name of property to inherit
+ * zc_cookie           revert to received value if TRUE
  *
  * outputs:            none
  */
 static int
 zfs_ioc_inherit_prop(zfs_cmd_t *zc)
 {
+       const char *propname = zc->zc_value;
+       zfs_prop_t prop = zfs_name_to_prop(propname);
+       boolean_t received = zc->zc_cookie;
+       zprop_source_t source = (received
+           ? ZPROP_SRC_NONE            /* revert to received value, if any */
+           : ZPROP_SRC_INHERITED);     /* explicitly inherit */
+
+       if (received) {
+               nvlist_t *dummy;
+               nvpair_t *pair;
+               zprop_type_t type;
+               int err;
+
+               /*
+                * zfs_prop_set_special() expects properties in the form of an
+                * nvpair with type info.
+                */
+               if (prop == ZPROP_INVAL) {
+                       if (!zfs_prop_user(propname))
+                               return (EINVAL);
+
+                       type = PROP_TYPE_STRING;
+               } else if (prop == ZFS_PROP_VOLSIZE ||
+                   prop == ZFS_PROP_VERSION) {
+                       return (EINVAL);
+               } else {
+                       type = zfs_prop_get_type(prop);
+               }
+
+               VERIFY(nvlist_alloc(&dummy, NV_UNIQUE_NAME, KM_SLEEP) == 0);
+
+               switch (type) {
+               case PROP_TYPE_STRING:
+                       VERIFY(0 == nvlist_add_string(dummy, propname, ""));
+                       break;
+               case PROP_TYPE_NUMBER:
+               case PROP_TYPE_INDEX:
+                       VERIFY(0 == nvlist_add_uint64(dummy, propname, 0));
+                       break;
+               default:
+                       nvlist_free(dummy);
+                       return (EINVAL);
+               }
+
+               pair = nvlist_next_nvpair(dummy, NULL);
+               err = zfs_prop_set_special(zc->zc_name, source, pair);
+               nvlist_free(dummy);
+               if (err != -1)
+                       return (err); /* special property already handled */
+       } else {
+               /*
+                * Only check this in the non-received case. We want to allow
+                * 'inherit -S' to revert non-inheritable properties like quota
+                * and reservation to the received or default values even though
+                * they are not considered inheritable.
+                */
+               if (prop != ZPROP_INVAL && !zfs_prop_inheritable(prop))
+                       return (EINVAL);
+       }
+
        /* the property name has been validated by zfs_secpolicy_inherit() */
-       return (dsl_prop_set(zc->zc_name, zc->zc_value, 0, 0, NULL));
+       return (dsl_prop_set(zc->zc_name, zc->zc_value, source, 0, 0, NULL));
 }
 
 static int
@@ -1651,28 +2555,30 @@ zfs_ioc_pool_set_props(zfs_cmd_t *zc)
        nvlist_t *props;
        spa_t *spa;
        int error;
-       nvpair_t *elem;
+       nvpair_t *pair;
 
        if ((error = get_nvlist(zc->zc_nvlist_src, zc->zc_nvlist_src_size,
-           &props)))
+           zc->zc_iflags, &props)))
                return (error);
 
        /*
         * If the only property is the configfile, then just do a spa_lookup()
         * to handle the faulted case.
         */
-       elem = nvlist_next_nvpair(props, NULL);
-       if (elem != NULL && strcmp(nvpair_name(elem),
+       pair = nvlist_next_nvpair(props, NULL);
+       if (pair != NULL && strcmp(nvpair_name(pair),
            zpool_prop_to_name(ZPOOL_PROP_CACHEFILE)) == 0 &&
-           nvlist_next_nvpair(props, elem) == NULL) {
+           nvlist_next_nvpair(props, pair) == NULL) {
                mutex_enter(&spa_namespace_lock);
                if ((spa = spa_lookup(zc->zc_name)) != NULL) {
                        spa_configfile_set(spa, props, B_FALSE);
                        spa_config_sync(spa, B_FALSE, B_TRUE);
                }
                mutex_exit(&spa_namespace_lock);
-               if (spa != NULL)
+               if (spa != NULL) {
+                       nvlist_free(props);
                        return (0);
+               }
        }
 
        if ((error = spa_open(zc->zc_name, &spa, FTAG)) != 0) {
@@ -1710,7 +2616,7 @@ zfs_ioc_pool_get_props(zfs_cmd_t *zc)
                spa_close(spa, FTAG);
        }
 
-       if (error == 0 && zc->zc_nvlist_dst != NULL)
+       if (error == 0 && zc->zc_nvlist_dst != 0)
                error = put_nvlist(zc, nvp);
        else
                error = EFAULT;
@@ -1719,53 +2625,6 @@ zfs_ioc_pool_get_props(zfs_cmd_t *zc)
        return (error);
 }
 
-static int
-zfs_ioc_iscsi_perm_check(zfs_cmd_t *zc)
-{
-       nvlist_t *nvp;
-       int error;
-       uint32_t uid;
-       uint32_t gid;
-       uint32_t *groups;
-       uint_t group_cnt;
-       cred_t  *usercred;
-
-       if ((error = get_nvlist(zc->zc_nvlist_src, zc->zc_nvlist_src_size,
-           &nvp)) != 0) {
-               return (error);
-       }
-
-       if ((error = nvlist_lookup_uint32(nvp,
-           ZFS_DELEG_PERM_UID, &uid)) != 0) {
-               nvlist_free(nvp);
-               return (EPERM);
-       }
-
-       if ((error = nvlist_lookup_uint32(nvp,
-           ZFS_DELEG_PERM_GID, &gid)) != 0) {
-               nvlist_free(nvp);
-               return (EPERM);
-       }
-
-       if ((error = nvlist_lookup_uint32_array(nvp, ZFS_DELEG_PERM_GROUPS,
-           &groups, &group_cnt)) != 0) {
-               nvlist_free(nvp);
-               return (EPERM);
-       }
-       usercred = cralloc();
-       if ((crsetugid(usercred, uid, gid) != 0) ||
-           (crsetgroups(usercred, group_cnt, (gid_t *)groups) != 0)) {
-               nvlist_free(nvp);
-               crfree(usercred);
-               return (EPERM);
-       }
-       nvlist_free(nvp);
-       error = dsl_deleg_access(zc->zc_name,
-           zfs_prop_to_name(ZFS_PROP_SHAREISCSI), usercred);
-       crfree(usercred);
-       return (error);
-}
-
 /*
  * inputs:
  * zc_name             name of filesystem
@@ -1781,7 +2640,7 @@ zfs_ioc_set_fsacl(zfs_cmd_t *zc)
        nvlist_t *fsaclnv = NULL;
 
        if ((error = get_nvlist(zc->zc_nvlist_src, zc->zc_nvlist_src_size,
-           &fsaclnv)) != 0)
+           zc->zc_iflags, &fsaclnv)) != 0)
                return (error);
 
        /*
@@ -1838,30 +2697,6 @@ zfs_ioc_get_fsacl(zfs_cmd_t *zc)
 }
 
 /*
- * inputs:
- * zc_name             name of volume
- *
- * outputs:            none
- */
-static int
-zfs_ioc_create_minor(zfs_cmd_t *zc)
-{
-       return (zvol_create_minor(zc->zc_name, ddi_driver_major(zfs_dip)));
-}
-
-/*
- * inputs:
- * zc_name             name of volume
- *
- * outputs:            none
- */
-static int
-zfs_ioc_remove_minor(zfs_cmd_t *zc)
-{
-       return (zvol_remove_minor(zc->zc_name));
-}
-
-/*
  * Search the vfs list for a specified resource.  Returns a pointer to it
  * or NULL if no suitable entry is found. The caller of this routine
  * is responsible for releasing the returned vfs pointer.
@@ -1918,11 +2753,10 @@ zfs_create_cb(objset_t *os, void *arg, cred_t *cr, dmu_tx_t *tx)
  * processing.
  */
 static int
-zfs_fill_zplprops_impl(objset_t *os, uint64_t default_zplver,
-    boolean_t fuids_ok, nvlist_t *createprops, nvlist_t *zplprops,
-    boolean_t *is_ci)
+zfs_fill_zplprops_impl(objset_t *os, uint64_t zplver,
+    boolean_t fuids_ok, boolean_t sa_ok, nvlist_t *createprops,
+    nvlist_t *zplprops, boolean_t *is_ci)
 {
-       uint64_t zplver = default_zplver;
        uint64_t sense = ZFS_PROP_UNDEFINED;
        uint64_t norm = ZFS_PROP_UNDEFINED;
        uint64_t u8 = ZFS_PROP_UNDEFINED;
@@ -1957,6 +2791,7 @@ zfs_fill_zplprops_impl(objset_t *os, uint64_t default_zplver,
         */
        if ((zplver < ZPL_VERSION_INITIAL || zplver > ZPL_VERSION) ||
            (zplver >= ZPL_VERSION_FUID && !fuids_ok) ||
+           (zplver >= ZPL_VERSION_SA && !sa_ok) ||
            (zplver < ZPL_VERSION_NORMALIZATION &&
            (norm != ZFS_PROP_UNDEFINED || u8 != ZFS_PROP_UNDEFINED ||
            sense != ZFS_PROP_UNDEFINED)))
@@ -1998,11 +2833,13 @@ static int
 zfs_fill_zplprops(const char *dataset, nvlist_t *createprops,
     nvlist_t *zplprops, boolean_t *is_ci)
 {
-       boolean_t fuids_ok = B_TRUE;
+       boolean_t fuids_ok, sa_ok;
        uint64_t zplver = ZPL_VERSION;
        objset_t *os = NULL;
        char parentname[MAXNAMELEN];
        char *cp;
+       spa_t *spa;
+       uint64_t spa_vers;
        int error;
 
        (void) strlcpy(parentname, dataset, sizeof (parentname));
@@ -2010,21 +2847,25 @@ zfs_fill_zplprops(const char *dataset, nvlist_t *createprops,
        ASSERT(cp != NULL);
        cp[0] = '\0';
 
-       if (zfs_earlier_version(dataset, SPA_VERSION_FUID)) {
-               zplver = ZPL_VERSION_FUID - 1;
-               fuids_ok = B_FALSE;
-       }
+       if ((error = spa_open(dataset, &spa, FTAG)) != 0)
+               return (error);
+
+       spa_vers = spa_version(spa);
+       spa_close(spa, FTAG);
+
+       zplver = zfs_zpl_version_map(spa_vers);
+       fuids_ok = (zplver >= ZPL_VERSION_FUID);
+       sa_ok = (zplver >= ZPL_VERSION_SA);
 
        /*
         * Open parent object set so we can inherit zplprop values.
         */
-       if ((error = dmu_objset_open(parentname, DMU_OST_ANY,
-           DS_MODE_USER | DS_MODE_READONLY, &os)) != 0)
+       if ((error = dmu_objset_hold(parentname, FTAG, &os)) != 0)
                return (error);
 
-       error = zfs_fill_zplprops_impl(os, zplver, fuids_ok, createprops,
+       error = zfs_fill_zplprops_impl(os, zplver, fuids_ok, sa_ok, createprops,
            zplprops, is_ci);
-       dmu_objset_close(os);
+       dmu_objset_rele(os, FTAG);
        return (error);
 }
 
@@ -2032,17 +2873,17 @@ static int
 zfs_fill_zplprops_root(uint64_t spa_vers, nvlist_t *createprops,
     nvlist_t *zplprops, boolean_t *is_ci)
 {
-       boolean_t fuids_ok = B_TRUE;
+       boolean_t fuids_ok;
+       boolean_t sa_ok;
        uint64_t zplver = ZPL_VERSION;
        int error;
 
-       if (spa_vers < SPA_VERSION_FUID) {
-               zplver = ZPL_VERSION_FUID - 1;
-               fuids_ok = B_FALSE;
-       }
+       zplver = zfs_zpl_version_map(spa_vers);
+       fuids_ok = (zplver >= ZPL_VERSION_FUID);
+       sa_ok = (zplver >= ZPL_VERSION_SA);
 
-       error = zfs_fill_zplprops_impl(NULL, zplver, fuids_ok, createprops,
-           zplprops, is_ci);
+       error = zfs_fill_zplprops_impl(NULL, zplver, fuids_ok, sa_ok,
+           createprops, zplprops, is_ci);
        return (error);
 }
 
@@ -2083,9 +2924,9 @@ zfs_ioc_create(zfs_cmd_t *zc)
            strchr(zc->zc_name, '%'))
                return (EINVAL);
 
-       if (zc->zc_nvlist_src != NULL &&
+       if (zc->zc_nvlist_src != 0 &&
            (error = get_nvlist(zc->zc_nvlist_src, zc->zc_nvlist_src_size,
-           &nvprops)) != 0)
+           zc->zc_iflags, &nvprops)) != 0)
                return (error);
 
        zct.zct_zplprops = NULL;
@@ -2101,21 +2942,18 @@ zfs_ioc_create(zfs_cmd_t *zc)
                        return (EINVAL);
                }
 
-               error = dmu_objset_open(zc->zc_value, type,
-                   DS_MODE_USER | DS_MODE_READONLY, &clone);
+               error = dmu_objset_hold(zc->zc_value, FTAG, &clone);
                if (error) {
                        nvlist_free(nvprops);
                        return (error);
                }
 
-               error = dmu_objset_create(zc->zc_name, type, clone, 0,
-                   NULL, NULL);
+               error = dmu_objset_clone(zc->zc_name, dmu_objset_ds(clone), 0);
+               dmu_objset_rele(clone, FTAG);
                if (error) {
-                       dmu_objset_close(clone);
                        nvlist_free(nvprops);
                        return (error);
                }
-               dmu_objset_close(clone);
        } else {
                boolean_t is_insensitive = B_FALSE;
 
@@ -2172,7 +3010,7 @@ zfs_ioc_create(zfs_cmd_t *zc)
                                return (error);
                        }
                }
-               error = dmu_objset_create(zc->zc_name, type, NULL,
+               error = dmu_objset_create(zc->zc_name, type,
                    is_insensitive ? DS_FLAG_CI_DATASET : 0, cbfunc, &zct);
                nvlist_free(zct.zct_zplprops);
        }
@@ -2181,41 +3019,24 @@ zfs_ioc_create(zfs_cmd_t *zc)
         * It would be nice to do this atomically.
         */
        if (error == 0) {
-               if ((error = zfs_set_prop_nvlist(zc->zc_name, nvprops)) != 0)
-                       (void) dmu_objset_destroy(zc->zc_name);
+               error = zfs_set_prop_nvlist(zc->zc_name, ZPROP_SRC_LOCAL,
+                   nvprops, NULL);
+               if (error != 0)
+                       (void) dmu_objset_destroy(zc->zc_name, B_FALSE);
        }
        nvlist_free(nvprops);
        return (error);
 }
 
-struct snap_prop_arg {
-       nvlist_t *nvprops;
-       const char *snapname;
-};
-
-static int
-set_snap_props(char *name, void *arg)
-{
-       struct snap_prop_arg *snpa = arg;
-       int len = strlen(name) + strlen(snpa->snapname) + 2;
-       char *buf = kmem_alloc(len, KM_SLEEP);
-       int err;
-
-       (void) snprintf(buf, len, "%s@%s", name, snpa->snapname);
-       err = zfs_set_prop_nvlist(buf, snpa->nvprops);
-       if (err)
-               (void) dmu_objset_destroy(buf);
-       kmem_free(buf, len);
-       return (err);
-}
-
 /*
  * inputs:
  * zc_name     name of filesystem
  * zc_value    short name of snapshot
  * zc_cookie   recursive flag
+ * zc_nvlist_src[_size] property list
  *
- * outputs:    none
+ * outputs:
+ * zc_value    short snapname (i.e. part after the '@')
  */
 static int
 zfs_ioc_snapshot(zfs_cmd_t *zc)
@@ -2227,50 +3048,39 @@ zfs_ioc_snapshot(zfs_cmd_t *zc)
        if (snapshot_namecheck(zc->zc_value, NULL, NULL) != 0)
                return (EINVAL);
 
-       if (zc->zc_nvlist_src != NULL &&
+       if (zc->zc_nvlist_src != 0 &&
            (error = get_nvlist(zc->zc_nvlist_src, zc->zc_nvlist_src_size,
-           &nvprops)) != 0)
+           zc->zc_iflags, &nvprops)) != 0)
                return (error);
 
-       error = dmu_objset_snapshot(zc->zc_name, zc->zc_value, recursive);
+       error = zfs_check_userprops(zc->zc_name, nvprops);
+       if (error)
+               goto out;
 
-       /*
-        * It would be nice to do this atomically.
-        */
-       if (error == 0) {
-               struct snap_prop_arg snpa;
-               snpa.nvprops = nvprops;
-               snpa.snapname = zc->zc_value;
-               if (recursive) {
-                       error = dmu_objset_find(zc->zc_name,
-                           set_snap_props, &snpa, DS_FIND_CHILDREN);
-                       if (error) {
-                               (void) dmu_snapshots_destroy(zc->zc_name,
-                                   zc->zc_value);
-                       }
-               } else {
-                       error = set_snap_props(zc->zc_name, &snpa);
-               }
+       if (!nvlist_empty(nvprops) &&
+           zfs_earlier_version(zc->zc_name, SPA_VERSION_SNAP_PROPS)) {
+               error = ENOTSUP;
+               goto out;
        }
+
+       error = dmu_objset_snapshot(zc->zc_name, zc->zc_value, NULL,
+           nvprops, recursive, B_FALSE, -1);
+
+out:
        nvlist_free(nvprops);
        return (error);
 }
 
 int
-zfs_unmount_snap(char *name, void *arg)
+zfs_unmount_snap(const char *name, void *arg)
 {
        vfs_t *vfsp = NULL;
 
        if (arg) {
                char *snapname = arg;
-               int len = strlen(name) + strlen(snapname) + 2;
-               char *buf = kmem_alloc(len, KM_SLEEP);
-
-               (void) strcpy(buf, name);
-               (void) strcat(buf, "@");
-               (void) strcat(buf, snapname);
-               vfsp = zfs_get_vfs(buf);
-               kmem_free(buf, len);
+               char *fullname = kmem_asprintf("%s@%s", name, snapname);
+               vfsp = zfs_get_vfs(fullname);
+               strfree(fullname);
        } else if (strchr(name, '@')) {
                vfsp = zfs_get_vfs(name);
        }
@@ -2295,8 +3105,9 @@ zfs_unmount_snap(char *name, void *arg)
 
 /*
  * inputs:
- * zc_name     name of filesystem
- * zc_value    short name of snapshot
+ * zc_name             name of filesystem
+ * zc_value            short name of snapshot
+ * zc_defer_destroy    mark for deferred destroy
  *
  * outputs:    none
  */
@@ -2311,26 +3122,32 @@ zfs_ioc_destroy_snaps(zfs_cmd_t *zc)
            zfs_unmount_snap, zc->zc_value, DS_FIND_CHILDREN);
        if (err)
                return (err);
-       return (dmu_snapshots_destroy(zc->zc_name, zc->zc_value));
+       return (dmu_snapshots_destroy(zc->zc_name, zc->zc_value,
+           zc->zc_defer_destroy));
 }
 
 /*
  * inputs:
  * zc_name             name of dataset to destroy
  * zc_objset_type      type of objset
+ * zc_defer_destroy    mark for deferred destroy
  *
  * outputs:            none
  */
 static int
 zfs_ioc_destroy(zfs_cmd_t *zc)
 {
+       int err;
        if (strchr(zc->zc_name, '@') && zc->zc_objset_type == DMU_OST_ZFS) {
-               int err = zfs_unmount_snap(zc->zc_name, NULL);
+               err = zfs_unmount_snap(zc->zc_name, NULL);
                if (err)
                        return (err);
        }
 
-       return (dmu_objset_destroy(zc->zc_name));
+       err = dmu_objset_destroy(zc->zc_name, zc->zc_defer_destroy);
+       if (zc->zc_objset_type == DMU_OST_ZVOL && err == 0)
+               (void) zvol_remove_minor(zc->zc_name);
+       return (err);
 }
 
 /*
@@ -2342,50 +3159,78 @@ zfs_ioc_destroy(zfs_cmd_t *zc)
 static int
 zfs_ioc_rollback(zfs_cmd_t *zc)
 {
-       objset_t *os;
+       dsl_dataset_t *ds, *clone;
        int error;
-       zfsvfs_t *zfsvfs = NULL;
+       zfsvfs_t *zfsvfs;
+       char *clone_name;
 
-       /*
-        * Get the zfsvfs for the receiving objset. There
-        * won't be one if we're operating on a zvol, if the
-        * objset doesn't exist yet, or is not mounted.
-        */
-       error = dmu_objset_open(zc->zc_name, DMU_OST_ANY, DS_MODE_USER, &os);
+       error = dsl_dataset_hold(zc->zc_name, FTAG, &ds);
        if (error)
                return (error);
 
-       if (dmu_objset_type(os) == DMU_OST_ZFS) {
-               mutex_enter(&os->os->os_user_ptr_lock);
-               zfsvfs = dmu_objset_get_user(os);
-               if (zfsvfs != NULL)
-                       VFS_HOLD(zfsvfs->z_vfs);
-               mutex_exit(&os->os->os_user_ptr_lock);
+       /* must not be a snapshot */
+       if (dsl_dataset_is_snapshot(ds)) {
+               dsl_dataset_rele(ds, FTAG);
+               return (EINVAL);
+       }
+
+       /* must have a most recent snapshot */
+       if (ds->ds_phys->ds_prev_snap_txg < TXG_INITIAL) {
+               dsl_dataset_rele(ds, FTAG);
+               return (EINVAL);
        }
 
-       if (zfsvfs != NULL) {
-               char *osname;
-               int mode;
+       /*
+        * Create clone of most recent snapshot.
+        */
+       clone_name = kmem_asprintf("%s/%%rollback", zc->zc_name);
+       error = dmu_objset_clone(clone_name, ds->ds_prev, DS_FLAG_INCONSISTENT);
+       if (error)
+               goto out;
+
+       error = dsl_dataset_own(clone_name, B_TRUE, FTAG, &clone);
+       if (error)
+               goto out;
 
-               osname = kmem_alloc(MAXNAMELEN, KM_SLEEP);
-               error = zfs_suspend_fs(zfsvfs, osname, &mode);
+       /*
+        * Do clone swap.
+        */
+       if (getzfsvfs(zc->zc_name, &zfsvfs) == 0) {
+               error = zfs_suspend_fs(zfsvfs);
                if (error == 0) {
                        int resume_err;
 
-                       ASSERT(strcmp(osname, zc->zc_name) == 0);
-                       error = dmu_objset_rollback(os);
-                       resume_err = zfs_resume_fs(zfsvfs, osname, mode);
+                       if (dsl_dataset_tryown(ds, B_FALSE, FTAG)) {
+                               error = dsl_dataset_clone_swap(clone, ds,
+                                   B_TRUE);
+                               dsl_dataset_disown(ds, FTAG);
+                               ds = NULL;
+                       } else {
+                               error = EBUSY;
+                       }
+                       resume_err = zfs_resume_fs(zfsvfs, zc->zc_name);
                        error = error ? error : resume_err;
-               } else {
-                       dmu_objset_close(os);
                }
-               kmem_free(osname, MAXNAMELEN);
                VFS_RELE(zfsvfs->z_vfs);
        } else {
-               error = dmu_objset_rollback(os);
+               if (dsl_dataset_tryown(ds, B_FALSE, FTAG)) {
+                       error = dsl_dataset_clone_swap(clone, ds, B_TRUE);
+                       dsl_dataset_disown(ds, FTAG);
+                       ds = NULL;
+               } else {
+                       error = EBUSY;
+               }
        }
-       /* Note, the dmu_objset_rollback() releases the objset for us. */
 
+       /*
+        * Destroy clone (which also closes it).
+        */
+       (void) dsl_dataset_destroy(clone, FTAG, B_FALSE);
+
+out:
+       strfree(clone_name);
+       if (ds)
+               dsl_dataset_rele(ds, FTAG);
        return (error);
 }
 
@@ -2418,31 +3263,269 @@ zfs_ioc_rename(zfs_cmd_t *zc)
                if (err)
                        return (err);
        }
+       if (zc->zc_objset_type == DMU_OST_ZVOL)
+               (void) zvol_remove_minor(zc->zc_name);
        return (dmu_objset_rename(zc->zc_name, zc->zc_value, recursive));
 }
 
-static void
-clear_props(char *dataset, nvlist_t *props, nvlist_t *newprops)
+static int
+zfs_check_settable(const char *dsname, nvpair_t *pair, cred_t *cr)
+{
+       const char *propname = nvpair_name(pair);
+       boolean_t issnap = (strchr(dsname, '@') != NULL);
+       zfs_prop_t prop = zfs_name_to_prop(propname);
+       uint64_t intval;
+       int err;
+
+       if (prop == ZPROP_INVAL) {
+               if (zfs_prop_user(propname)) {
+                       if ((err = zfs_secpolicy_write_perms(dsname,
+                           ZFS_DELEG_PERM_USERPROP, cr)))
+                               return (err);
+                       return (0);
+               }
+
+               if (!issnap && zfs_prop_userquota(propname)) {
+                       const char *perm = NULL;
+                       const char *uq_prefix =
+                           zfs_userquota_prop_prefixes[ZFS_PROP_USERQUOTA];
+                       const char *gq_prefix =
+                           zfs_userquota_prop_prefixes[ZFS_PROP_GROUPQUOTA];
+
+                       if (strncmp(propname, uq_prefix,
+                           strlen(uq_prefix)) == 0) {
+                               perm = ZFS_DELEG_PERM_USERQUOTA;
+                       } else if (strncmp(propname, gq_prefix,
+                           strlen(gq_prefix)) == 0) {
+                               perm = ZFS_DELEG_PERM_GROUPQUOTA;
+                       } else {
+                               /* USERUSED and GROUPUSED are read-only */
+                               return (EINVAL);
+                       }
+
+                       if ((err = zfs_secpolicy_write_perms(dsname, perm, cr)))
+                               return (err);
+                       return (0);
+               }
+
+               return (EINVAL);
+       }
+
+       if (issnap)
+               return (EINVAL);
+
+       if (nvpair_type(pair) == DATA_TYPE_NVLIST) {
+               /*
+                * dsl_prop_get_all_impl() returns properties in this
+                * format.
+                */
+               nvlist_t *attrs;
+               VERIFY(nvpair_value_nvlist(pair, &attrs) == 0);
+               VERIFY(nvlist_lookup_nvpair(attrs, ZPROP_VALUE,
+                   &pair) == 0);
+       }
+
+       /*
+        * Check that this value is valid for this pool version
+        */
+       switch (prop) {
+       case ZFS_PROP_COMPRESSION:
+               /*
+                * If the user specified gzip compression, make sure
+                * the SPA supports it. We ignore any errors here since
+                * we'll catch them later.
+                */
+               if (nvpair_type(pair) == DATA_TYPE_UINT64 &&
+                   nvpair_value_uint64(pair, &intval) == 0) {
+                       if (intval >= ZIO_COMPRESS_GZIP_1 &&
+                           intval <= ZIO_COMPRESS_GZIP_9 &&
+                           zfs_earlier_version(dsname,
+                           SPA_VERSION_GZIP_COMPRESSION)) {
+                               return (ENOTSUP);
+                       }
+
+                       if (intval == ZIO_COMPRESS_ZLE &&
+                           zfs_earlier_version(dsname,
+                           SPA_VERSION_ZLE_COMPRESSION))
+                               return (ENOTSUP);
+
+                       /*
+                        * If this is a bootable dataset then
+                        * verify that the compression algorithm
+                        * is supported for booting. We must return
+                        * something other than ENOTSUP since it
+                        * implies a downrev pool version.
+                        */
+                       if (zfs_is_bootfs(dsname) &&
+                           !BOOTFS_COMPRESS_VALID(intval)) {
+                               return (ERANGE);
+                       }
+               }
+               break;
+
+       case ZFS_PROP_COPIES:
+               if (zfs_earlier_version(dsname, SPA_VERSION_DITTO_BLOCKS))
+                       return (ENOTSUP);
+               break;
+
+       case ZFS_PROP_DEDUP:
+               if (zfs_earlier_version(dsname, SPA_VERSION_DEDUP))
+                       return (ENOTSUP);
+               break;
+
+       case ZFS_PROP_SHARESMB:
+               if (zpl_earlier_version(dsname, ZPL_VERSION_FUID))
+                       return (ENOTSUP);
+               break;
+
+       case ZFS_PROP_ACLINHERIT:
+               if (nvpair_type(pair) == DATA_TYPE_UINT64 &&
+                   nvpair_value_uint64(pair, &intval) == 0) {
+                       if (intval == ZFS_ACL_PASSTHROUGH_X &&
+                           zfs_earlier_version(dsname,
+                           SPA_VERSION_PASSTHROUGH_X))
+                               return (ENOTSUP);
+               }
+               break;
+       default:
+               break;
+       }
+
+       return (zfs_secpolicy_setprop(dsname, prop, pair, CRED()));
+}
+
+/*
+ * Removes properties from the given props list that fail permission checks
+ * needed to clear them and to restore them in case of a receive error. For each
+ * property, make sure we have both set and inherit permissions.
+ *
+ * Returns the first error encountered if any permission checks fail. If the
+ * caller provides a non-NULL errlist, it also gives the complete list of names
+ * of all the properties that failed a permission check along with the
+ * corresponding error numbers. The caller is responsible for freeing the
+ * returned errlist.
+ *
+ * If every property checks out successfully, zero is returned and the list
+ * pointed at by errlist is NULL.
+ */
+static int
+zfs_check_clearable(char *dataset, nvlist_t *props, nvlist_t **errlist)
 {
        zfs_cmd_t *zc;
-       nvpair_t *prop;
+       nvpair_t *pair, *next_pair;
+       nvlist_t *errors;
+       int err, rv = 0;
 
        if (props == NULL)
-               return;
+               return (0);
+
+       VERIFY(nvlist_alloc(&errors, NV_UNIQUE_NAME, KM_SLEEP) == 0);
+
        zc = kmem_alloc(sizeof (zfs_cmd_t), KM_SLEEP);
        (void) strcpy(zc->zc_name, dataset);
-       for (prop = nvlist_next_nvpair(props, NULL); prop;
-           prop = nvlist_next_nvpair(props, prop)) {
-               if (newprops != NULL &&
-                   nvlist_exists(newprops, nvpair_name(prop)))
-                       continue;
-               (void) strcpy(zc->zc_value, nvpair_name(prop));
-               if (zfs_secpolicy_inherit(zc, CRED()) == 0)
-                       (void) zfs_ioc_inherit_prop(zc);
+       pair = nvlist_next_nvpair(props, NULL);
+       while (pair != NULL) {
+               next_pair = nvlist_next_nvpair(props, pair);
+
+               (void) strcpy(zc->zc_value, nvpair_name(pair));
+               if ((err = zfs_check_settable(dataset, pair, CRED())) != 0 ||
+                   (err = zfs_secpolicy_inherit(zc, CRED())) != 0) {
+                       VERIFY(nvlist_remove_nvpair(props, pair) == 0);
+                       VERIFY(nvlist_add_int32(errors,
+                           zc->zc_value, err) == 0);
+               }
+               pair = next_pair;
        }
        kmem_free(zc, sizeof (zfs_cmd_t));
+
+       if ((pair = nvlist_next_nvpair(errors, NULL)) == NULL) {
+               nvlist_free(errors);
+               errors = NULL;
+       } else {
+               VERIFY(nvpair_value_int32(pair, &rv) == 0);
+       }
+
+       if (errlist == NULL)
+               nvlist_free(errors);
+       else
+               *errlist = errors;
+
+       return (rv);
+}
+
+static boolean_t
+propval_equals(nvpair_t *p1, nvpair_t *p2)
+{
+       if (nvpair_type(p1) == DATA_TYPE_NVLIST) {
+               /* dsl_prop_get_all_impl() format */
+               nvlist_t *attrs;
+               VERIFY(nvpair_value_nvlist(p1, &attrs) == 0);
+               VERIFY(nvlist_lookup_nvpair(attrs, ZPROP_VALUE,
+                   &p1) == 0);
+       }
+
+       if (nvpair_type(p2) == DATA_TYPE_NVLIST) {
+               nvlist_t *attrs;
+               VERIFY(nvpair_value_nvlist(p2, &attrs) == 0);
+               VERIFY(nvlist_lookup_nvpair(attrs, ZPROP_VALUE,
+                   &p2) == 0);
+       }
+
+       if (nvpair_type(p1) != nvpair_type(p2))
+               return (B_FALSE);
+
+       if (nvpair_type(p1) == DATA_TYPE_STRING) {
+               char *valstr1, *valstr2;
+
+               VERIFY(nvpair_value_string(p1, (char **)&valstr1) == 0);
+               VERIFY(nvpair_value_string(p2, (char **)&valstr2) == 0);
+               return (strcmp(valstr1, valstr2) == 0);
+       } else {
+               uint64_t intval1, intval2;
+
+               VERIFY(nvpair_value_uint64(p1, &intval1) == 0);
+               VERIFY(nvpair_value_uint64(p2, &intval2) == 0);
+               return (intval1 == intval2);
+       }
+}
+
+/*
+ * Remove properties from props if they are not going to change (as determined
+ * by comparison with origprops). Remove them from origprops as well, since we
+ * do not need to clear or restore properties that won't change.
+ */
+static void
+props_reduce(nvlist_t *props, nvlist_t *origprops)
+{
+       nvpair_t *pair, *next_pair;
+
+       if (origprops == NULL)
+               return; /* all props need to be received */
+
+       pair = nvlist_next_nvpair(props, NULL);
+       while (pair != NULL) {
+               const char *propname = nvpair_name(pair);
+               nvpair_t *match;
+
+               next_pair = nvlist_next_nvpair(props, pair);
+
+               if ((nvlist_lookup_nvpair(origprops, propname,
+                   &match) != 0) || !propval_equals(pair, match))
+                       goto next; /* need to set received value */
+
+               /* don't clear the existing received value */
+               (void) nvlist_remove_nvpair(origprops, match);
+               /* don't bother receiving the property */
+               (void) nvlist_remove_nvpair(props, pair);
+next:
+               pair = next_pair;
+       }
 }
 
+#ifdef DEBUG
+static boolean_t zfs_ioc_recv_inject_err;
+#endif
+
 /*
  * inputs:
  * zc_name             name of containing filesystem
@@ -2452,9 +3535,14 @@ clear_props(char *dataset, nvlist_t *props, nvlist_t *newprops)
  * zc_cookie           file descriptor to recv from
  * zc_begin_record     the BEGIN record of the stream (not byteswapped)
  * zc_guid             force flag
+ * zc_cleanup_fd       cleanup-on-exit file descriptor
+ * zc_action_handle    handle for this guid/ds mapping (or zero on first call)
  *
  * outputs:
  * zc_cookie           number of bytes read
+ * zc_nvlist_dst{_size} error for each unapplied received property
+ * zc_obj              zprop_errflags_t
+ * zc_action_handle    handle for this guid/ds mapping
  */
 static int
 zfs_ioc_recv(zfs_cmd_t *zc)
@@ -2462,15 +3550,18 @@ zfs_ioc_recv(zfs_cmd_t *zc)
        file_t *fp;
        objset_t *os;
        dmu_recv_cookie_t drc;
-       zfsvfs_t *zfsvfs = NULL;
        boolean_t force = (boolean_t)zc->zc_guid;
-       int error, fd;
+       int fd;
+       int error = 0;
+       int props_error = 0;
+       nvlist_t *errors;
        offset_t off;
-       nvlist_t *props = NULL;
-       nvlist_t *origprops = NULL;
+       nvlist_t *props = NULL; /* sent properties */
+       nvlist_t *origprops = NULL; /* existing properties */
        objset_t *origin = NULL;
        char *tosnap;
        char tofs[ZFS_MAXNAMELEN];
+       boolean_t first_recvd_props = B_FALSE;
 
        if (dataset_namecheck(zc->zc_value, NULL, NULL) != 0 ||
            strchr(zc->zc_value, '@') == NULL ||
@@ -2479,12 +3570,11 @@ zfs_ioc_recv(zfs_cmd_t *zc)
 
        (void) strcpy(tofs, zc->zc_value);
        tosnap = strchr(tofs, '@');
-       *tosnap = '\0';
-       tosnap++;
+       *tosnap++ = '\0';
 
-       if (zc->zc_nvlist_src != NULL &&
+       if (zc->zc_nvlist_src != 0 &&
            (error = get_nvlist(zc->zc_nvlist_src, zc->zc_nvlist_src_size,
-           &props)) != 0)
+           zc->zc_iflags, &props)) != 0)
                return (error);
 
        fd = zc->zc_cookie;
@@ -2494,114 +3584,190 @@ zfs_ioc_recv(zfs_cmd_t *zc)
                return (EBADF);
        }
 
-       if (dmu_objset_open(tofs, DMU_OST_ANY,
-           DS_MODE_USER | DS_MODE_READONLY, &os) == 0) {
-               /*
-                * Try to get the zfsvfs for the receiving objset.
-                * There won't be one if we're operating on a zvol,
-                * if the objset doesn't exist yet, or is not mounted.
-                */
-               mutex_enter(&os->os->os_user_ptr_lock);
-               if (zfsvfs = dmu_objset_get_user(os)) {
-                       if (!mutex_tryenter(&zfsvfs->z_online_recv_lock)) {
-                               mutex_exit(&os->os->os_user_ptr_lock);
-                               dmu_objset_close(os);
-                               zfsvfs = NULL;
-                               error = EBUSY;
-                               goto out;
-                       }
-                       VFS_HOLD(zfsvfs->z_vfs);
+       VERIFY(nvlist_alloc(&errors, NV_UNIQUE_NAME, KM_SLEEP) == 0);
+
+       if (props && dmu_objset_hold(tofs, FTAG, &os) == 0) {
+               if ((spa_version(os->os_spa) >= SPA_VERSION_RECVD_PROPS) &&
+                   !dsl_prop_get_hasrecvd(os)) {
+                       first_recvd_props = B_TRUE;
                }
-               mutex_exit(&os->os->os_user_ptr_lock);
 
                /*
-                * If new properties are supplied, they are to completely
-                * replace the existing ones, so stash away the existing ones.
+                * If new received properties are supplied, they are to
+                * completely replace the existing received properties, so stash
+                * away the existing ones.
                 */
-               if (props)
-                       (void) dsl_prop_get_all(os, &origprops, TRUE);
+               if (dsl_prop_get_received(os, &origprops) == 0) {
+                       nvlist_t *errlist = NULL;
+                       /*
+                        * Don't bother writing a property if its value won't
+                        * change (and avoid the unnecessary security checks).
+                        *
+                        * The first receive after SPA_VERSION_RECVD_PROPS is a
+                        * special case where we blow away all local properties
+                        * regardless.
+                        */
+                       if (!first_recvd_props)
+                               props_reduce(props, origprops);
+                       if (zfs_check_clearable(tofs, origprops,
+                           &errlist) != 0)
+                               (void) nvlist_merge(errors, errlist, 0);
+                       nvlist_free(errlist);
+               }
 
-               dmu_objset_close(os);
+               dmu_objset_rele(os, FTAG);
        }
 
        if (zc->zc_string[0]) {
-               error = dmu_objset_open(zc->zc_string, DMU_OST_ANY,
-                   DS_MODE_USER | DS_MODE_READONLY, &origin);
+               error = dmu_objset_hold(zc->zc_string, FTAG, &origin);
                if (error)
                        goto out;
        }
 
-       error = dmu_recv_begin(tofs, tosnap, &zc->zc_begin_record,
-           force, origin, zfsvfs != NULL, &drc);
+       error = dmu_recv_begin(tofs, tosnap, zc->zc_top_ds,
+           &zc->zc_begin_record, force, origin, &drc);
        if (origin)
-               dmu_objset_close(origin);
+               dmu_objset_rele(origin, FTAG);
        if (error)
                goto out;
 
        /*
-        * Reset properties.  We do this before we receive the stream
-        * so that the properties are applied to the new data.
+        * Set properties before we receive the stream so that they are applied
+        * to the new data. Note that we must call dmu_recv_stream() if
+        * dmu_recv_begin() succeeds.
         */
        if (props) {
-               clear_props(tofs, origprops, props);
+               nvlist_t *errlist;
+
+               if (dmu_objset_from_ds(drc.drc_logical_ds, &os) == 0) {
+                       if (drc.drc_newfs) {
+                               if (spa_version(os->os_spa) >=
+                                   SPA_VERSION_RECVD_PROPS)
+                                       first_recvd_props = B_TRUE;
+                       } else if (origprops != NULL) {
+                               if (clear_received_props(os, tofs, origprops,
+                                   first_recvd_props ? NULL : props) != 0)
+                                       zc->zc_obj |= ZPROP_ERR_NOCLEAR;
+                       } else {
+                               zc->zc_obj |= ZPROP_ERR_NOCLEAR;
+                       }
+                       dsl_prop_set_hasrecvd(os);
+               } else if (!drc.drc_newfs) {
+                       zc->zc_obj |= ZPROP_ERR_NOCLEAR;
+               }
+
+               (void) zfs_set_prop_nvlist(tofs, ZPROP_SRC_RECEIVED,
+                   props, &errlist);
+               (void) nvlist_merge(errors, errlist, 0);
+               nvlist_free(errlist);
+       }
+
+       if (fit_error_list(zc, &errors) != 0 || put_nvlist(zc, errors) != 0) {
                /*
-                * XXX - Note, this is all-or-nothing; should be best-effort.
+                * Caller made zc->zc_nvlist_dst less than the minimum expected
+                * size or supplied an invalid address.
                 */
-               (void) zfs_set_prop_nvlist(tofs, props);
+               props_error = EINVAL;
        }
 
        off = fp->f_offset;
-       error = dmu_recv_stream(&drc, fp->f_vnode, &off);
+       error = dmu_recv_stream(&drc, fp->f_vnode, &off, zc->zc_cleanup_fd,
+           &zc->zc_action_handle);
 
-       if (error == 0 && zfsvfs) {
-               char *osname;
-               int mode;
+       if (error == 0) {
+               zfsvfs_t *zfsvfs = NULL;
 
-               /* online recv */
-               osname = kmem_alloc(MAXNAMELEN, KM_SLEEP);
-               error = zfs_suspend_fs(zfsvfs, osname, &mode);
-               if (error == 0) {
-                       int resume_err;
+               if (getzfsvfs(tofs, &zfsvfs) == 0) {
+                       /* online recv */
+                       int end_err;
 
-                       error = dmu_recv_end(&drc);
-                       resume_err = zfs_resume_fs(zfsvfs, osname, mode);
-                       error = error ? error : resume_err;
+                       error = zfs_suspend_fs(zfsvfs);
+                       /*
+                        * If the suspend fails, then the recv_end will
+                        * likely also fail, and clean up after itself.
+                        */
+                       end_err = dmu_recv_end(&drc);
+                       if (error == 0)
+                               error = zfs_resume_fs(zfsvfs, tofs);
+                       error = error ? error : end_err;
+                       VFS_RELE(zfsvfs->z_vfs);
                } else {
-                       dmu_recv_abort_cleanup(&drc);
+                       error = dmu_recv_end(&drc);
                }
-               kmem_free(osname, MAXNAMELEN);
-       } else if (error == 0) {
-               error = dmu_recv_end(&drc);
        }
 
        zc->zc_cookie = off - fp->f_offset;
        if (VOP_SEEK(fp->f_vnode, fp->f_offset, &off, NULL) == 0)
                fp->f_offset = off;
 
+#ifdef DEBUG
+       if (zfs_ioc_recv_inject_err) {
+               zfs_ioc_recv_inject_err = B_FALSE;
+               error = 1;
+       }
+#endif
        /*
         * On error, restore the original props.
         */
        if (error && props) {
-               clear_props(tofs, props, NULL);
-               (void) zfs_set_prop_nvlist(tofs, origprops);
+               if (dmu_objset_hold(tofs, FTAG, &os) == 0) {
+                       if (clear_received_props(os, tofs, props, NULL) != 0) {
+                               /*
+                                * We failed to clear the received properties.
+                                * Since we may have left a $recvd value on the
+                                * system, we can't clear the $hasrecvd flag.
+                                */
+                               zc->zc_obj |= ZPROP_ERR_NORESTORE;
+                       } else if (first_recvd_props) {
+                               dsl_prop_unset_hasrecvd(os);
+                       }
+                       dmu_objset_rele(os, FTAG);
+               } else if (!drc.drc_newfs) {
+                       /* We failed to clear the received properties. */
+                       zc->zc_obj |= ZPROP_ERR_NORESTORE;
+               }
+
+               if (origprops == NULL && !drc.drc_newfs) {
+                       /* We failed to stash the original properties. */
+                       zc->zc_obj |= ZPROP_ERR_NORESTORE;
+               }
+
+               /*
+                * dsl_props_set() will not convert RECEIVED to LOCAL on or
+                * after SPA_VERSION_RECVD_PROPS, so we need to specify LOCAL
+                * explictly if we're restoring local properties cleared in the
+                * first new-style receive.
+                */
+               if (origprops != NULL &&
+                   zfs_set_prop_nvlist(tofs, (first_recvd_props ?
+                   ZPROP_SRC_LOCAL : ZPROP_SRC_RECEIVED),
+                   origprops, NULL) != 0) {
+                       /*
+                        * We stashed the original properties but failed to
+                        * restore them.
+                        */
+                       zc->zc_obj |= ZPROP_ERR_NORESTORE;
+               }
        }
 out:
-       if (zfsvfs) {
-               mutex_exit(&zfsvfs->z_online_recv_lock);
-               VFS_RELE(zfsvfs->z_vfs);
-       }
        nvlist_free(props);
        nvlist_free(origprops);
+       nvlist_free(errors);
        releasef(fd);
+
+       if (error == 0)
+               error = props_error;
+
        return (error);
 }
 
 /*
  * inputs:
  * zc_name     name of snapshot to send
- * zc_value    short name of incremental fromsnap (may be empty)
  * zc_cookie   file descriptor to send stream to
- * zc_obj      fromorigin flag (mutually exclusive with zc_value)
+ * zc_obj      fromorigin flag (mutually exclusive with zc_fromobj)
+ * zc_sendobj  objsetid of snapshot to send
+ * zc_fromobj  objsetid of incremental fromsnap (may be zero)
  *
  * outputs: none
  */
@@ -2613,36 +3779,55 @@ zfs_ioc_send(zfs_cmd_t *zc)
        file_t *fp;
        int error;
        offset_t off;
+       dsl_dataset_t *ds;
+       dsl_dataset_t *dsfrom = NULL;
+       spa_t *spa;
+       dsl_pool_t *dp;
 
-       error = dmu_objset_open(zc->zc_name, DMU_OST_ANY,
-           DS_MODE_USER | DS_MODE_READONLY, &tosnap);
+       error = spa_open(zc->zc_name, &spa, FTAG);
        if (error)
                return (error);
 
-       if (zc->zc_value[0] != '\0') {
-               char *buf;
-               char *cp;
-
-               buf = kmem_alloc(MAXPATHLEN, KM_SLEEP);
-               (void) strncpy(buf, zc->zc_name, MAXPATHLEN);
-               cp = strchr(buf, '@');
-               if (cp)
-                       *(cp+1) = 0;
-               (void) strncat(buf, zc->zc_value, MAXPATHLEN);
-               error = dmu_objset_open(buf, DMU_OST_ANY,
-                   DS_MODE_USER | DS_MODE_READONLY, &fromsnap);
-               kmem_free(buf, MAXPATHLEN);
+       dp = spa_get_dsl(spa);
+       rw_enter(&dp->dp_config_rwlock, RW_READER);
+       error = dsl_dataset_hold_obj(dp, zc->zc_sendobj, FTAG, &ds);
+       rw_exit(&dp->dp_config_rwlock);
+       if (error) {
+               spa_close(spa, FTAG);
+               return (error);
+       }
+
+       error = dmu_objset_from_ds(ds, &tosnap);
+       if (error) {
+               dsl_dataset_rele(ds, FTAG);
+               spa_close(spa, FTAG);
+               return (error);
+       }
+
+       if (zc->zc_fromobj != 0) {
+               rw_enter(&dp->dp_config_rwlock, RW_READER);
+               error = dsl_dataset_hold_obj(dp, zc->zc_fromobj, FTAG, &dsfrom);
+               rw_exit(&dp->dp_config_rwlock);
+               spa_close(spa, FTAG);
+               if (error) {
+                       dsl_dataset_rele(ds, FTAG);
+                       return (error);
+               }
+               error = dmu_objset_from_ds(dsfrom, &fromsnap);
                if (error) {
-                       dmu_objset_close(tosnap);
+                       dsl_dataset_rele(dsfrom, FTAG);
+                       dsl_dataset_rele(ds, FTAG);
                        return (error);
                }
+       } else {
+               spa_close(spa, FTAG);
        }
 
        fp = getf(zc->zc_cookie);
        if (fp == NULL) {
-               dmu_objset_close(tosnap);
-               if (fromsnap)
-                       dmu_objset_close(fromsnap);
+               dsl_dataset_rele(ds, FTAG);
+               if (dsfrom)
+                       dsl_dataset_rele(dsfrom, FTAG);
                return (EBADF);
        }
 
@@ -2652,9 +3837,9 @@ zfs_ioc_send(zfs_cmd_t *zc)
        if (VOP_SEEK(fp->f_vnode, fp->f_offset, &off, NULL) == 0)
                fp->f_offset = off;
        releasef(zc->zc_cookie);
-       if (fromsnap)
-               dmu_objset_close(fromsnap);
-       dmu_objset_close(tosnap);
+       if (dsfrom)
+               dsl_dataset_rele(dsfrom, FTAG);
+       dsl_dataset_rele(ds, FTAG);
        return (error);
 }
 
@@ -2730,16 +3915,41 @@ zfs_ioc_clear(zfs_cmd_t *zc)
                mutex_exit(&spa_namespace_lock);
                return (EIO);
        }
-       if (spa->spa_log_state == SPA_LOG_MISSING) {
+       if (spa_get_log_state(spa) == SPA_LOG_MISSING) {
                /* we need to let spa_open/spa_load clear the chains */
-               spa->spa_log_state = SPA_LOG_CLEAR;
+               spa_set_log_state(spa, SPA_LOG_CLEAR);
        }
+       spa->spa_last_open_failed = 0;
        mutex_exit(&spa_namespace_lock);
 
-       if ((error = spa_open(zc->zc_name, &spa, FTAG)) != 0)
+       if (zc->zc_cookie & ZPOOL_NO_REWIND) {
+               error = spa_open(zc->zc_name, &spa, FTAG);
+       } else {
+               nvlist_t *policy;
+               nvlist_t *config = NULL;
+
+               if (zc->zc_nvlist_src == 0)
+                       return (EINVAL);
+
+               if ((error = get_nvlist(zc->zc_nvlist_src,
+                   zc->zc_nvlist_src_size, zc->zc_iflags, &policy)) == 0) {
+                       error = spa_open_rewind(zc->zc_name, &spa, FTAG,
+                           policy, &config);
+                       if (config != NULL) {
+                               int err;
+
+                               if ((err = put_nvlist(zc, config)) != 0)
+                                       error = err;
+                               nvlist_free(config);
+                       }
+                       nvlist_free(policy);
+               }
+       }
+
+       if (error)
                return (error);
 
-       spa_vdev_state_enter(spa);
+       spa_vdev_state_enter(spa, SCL_NONE);
 
        if (zc->zc_guid == 0) {
                vd = NULL;
@@ -2759,11 +3969,12 @@ zfs_ioc_clear(zfs_cmd_t *zc)
        /*
         * Resume any suspended I/Os.
         */
-       zio_resume(spa);
+       if (zio_resume(spa) != 0)
+               error = EIO;
 
        spa_close(spa, FTAG);
 
-       return (0);
+       return (error);
 }
 
 /*
@@ -2771,7 +3982,8 @@ zfs_ioc_clear(zfs_cmd_t *zc)
  * zc_name     name of filesystem
  * zc_value    name of origin snapshot
  *
- * outputs:    none
+ * outputs:
+ * zc_string   name of conflicting snapshot, if there is one
  */
 static int
 zfs_ioc_promote(zfs_cmd_t *zc)
@@ -2787,7 +3999,120 @@ zfs_ioc_promote(zfs_cmd_t *zc)
                *cp = '\0';
        (void) dmu_objset_find(zc->zc_value,
            zfs_unmount_snap, NULL, DS_FIND_SNAPSHOTS);
-       return (dsl_dataset_promote(zc->zc_name));
+       return (dsl_dataset_promote(zc->zc_name, zc->zc_string));
+}
+
+/*
+ * Retrieve a single {user|group}{used|quota}@... property.
+ *
+ * inputs:
+ * zc_name     name of filesystem
+ * zc_objset_type zfs_userquota_prop_t
+ * zc_value    domain name (eg. "S-1-234-567-89")
+ * zc_guid     RID/UID/GID
+ *
+ * outputs:
+ * zc_cookie   property value
+ */
+static int
+zfs_ioc_userspace_one(zfs_cmd_t *zc)
+{
+       zfsvfs_t *zfsvfs;
+       int error;
+
+       if (zc->zc_objset_type >= ZFS_NUM_USERQUOTA_PROPS)
+               return (EINVAL);
+
+       error = zfsvfs_hold(zc->zc_name, FTAG, &zfsvfs, B_FALSE);
+       if (error)
+               return (error);
+
+       error = zfs_userspace_one(zfsvfs,
+           zc->zc_objset_type, zc->zc_value, zc->zc_guid, &zc->zc_cookie);
+       zfsvfs_rele(zfsvfs, FTAG);
+
+       return (error);
+}
+
+/*
+ * inputs:
+ * zc_name             name of filesystem
+ * zc_cookie           zap cursor
+ * zc_objset_type      zfs_userquota_prop_t
+ * zc_nvlist_dst[_size] buffer to fill (not really an nvlist)
+ *
+ * outputs:
+ * zc_nvlist_dst[_size]        data buffer (array of zfs_useracct_t)
+ * zc_cookie   zap cursor
+ */
+static int
+zfs_ioc_userspace_many(zfs_cmd_t *zc)
+{
+       zfsvfs_t *zfsvfs;
+       int bufsize = zc->zc_nvlist_dst_size;
+
+       if (bufsize <= 0)
+               return (ENOMEM);
+
+       int error = zfsvfs_hold(zc->zc_name, FTAG, &zfsvfs, B_FALSE);
+       if (error)
+               return (error);
+
+       void *buf = kmem_alloc(bufsize, KM_SLEEP);
+
+       error = zfs_userspace_many(zfsvfs, zc->zc_objset_type, &zc->zc_cookie,
+           buf, &zc->zc_nvlist_dst_size);
+
+       if (error == 0) {
+               error = xcopyout(buf,
+                   (void *)(uintptr_t)zc->zc_nvlist_dst,
+                   zc->zc_nvlist_dst_size);
+       }
+       kmem_free(buf, bufsize);
+       zfsvfs_rele(zfsvfs, FTAG);
+
+       return (error);
+}
+
+/*
+ * inputs:
+ * zc_name             name of filesystem
+ *
+ * outputs:
+ * none
+ */
+static int
+zfs_ioc_userspace_upgrade(zfs_cmd_t *zc)
+{
+       objset_t *os;
+       int error = 0;
+       zfsvfs_t *zfsvfs;
+
+       if (getzfsvfs(zc->zc_name, &zfsvfs) == 0) {
+               if (!dmu_objset_userused_enabled(zfsvfs->z_os)) {
+                       /*
+                        * If userused is not enabled, it may be because the
+                        * objset needs to be closed & reopened (to grow the
+                        * objset_phys_t).  Suspend/resume the fs will do that.
+                        */
+                       error = zfs_suspend_fs(zfsvfs);
+                       if (error == 0)
+                               error = zfs_resume_fs(zfsvfs, zc->zc_name);
+               }
+               if (error == 0)
+                       error = dmu_objset_userspace_upgrade(zfsvfs->z_os);
+               VFS_RELE(zfsvfs->z_vfs);
+       } else {
+               /* XXX kind of reading contents without owning */
+               error = dmu_objset_hold(zc->zc_name, FTAG, &os);
+               if (error)
+                       return (error);
+
+               error = dmu_objset_userspace_upgrade(os);
+               dmu_objset_rele(os, FTAG);
+       }
+
+       return (error);
 }
 
 /*
@@ -2903,7 +4228,7 @@ zfs_ioc_share(zfs_cmd_t *zc)
                if (error = zsmbexport_fs((void *)
                    (uintptr_t)zc->zc_share.z_exportdata,
                    zc->zc_share.z_sharetype == ZFS_SHARE_SMB ?
-                   B_TRUE : B_FALSE)) {
+                   B_TRUE: B_FALSE)) {
                        return (error);
                }
                break;
@@ -2924,72 +4249,717 @@ zfs_ioc_share(zfs_cmd_t *zc)
 
 }
 
+ace_t full_access[] = {
+       {(uid_t)-1, ACE_ALL_PERMS, ACE_EVERYONE, 0}
+};
+
 /*
- * pool create, destroy, and export don't log the history as part of
- * zfsdev_ioctl, but rather zfs_ioc_pool_create, and zfs_ioc_pool_export
- * do the logging of those commands.
+ * inputs:
+ * zc_name             name of containing filesystem
+ * zc_obj              object # beyond which we want next in-use object #
+ *
+ * outputs:
+ * zc_obj              next in-use object #
+ */
+static int
+zfs_ioc_next_obj(zfs_cmd_t *zc)
+{
+       objset_t *os = NULL;
+       int error;
+
+       error = dmu_objset_hold(zc->zc_name, FTAG, &os);
+       if (error)
+               return (error);
+
+       error = dmu_object_next(os, &zc->zc_obj, B_FALSE,
+           os->os_dsl_dataset->ds_phys->ds_prev_snap_txg);
+
+       dmu_objset_rele(os, FTAG);
+       return (error);
+}
+
+/*
+ * inputs:
+ * zc_name             name of filesystem
+ * zc_value            prefix name for snapshot
+ * zc_cleanup_fd       cleanup-on-exit file descriptor for calling process
+ *
+ * outputs:
+ */
+static int
+zfs_ioc_tmp_snapshot(zfs_cmd_t *zc)
+{
+       char *snap_name;
+       int error;
+
+       snap_name = kmem_asprintf("%s-%016llx", zc->zc_value,
+           (u_longlong_t)ddi_get_lbolt64());
+
+       if (strlen(snap_name) >= MAXNAMELEN) {
+               strfree(snap_name);
+               return (E2BIG);
+       }
+
+       error = dmu_objset_snapshot(zc->zc_name, snap_name, snap_name,
+           NULL, B_FALSE, B_TRUE, zc->zc_cleanup_fd);
+       if (error != 0) {
+               strfree(snap_name);
+               return (error);
+       }
+
+       (void) strcpy(zc->zc_value, snap_name);
+       strfree(snap_name);
+       return (0);
+}
+
+/*
+ * inputs:
+ * zc_name             name of "to" snapshot
+ * zc_value            name of "from" snapshot
+ * zc_cookie           file descriptor to write diff data on
+ *
+ * outputs:
+ * dmu_diff_record_t's to the file descriptor
+ */
+static int
+zfs_ioc_diff(zfs_cmd_t *zc)
+{
+       objset_t *fromsnap;
+       objset_t *tosnap;
+       file_t *fp;
+       offset_t off;
+       int error;
+
+       error = dmu_objset_hold(zc->zc_name, FTAG, &tosnap);
+       if (error)
+               return (error);
+
+       error = dmu_objset_hold(zc->zc_value, FTAG, &fromsnap);
+       if (error) {
+               dmu_objset_rele(tosnap, FTAG);
+               return (error);
+       }
+
+       fp = getf(zc->zc_cookie);
+       if (fp == NULL) {
+               dmu_objset_rele(fromsnap, FTAG);
+               dmu_objset_rele(tosnap, FTAG);
+               return (EBADF);
+       }
+
+       off = fp->f_offset;
+
+       error = dmu_diff(tosnap, fromsnap, fp->f_vnode, &off);
+
+       if (VOP_SEEK(fp->f_vnode, fp->f_offset, &off, NULL) == 0)
+               fp->f_offset = off;
+       releasef(zc->zc_cookie);
+
+       dmu_objset_rele(fromsnap, FTAG);
+       dmu_objset_rele(tosnap, FTAG);
+       return (error);
+}
+
+/*
+ * Remove all ACL files in shares dir
+ */
+static int
+zfs_smb_acl_purge(znode_t *dzp)
+{
+       zap_cursor_t    zc;
+       zap_attribute_t zap;
+       zfsvfs_t *zfsvfs = dzp->z_zfsvfs;
+       int error;
+
+       for (zap_cursor_init(&zc, zfsvfs->z_os, dzp->z_id);
+           (error = zap_cursor_retrieve(&zc, &zap)) == 0;
+           zap_cursor_advance(&zc)) {
+               if ((error = VOP_REMOVE(ZTOV(dzp), zap.za_name, kcred,
+                   NULL, 0)) != 0)
+                       break;
+       }
+       zap_cursor_fini(&zc);
+       return (error);
+}
+
+static int
+zfs_ioc_smb_acl(zfs_cmd_t *zc)
+{
+       vnode_t *vp;
+       znode_t *dzp;
+       vnode_t *resourcevp = NULL;
+       znode_t *sharedir;
+       zfsvfs_t *zfsvfs;
+       nvlist_t *nvlist;
+       char *src, *target;
+       vattr_t vattr;
+       vsecattr_t vsec;
+       int error = 0;
+
+       if ((error = lookupname(zc->zc_value, UIO_SYSSPACE,
+           NO_FOLLOW, NULL, &vp)) != 0)
+               return (error);
+
+       /* Now make sure mntpnt and dataset are ZFS */
+
+       if (vp->v_vfsp->vfs_fstype != zfsfstype ||
+           (strcmp((char *)refstr_value(vp->v_vfsp->vfs_resource),
+           zc->zc_name) != 0)) {
+               VN_RELE(vp);
+               return (EINVAL);
+       }
+
+       dzp = VTOZ(vp);
+       zfsvfs = dzp->z_zfsvfs;
+       ZFS_ENTER(zfsvfs);
+
+       /*
+        * Create share dir if its missing.
+        */
+       mutex_enter(&zfsvfs->z_lock);
+       if (zfsvfs->z_shares_dir == 0) {
+               dmu_tx_t *tx;
+
+               tx = dmu_tx_create(zfsvfs->z_os);
+               dmu_tx_hold_zap(tx, MASTER_NODE_OBJ, TRUE,
+                   ZFS_SHARES_DIR);
+               dmu_tx_hold_zap(tx, DMU_NEW_OBJECT, FALSE, NULL);
+               error = dmu_tx_assign(tx, TXG_WAIT);
+               if (error) {
+                       dmu_tx_abort(tx);
+               } else {
+                       error = zfs_create_share_dir(zfsvfs, tx);
+                       dmu_tx_commit(tx);
+               }
+               if (error) {
+                       mutex_exit(&zfsvfs->z_lock);
+                       VN_RELE(vp);
+                       ZFS_EXIT(zfsvfs);
+                       return (error);
+               }
+       }
+       mutex_exit(&zfsvfs->z_lock);
+
+       ASSERT(zfsvfs->z_shares_dir);
+       if ((error = zfs_zget(zfsvfs, zfsvfs->z_shares_dir, &sharedir)) != 0) {
+               VN_RELE(vp);
+               ZFS_EXIT(zfsvfs);
+               return (error);
+       }
+
+       switch (zc->zc_cookie) {
+       case ZFS_SMB_ACL_ADD:
+               vattr.va_mask = AT_MODE|AT_UID|AT_GID|AT_TYPE;
+               vattr.va_type = VREG;
+               vattr.va_mode = S_IFREG|0777;
+               vattr.va_uid = 0;
+               vattr.va_gid = 0;
+
+               vsec.vsa_mask = VSA_ACE;
+               vsec.vsa_aclentp = &full_access;
+               vsec.vsa_aclentsz = sizeof (full_access);
+               vsec.vsa_aclcnt = 1;
+
+               error = VOP_CREATE(ZTOV(sharedir), zc->zc_string,
+                   &vattr, EXCL, 0, &resourcevp, kcred, 0, NULL, &vsec);
+               if (resourcevp)
+                       VN_RELE(resourcevp);
+               break;
+
+       case ZFS_SMB_ACL_REMOVE:
+               error = VOP_REMOVE(ZTOV(sharedir), zc->zc_string, kcred,
+                   NULL, 0);
+               break;
+
+       case ZFS_SMB_ACL_RENAME:
+               if ((error = get_nvlist(zc->zc_nvlist_src,
+                   zc->zc_nvlist_src_size, zc->zc_iflags, &nvlist)) != 0) {
+                       VN_RELE(vp);
+                       ZFS_EXIT(zfsvfs);
+                       return (error);
+               }
+               if (nvlist_lookup_string(nvlist, ZFS_SMB_ACL_SRC, &src) ||
+                   nvlist_lookup_string(nvlist, ZFS_SMB_ACL_TARGET,
+                   &target)) {
+                       VN_RELE(vp);
+                       VN_RELE(ZTOV(sharedir));
+                       ZFS_EXIT(zfsvfs);
+                       nvlist_free(nvlist);
+                       return (error);
+               }
+               error = VOP_RENAME(ZTOV(sharedir), src, ZTOV(sharedir), target,
+                   kcred, NULL, 0);
+               nvlist_free(nvlist);
+               break;
+
+       case ZFS_SMB_ACL_PURGE:
+               error = zfs_smb_acl_purge(sharedir);
+               break;
+
+       default:
+               error = EINVAL;
+               break;
+       }
+
+       VN_RELE(vp);
+       VN_RELE(ZTOV(sharedir));
+
+       ZFS_EXIT(zfsvfs);
+
+       return (error);
+}
+
+/*
+ * inputs:
+ * zc_name             name of filesystem
+ * zc_value            short name of snap
+ * zc_string           user-supplied tag for this hold
+ * zc_cookie           recursive flag
+ * zc_temphold         set if hold is temporary
+ * zc_cleanup_fd       cleanup-on-exit file descriptor for calling process
+ * zc_sendobj          if non-zero, the objid for zc_name@zc_value
+ * zc_createtxg                if zc_sendobj is non-zero, snap must have zc_createtxg
+ *
+ * outputs:            none
+ */
+static int
+zfs_ioc_hold(zfs_cmd_t *zc)
+{
+       boolean_t recursive = zc->zc_cookie;
+       spa_t *spa;
+       dsl_pool_t *dp;
+       dsl_dataset_t *ds;
+       int error;
+       minor_t minor = 0;
+
+       if (snapshot_namecheck(zc->zc_value, NULL, NULL) != 0)
+               return (EINVAL);
+
+       if (zc->zc_sendobj == 0) {
+               return (dsl_dataset_user_hold(zc->zc_name, zc->zc_value,
+                   zc->zc_string, recursive, zc->zc_temphold,
+                   zc->zc_cleanup_fd));
+       }
+
+       if (recursive)
+               return (EINVAL);
+
+       error = spa_open(zc->zc_name, &spa, FTAG);
+       if (error)
+               return (error);
+
+       dp = spa_get_dsl(spa);
+       rw_enter(&dp->dp_config_rwlock, RW_READER);
+       error = dsl_dataset_hold_obj(dp, zc->zc_sendobj, FTAG, &ds);
+       rw_exit(&dp->dp_config_rwlock);
+       spa_close(spa, FTAG);
+       if (error)
+               return (error);
+
+       /*
+        * Until we have a hold on this snapshot, it's possible that
+        * zc_sendobj could've been destroyed and reused as part
+        * of a later txg.  Make sure we're looking at the right object.
+        */
+       if (zc->zc_createtxg != ds->ds_phys->ds_creation_txg) {
+               dsl_dataset_rele(ds, FTAG);
+               return (ENOENT);
+       }
+
+       if (zc->zc_cleanup_fd != -1 && zc->zc_temphold) {
+               error = zfs_onexit_fd_hold(zc->zc_cleanup_fd, &minor);
+               if (error) {
+                       dsl_dataset_rele(ds, FTAG);
+                       return (error);
+               }
+       }
+
+       error = dsl_dataset_user_hold_for_send(ds, zc->zc_string,
+           zc->zc_temphold);
+       if (minor != 0) {
+               if (error == 0) {
+                       dsl_register_onexit_hold_cleanup(ds, zc->zc_string,
+                           minor);
+               }
+               zfs_onexit_fd_rele(zc->zc_cleanup_fd);
+       }
+       dsl_dataset_rele(ds, FTAG);
+
+       return (error);
+}
+
+/*
+ * inputs:
+ * zc_name     name of dataset from which we're releasing a user hold
+ * zc_value    short name of snap
+ * zc_string   user-supplied tag for this hold
+ * zc_cookie   recursive flag
+ *
+ * outputs:    none
+ */
+static int
+zfs_ioc_release(zfs_cmd_t *zc)
+{
+       boolean_t recursive = zc->zc_cookie;
+
+       if (snapshot_namecheck(zc->zc_value, NULL, NULL) != 0)
+               return (EINVAL);
+
+       return (dsl_dataset_user_release(zc->zc_name, zc->zc_value,
+           zc->zc_string, recursive));
+}
+
+/*
+ * inputs:
+ * zc_name             name of filesystem
+ *
+ * outputs:
+ * zc_nvlist_src{_size}        nvlist of snapshot holds
+ */
+static int
+zfs_ioc_get_holds(zfs_cmd_t *zc)
+{
+       nvlist_t *nvp;
+       int error;
+
+       if ((error = dsl_dataset_get_holds(zc->zc_name, &nvp)) == 0) {
+               error = put_nvlist(zc, nvp);
+               nvlist_free(nvp);
+       }
+
+       return (error);
+}
+
+/*
+ * inputs:
+ * zc_guid             flags (ZEVENT_NONBLOCK)
+ *
+ * outputs:
+ * zc_nvlist_dst       next nvlist event
+ * zc_cookie           dropped events since last get
+ * zc_cleanup_fd       cleanup-on-exit file descriptor
+ */
+static int
+zfs_ioc_events_next(zfs_cmd_t *zc)
+{
+       zfs_zevent_t *ze;
+       nvlist_t *event = NULL;
+       minor_t minor;
+       uint64_t dropped = 0;
+       int error;
+
+       error = zfs_zevent_fd_hold(zc->zc_cleanup_fd, &minor, &ze);
+       if (error != 0)
+               return (error);
+
+       do {
+               error = zfs_zevent_next(ze, &event, &dropped);
+               if (event != NULL) {
+                       zc->zc_cookie = dropped;
+                       error = put_nvlist(zc, event);
+                       nvlist_free(event);
+               }
+
+               if (zc->zc_guid & ZEVENT_NONBLOCK)
+                       break;
+
+               if ((error == 0) || (error != ENOENT))
+                       break;
+
+               error = zfs_zevent_wait(ze);
+               if (error)
+                       break;
+       } while (1);
+
+       zfs_zevent_fd_rele(zc->zc_cleanup_fd);
+
+       return (error);
+}
+
+/*
+ * outputs:
+ * zc_cookie           cleared events count
+ */
+static int
+zfs_ioc_events_clear(zfs_cmd_t *zc)
+{
+       int count;
+
+       zfs_zevent_drain_all(&count);
+       zc->zc_cookie = count;
+
+       return 0;
+}
+
+/*
+ * pool create, destroy, and export don't log the history as part of
+ * zfsdev_ioctl, but rather zfs_ioc_pool_create, and zfs_ioc_pool_export
+ * do the logging of those commands.
  */
 static zfs_ioc_vec_t zfs_ioc_vec[] = {
-       { zfs_ioc_pool_create, zfs_secpolicy_config, POOL_NAME, B_FALSE },
-       { zfs_ioc_pool_destroy, zfs_secpolicy_config, POOL_NAME, B_FALSE },
-       { zfs_ioc_pool_import, zfs_secpolicy_config, POOL_NAME, B_TRUE },
-       { zfs_ioc_pool_export, zfs_secpolicy_config, POOL_NAME, B_FALSE },
-       { zfs_ioc_pool_configs, zfs_secpolicy_none, NO_NAME, B_FALSE },
-       { zfs_ioc_pool_stats, zfs_secpolicy_read, POOL_NAME, B_FALSE },
-       { zfs_ioc_pool_tryimport, zfs_secpolicy_config, NO_NAME, B_FALSE },
-       { zfs_ioc_pool_scrub, zfs_secpolicy_config, POOL_NAME, B_TRUE },
-       { zfs_ioc_pool_freeze, zfs_secpolicy_config, NO_NAME, B_FALSE },
-       { zfs_ioc_pool_upgrade, zfs_secpolicy_config, POOL_NAME, B_TRUE },
-       { zfs_ioc_pool_get_history, zfs_secpolicy_config, POOL_NAME, B_FALSE },
-       { zfs_ioc_vdev_add, zfs_secpolicy_config, POOL_NAME, B_TRUE },
-       { zfs_ioc_vdev_remove, zfs_secpolicy_config, POOL_NAME, B_TRUE },
-       { zfs_ioc_vdev_set_state, zfs_secpolicy_config, POOL_NAME, B_TRUE },
-       { zfs_ioc_vdev_attach, zfs_secpolicy_config, POOL_NAME, B_TRUE },
-       { zfs_ioc_vdev_detach, zfs_secpolicy_config, POOL_NAME, B_TRUE },
-       { zfs_ioc_vdev_setpath, zfs_secpolicy_config, POOL_NAME, B_FALSE },
-       { zfs_ioc_objset_stats, zfs_secpolicy_read, DATASET_NAME, B_FALSE },
-       { zfs_ioc_objset_zplprops, zfs_secpolicy_read, DATASET_NAME, B_FALSE },
-       { zfs_ioc_dataset_list_next, zfs_secpolicy_read,
-           DATASET_NAME, B_FALSE },
-       { zfs_ioc_snapshot_list_next, zfs_secpolicy_read,
-           DATASET_NAME, B_FALSE },
-       { zfs_ioc_set_prop, zfs_secpolicy_none, DATASET_NAME, B_TRUE },
-       { zfs_ioc_create_minor, zfs_secpolicy_minor, DATASET_NAME, B_FALSE },
-       { zfs_ioc_remove_minor, zfs_secpolicy_minor, DATASET_NAME, B_FALSE },
-       { zfs_ioc_create, zfs_secpolicy_create, DATASET_NAME, B_TRUE },
-       { zfs_ioc_destroy, zfs_secpolicy_destroy, DATASET_NAME, B_TRUE },
-       { zfs_ioc_rollback, zfs_secpolicy_rollback, DATASET_NAME, B_TRUE },
-       { zfs_ioc_rename, zfs_secpolicy_rename, DATASET_NAME, B_TRUE },
-       { zfs_ioc_recv, zfs_secpolicy_receive, DATASET_NAME, B_TRUE },
-       { zfs_ioc_send, zfs_secpolicy_send, DATASET_NAME, B_TRUE },
-       { zfs_ioc_inject_fault, zfs_secpolicy_inject, NO_NAME, B_FALSE },
-       { zfs_ioc_clear_fault, zfs_secpolicy_inject, NO_NAME, B_FALSE },
-       { zfs_ioc_inject_list_next, zfs_secpolicy_inject, NO_NAME, B_FALSE },
-       { zfs_ioc_error_log, zfs_secpolicy_inject, POOL_NAME, B_FALSE },
-       { zfs_ioc_clear, zfs_secpolicy_config, POOL_NAME, B_TRUE },
-       { zfs_ioc_promote, zfs_secpolicy_promote, DATASET_NAME, B_TRUE },
-       { zfs_ioc_destroy_snaps, zfs_secpolicy_destroy, DATASET_NAME, B_TRUE },
-       { zfs_ioc_snapshot, zfs_secpolicy_snapshot, DATASET_NAME, B_TRUE },
-       { zfs_ioc_dsobj_to_dsname, zfs_secpolicy_config, POOL_NAME, B_FALSE },
-       { zfs_ioc_obj_to_path, zfs_secpolicy_config, NO_NAME, B_FALSE },
-       { zfs_ioc_pool_set_props, zfs_secpolicy_config, POOL_NAME, B_TRUE },
-       { zfs_ioc_pool_get_props, zfs_secpolicy_read, POOL_NAME, B_FALSE },
-       { zfs_ioc_set_fsacl, zfs_secpolicy_fsacl, DATASET_NAME, B_TRUE },
-       { zfs_ioc_get_fsacl, zfs_secpolicy_read, DATASET_NAME, B_FALSE },
-       { zfs_ioc_iscsi_perm_check, zfs_secpolicy_iscsi,
-           DATASET_NAME, B_FALSE },
-       { zfs_ioc_share, zfs_secpolicy_share, DATASET_NAME, B_FALSE },
-       { zfs_ioc_inherit_prop, zfs_secpolicy_inherit, DATASET_NAME, B_TRUE },
+       { zfs_ioc_pool_create, zfs_secpolicy_config, POOL_NAME, B_FALSE,
+           POOL_CHECK_NONE },
+       { zfs_ioc_pool_destroy, zfs_secpolicy_config, POOL_NAME, B_FALSE,
+           POOL_CHECK_NONE },
+       { zfs_ioc_pool_import, zfs_secpolicy_config, POOL_NAME, B_TRUE,
+           POOL_CHECK_NONE },
+       { zfs_ioc_pool_export, zfs_secpolicy_config, POOL_NAME, B_FALSE,
+           POOL_CHECK_NONE },
+       { zfs_ioc_pool_configs, zfs_secpolicy_none, NO_NAME, B_FALSE,
+           POOL_CHECK_NONE },
+       { zfs_ioc_pool_stats, zfs_secpolicy_read, POOL_NAME, B_FALSE,
+           POOL_CHECK_NONE },
+       { zfs_ioc_pool_tryimport, zfs_secpolicy_config, NO_NAME, B_FALSE,
+           POOL_CHECK_NONE },
+       { zfs_ioc_pool_scan, zfs_secpolicy_config, POOL_NAME, B_TRUE,
+           POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_pool_freeze, zfs_secpolicy_config, NO_NAME, B_FALSE,
+           POOL_CHECK_READONLY },
+       { zfs_ioc_pool_upgrade, zfs_secpolicy_config, POOL_NAME, B_TRUE,
+           POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_pool_get_history, zfs_secpolicy_config, POOL_NAME, B_FALSE,
+           POOL_CHECK_NONE },
+       { zfs_ioc_vdev_add, zfs_secpolicy_config, POOL_NAME, B_TRUE,
+           POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_vdev_remove, zfs_secpolicy_config, POOL_NAME, B_TRUE,
+           POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_vdev_set_state, zfs_secpolicy_config, POOL_NAME, B_TRUE,
+           POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_vdev_attach, zfs_secpolicy_config, POOL_NAME, B_TRUE,
+           POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_vdev_detach, zfs_secpolicy_config, POOL_NAME, B_TRUE,
+           POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_vdev_setpath, zfs_secpolicy_config, POOL_NAME, B_FALSE,
+           POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_vdev_setfru,  zfs_secpolicy_config, POOL_NAME, B_FALSE,
+           POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_objset_stats, zfs_secpolicy_read, DATASET_NAME, B_FALSE,
+           POOL_CHECK_SUSPENDED },
+       { zfs_ioc_objset_zplprops, zfs_secpolicy_read, DATASET_NAME, B_FALSE,
+           POOL_CHECK_NONE },
+       { zfs_ioc_dataset_list_next, zfs_secpolicy_read, DATASET_NAME, B_FALSE,
+           POOL_CHECK_SUSPENDED },
+       { zfs_ioc_snapshot_list_next, zfs_secpolicy_read, DATASET_NAME, B_FALSE,
+           POOL_CHECK_SUSPENDED },
+       { zfs_ioc_set_prop, zfs_secpolicy_none, DATASET_NAME, B_TRUE,
+           POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_create, zfs_secpolicy_create, DATASET_NAME, B_TRUE,
+           POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_destroy, zfs_secpolicy_destroy, DATASET_NAME, B_TRUE,
+           POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_rollback, zfs_secpolicy_rollback, DATASET_NAME, B_TRUE,
+           POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_rename, zfs_secpolicy_rename, DATASET_NAME, B_TRUE,
+           POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_recv, zfs_secpolicy_receive, DATASET_NAME, B_TRUE,
+           POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_send, zfs_secpolicy_send, DATASET_NAME, B_TRUE,
+           POOL_CHECK_NONE },
+       { zfs_ioc_inject_fault, zfs_secpolicy_inject, NO_NAME, B_FALSE,
+           POOL_CHECK_NONE },
+       { zfs_ioc_clear_fault, zfs_secpolicy_inject, NO_NAME, B_FALSE,
+           POOL_CHECK_NONE },
+       { zfs_ioc_inject_list_next, zfs_secpolicy_inject, NO_NAME, B_FALSE,
+           POOL_CHECK_NONE },
+       { zfs_ioc_error_log, zfs_secpolicy_inject, POOL_NAME, B_FALSE,
+           POOL_CHECK_NONE },
+       { zfs_ioc_clear, zfs_secpolicy_config, POOL_NAME, B_TRUE,
+           POOL_CHECK_NONE },
+       { zfs_ioc_promote, zfs_secpolicy_promote, DATASET_NAME, B_TRUE,
+           POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_destroy_snaps, zfs_secpolicy_destroy_snaps, DATASET_NAME,
+           B_TRUE, POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_snapshot, zfs_secpolicy_snapshot, DATASET_NAME, B_TRUE,
+           POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_dsobj_to_dsname, zfs_secpolicy_diff, POOL_NAME, B_FALSE,
+           POOL_CHECK_NONE },
+       { zfs_ioc_obj_to_path, zfs_secpolicy_diff, DATASET_NAME, B_FALSE,
+           POOL_CHECK_SUSPENDED },
+       { zfs_ioc_pool_set_props, zfs_secpolicy_config, POOL_NAME, B_TRUE,
+           POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_pool_get_props, zfs_secpolicy_read, POOL_NAME, B_FALSE,
+           POOL_CHECK_NONE },
+       { zfs_ioc_set_fsacl, zfs_secpolicy_fsacl, DATASET_NAME, B_TRUE,
+           POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_get_fsacl, zfs_secpolicy_read, DATASET_NAME, B_FALSE,
+           POOL_CHECK_NONE },
+       { zfs_ioc_share, zfs_secpolicy_share, DATASET_NAME, B_FALSE,
+           POOL_CHECK_NONE },
+       { zfs_ioc_inherit_prop, zfs_secpolicy_inherit, DATASET_NAME, B_TRUE,
+           POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_smb_acl, zfs_secpolicy_smb_acl, DATASET_NAME, B_FALSE,
+           POOL_CHECK_NONE },
+       { zfs_ioc_userspace_one, zfs_secpolicy_userspace_one, DATASET_NAME,
+           B_FALSE, POOL_CHECK_NONE },
+       { zfs_ioc_userspace_many, zfs_secpolicy_userspace_many, DATASET_NAME,
+           B_FALSE, POOL_CHECK_NONE },
+       { zfs_ioc_userspace_upgrade, zfs_secpolicy_userspace_upgrade,
+           DATASET_NAME, B_FALSE, POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_hold, zfs_secpolicy_hold, DATASET_NAME, B_TRUE,
+           POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_release, zfs_secpolicy_release, DATASET_NAME, B_TRUE,
+           POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_get_holds, zfs_secpolicy_read, DATASET_NAME, B_FALSE,
+           POOL_CHECK_SUSPENDED },
+       { zfs_ioc_objset_recvd_props, zfs_secpolicy_read, DATASET_NAME, B_FALSE,
+           POOL_CHECK_NONE },
+       { zfs_ioc_vdev_split, zfs_secpolicy_config, POOL_NAME, B_TRUE,
+           POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_next_obj, zfs_secpolicy_read, DATASET_NAME, B_FALSE,
+           POOL_CHECK_NONE },
+       { zfs_ioc_diff, zfs_secpolicy_diff, DATASET_NAME, B_FALSE,
+           POOL_CHECK_NONE },
+       { zfs_ioc_tmp_snapshot, zfs_secpolicy_tmp_snapshot, DATASET_NAME,
+           B_FALSE, POOL_CHECK_SUSPENDED | POOL_CHECK_READONLY },
+       { zfs_ioc_obj_to_stats, zfs_secpolicy_diff, DATASET_NAME, B_FALSE,
+           POOL_CHECK_SUSPENDED },
+       { zfs_ioc_events_next, zfs_secpolicy_config, NO_NAME, B_FALSE,
+           POOL_CHECK_NONE },
+       { zfs_ioc_events_clear, zfs_secpolicy_config, NO_NAME, B_FALSE,
+           POOL_CHECK_NONE },
 };
 
+int
+pool_status_check(const char *name, zfs_ioc_namecheck_t type,
+    zfs_ioc_poolcheck_t check)
+{
+       spa_t *spa;
+       int error;
+
+       ASSERT(type == POOL_NAME || type == DATASET_NAME);
+
+       if (check & POOL_CHECK_NONE)
+               return (0);
+
+       error = spa_open(name, &spa, FTAG);
+       if (error == 0) {
+               if ((check & POOL_CHECK_SUSPENDED) && spa_suspended(spa))
+                       error = EAGAIN;
+               else if ((check & POOL_CHECK_READONLY) && !spa_writeable(spa))
+                       error = EROFS;
+               spa_close(spa, FTAG);
+       }
+       return (error);
+}
+
+/*
+ * Find a free minor number.
+ */
+minor_t
+zfsdev_minor_alloc(void)
+{
+       static minor_t last_minor;
+       minor_t m;
+
+       ASSERT(MUTEX_HELD(&zfsdev_state_lock));
+
+       for (m = last_minor + 1; m != last_minor; m++) {
+               if (m > ZFSDEV_MAX_MINOR)
+                       m = 1;
+               if (ddi_get_soft_state(zfsdev_state, m) == NULL) {
+                       last_minor = m;
+                       return (m);
+               }
+       }
+
+       return (0);
+}
+
+static int
+zfs_ctldev_init(dev_t *devp)
+{
+       minor_t minor;
+       zfs_soft_state_t *zs;
+
+       ASSERT(MUTEX_HELD(&zfsdev_state_lock));
+       ASSERT(getminor(*devp) == 0);
+
+       minor = zfsdev_minor_alloc();
+       if (minor == 0)
+               return (ENXIO);
+
+       if (ddi_soft_state_zalloc(zfsdev_state, minor) != DDI_SUCCESS)
+               return (EAGAIN);
+
+       *devp = makedevice(getemajor(*devp), minor);
+
+       zs = ddi_get_soft_state(zfsdev_state, minor);
+       zs->zss_type = ZSST_CTLDEV;
+       zfs_onexit_init((zfs_onexit_t **)&zs->zss_data);
+
+       return (0);
+}
+
+static void
+zfs_ctldev_destroy(zfs_onexit_t *zo, minor_t minor)
+{
+       ASSERT(MUTEX_HELD(&zfsdev_state_lock));
+
+       zfs_onexit_destroy(zo);
+       ddi_soft_state_free(zfsdev_state, minor);
+}
+
+void *
+zfsdev_get_soft_state(minor_t minor, enum zfs_soft_state_type which)
+{
+       zfs_soft_state_t *zp;
+
+       zp = ddi_get_soft_state(zfsdev_state, minor);
+       if (zp == NULL || zp->zss_type != which)
+               return (NULL);
+
+       return (zp->zss_data);
+}
+
+static int
+zfsdev_open(dev_t *devp, int flag, int otyp, cred_t *cr)
+{
+       int error = 0;
+
+       if (getminor(*devp) != 0)
+               return (zvol_open(devp, flag, otyp, cr));
+
+       /* This is the control device. Allocate a new minor if requested. */
+       if (flag & FEXCL) {
+               mutex_enter(&zfsdev_state_lock);
+               error = zfs_ctldev_init(devp);
+               mutex_exit(&zfsdev_state_lock);
+       }
+
+       return (error);
+}
+
+static int
+zfsdev_close(dev_t dev, int flag, int otyp, cred_t *cr)
+{
+       zfs_onexit_t *zo;
+       minor_t minor = getminor(dev);
+
+       if (minor == 0)
+               return (0);
+
+       mutex_enter(&zfsdev_state_lock);
+       zo = zfsdev_get_soft_state(minor, ZSST_CTLDEV);
+       if (zo == NULL) {
+               mutex_exit(&zfsdev_state_lock);
+               return (zvol_close(dev, flag, otyp, cr));
+       }
+       zfs_ctldev_destroy(zo, minor);
+       mutex_exit(&zfsdev_state_lock);
+
+       return (0);
+}
+
 static int
 zfsdev_ioctl(dev_t dev, int cmd, intptr_t arg, int flag, cred_t *cr, int *rvalp)
 {
        zfs_cmd_t *zc;
        uint_t vec;
        int error, rc;
+       minor_t minor = getminor(dev);
 
-       if (getminor(dev) != 0)
+       if (minor != 0 &&
+           zfsdev_get_soft_state(minor, ZSST_CTLDEV) == NULL)
                return (zvol_ioctl(dev, cmd, arg, flag, cr, rvalp));
 
        vec = cmd - ZFS_IOC;
@@ -3000,9 +4970,11 @@ zfsdev_ioctl(dev_t dev, int cmd, intptr_t arg, int flag, cred_t *cr, int *rvalp)
 
        zc = kmem_zalloc(sizeof (zfs_cmd_t), KM_SLEEP);
 
-       error = xcopyin((void *)arg, zc, sizeof (zfs_cmd_t));
+       error = ddi_copyin((void *)arg, zc, sizeof (zfs_cmd_t), flag);
+       if (error != 0)
+               error = EFAULT;
 
-       if (error == 0)
+       if ((error == 0) && !(flag & FKIOCTL))
                error = zfs_ioc_vec[vec].zvec_secpolicy(zc, cr);
 
        /*
@@ -3011,15 +4983,22 @@ zfsdev_ioctl(dev_t dev, int cmd, intptr_t arg, int flag, cred_t *cr, int *rvalp)
         */
        if (error == 0) {
                zc->zc_name[sizeof (zc->zc_name) - 1] = '\0';
+               zc->zc_iflags = flag & FKIOCTL;
                switch (zfs_ioc_vec[vec].zvec_namecheck) {
                case POOL_NAME:
                        if (pool_namecheck(zc->zc_name, NULL, NULL) != 0)
                                error = EINVAL;
+                       error = pool_status_check(zc->zc_name,
+                           zfs_ioc_vec[vec].zvec_namecheck,
+                           zfs_ioc_vec[vec].zvec_pool_check);
                        break;
 
                case DATASET_NAME:
                        if (dataset_namecheck(zc->zc_name, NULL, NULL) != 0)
                                error = EINVAL;
+                       error = pool_status_check(zc->zc_name,
+                           zfs_ioc_vec[vec].zvec_namecheck,
+                           zfs_ioc_vec[vec].zvec_pool_check);
                        break;
 
                case NO_NAME:
@@ -3030,10 +5009,11 @@ zfsdev_ioctl(dev_t dev, int cmd, intptr_t arg, int flag, cred_t *cr, int *rvalp)
        if (error == 0)
                error = zfs_ioc_vec[vec].zvec_func(zc);
 
-       rc = xcopyout(zc, (void *)arg, sizeof (zfs_cmd_t));
+       rc = ddi_copyout(zc, (void *)arg, sizeof (zfs_cmd_t), flag);
        if (error == 0) {
-               error = rc;
-               if (zfs_ioc_vec[vec].zvec_his_log == B_TRUE)
+               if (rc != 0)
+                       error = EFAULT;
+               if (zfs_ioc_vec[vec].zvec_his_log)
                        zfs_log_history(zc);
        }
 
@@ -3102,8 +5082,8 @@ zfs_info(dev_info_t *dip, ddi_info_cmd_t infocmd, void *arg, void **result)
  * so most of the standard driver entry points are in zvol.c.
  */
 static struct cb_ops zfs_cb_ops = {
-       zvol_open,      /* open */
-       zvol_close,     /* close */
+       zfsdev_open,    /* open */
+       zfsdev_close,   /* close */
        zvol_strategy,  /* strategy */
        nodev,          /* print */
        zvol_dump,      /* dump */