X-Git-Url: https://git.camperquake.de/gitweb.cgi?a=blobdiff_plain;f=module%2Fzfs%2Fzpl_file.c;h=0ef2c1558f0b38dc9c010dddf217e75f03aeabc3;hb=b18019d2d810585185493c62e9567fa85e51692c;hp=298c0b62df751dcc7ad13c380ef43b2b28a9d70d;hpb=6a95d0b74c2951f0dc82361ea279f64a7349f060;p=zfs.git diff --git a/module/zfs/zpl_file.c b/module/zfs/zpl_file.c index 298c0b6..0ef2c15 100644 --- a/module/zfs/zpl_file.c +++ b/module/zfs/zpl_file.c @@ -76,37 +76,78 @@ zpl_readdir(struct file *filp, void *dirent, filldir_t filldir) return (error); } +#if defined(HAVE_FSYNC_WITH_DENTRY) /* - * 2.6.35 API change, - * As of 2.6.35 the dentry argument to the .fsync() vfs hook was deemed + * Linux 2.6.x - 2.6.34 API, + * Through 2.6.34 the nfsd kernel server would pass a NULL 'file struct *' + * to the fops->fsync() hook. For this reason, we must be careful not to + * use filp unconditionally. + */ +static int +zpl_fsync(struct file *filp, struct dentry *dentry, int datasync) +{ + cred_t *cr = CRED(); + int error; + + crhold(cr); + error = -zfs_fsync(dentry->d_inode, datasync, cr); + crfree(cr); + ASSERT3S(error, <=, 0); + + return (error); +} + +#elif defined(HAVE_FSYNC_WITHOUT_DENTRY) +/* + * Linux 2.6.35 - 3.0 API, + * As of 2.6.35 the dentry argument to the fops->fsync() hook was deemed * redundant. The dentry is still accessible via filp->f_path.dentry, * and we are guaranteed that filp will never be NULL. - * - * 2.6.34 API change, - * Prior to 2.6.34 the nfsd kernel server would pass a NULL file struct * - * to the .fsync() hook. For this reason, we must be careful not to use - * filp unconditionally in the 3 argument case. */ -#ifdef HAVE_2ARGS_FSYNC static int zpl_fsync(struct file *filp, int datasync) { - struct dentry *dentry = filp->f_path.dentry; -#else + struct inode *inode = filp->f_mapping->host; + cred_t *cr = CRED(); + int error; + + crhold(cr); + error = -zfs_fsync(inode, datasync, cr); + crfree(cr); + ASSERT3S(error, <=, 0); + + return (error); +} + +#elif defined(HAVE_FSYNC_RANGE) +/* + * Linux 3.1 - 3.x API, + * As of 3.1 the responsibility to call filemap_write_and_wait_range() has + * been pushed down in to the .fsync() vfs hook. Additionally, the i_mutex + * lock is no longer held by the caller, for zfs we don't require the lock + * to be held so we don't acquire it. + */ static int -zpl_fsync(struct file *filp, struct dentry *dentry, int datasync) +zpl_fsync(struct file *filp, loff_t start, loff_t end, int datasync) { -#endif /* HAVE_2ARGS_FSYNC */ + struct inode *inode = filp->f_mapping->host; cred_t *cr = CRED(); int error; + error = filemap_write_and_wait_range(inode->i_mapping, start, end); + if (error) + return (error); + crhold(cr); - error = -zfs_fsync(dentry->d_inode, datasync, cr); + error = -zfs_fsync(inode, datasync, cr); crfree(cr); ASSERT3S(error, <=, 0); return (error); } +#else +#error "Unsupported fops->fsync() implementation" +#endif ssize_t zpl_read_common(struct inode *ip, const char *buf, size_t len, loff_t pos,