Return positive error number in zfsctl_shares_lookup.
authorYuxuan Shui <yshuiv7@gmail.com>
Sun, 14 Oct 2012 09:01:26 +0000 (17:01 +0800)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Mon, 15 Oct 2012 16:11:56 +0000 (09:11 -0700)
Otherwise it will cause zpl_shares_lookup() to return a invalid
pointer when an error occurs.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Closes #626 #885 #947 #977

module/zfs/zfs_ctldir.c

index 55d1696..41d3365 100644 (file)
@@ -952,7 +952,7 @@ zfsctl_shares_lookup(struct inode *dip, char *name, struct inode **ipp,
 
        if (zsb->z_shares_dir == 0) {
                ZFS_EXIT(zsb);
-               return (-ENOTSUP);
+               return (ENOTSUP);
        }
 
        error = zfs_zget(zsb, zsb->z_shares_dir, &dzp);