zfs.git
13 years agoAdd linux zpios support
Brian Behlendorf [Thu, 26 Aug 2010 18:58:00 +0000 (11:58 -0700)]
Add linux zpios support

Linux kernel implementation of PIOS test app.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoAdd linux user util support
Brian Behlendorf [Thu, 26 Aug 2010 18:57:29 +0000 (11:57 -0700)]
Add linux user util support

This topic branch contains required changes to the user space
utilities to allow them to integrate cleanly with Linux.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoAdd linux user disk support
Brian Behlendorf [Thu, 26 Aug 2010 18:56:53 +0000 (11:56 -0700)]
Add linux user disk support

This topic branch contains all the changes needed to integrate the user
side zfs tools with Linux style devices.  Primarily this includes fixing
up the Solaris libefi library to be Linux friendly, and integrating with
the libblkid library which is provided by e2fsprogs.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoAdd linux unused code tracking
Brian Behlendorf [Thu, 26 Aug 2010 18:55:32 +0000 (11:55 -0700)]
Add linux unused code tracking

Track various large hunks which have been dropped simply
because they are not relevant to this port.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoAdd linux topology support
Brian Behlendorf [Thu, 26 Aug 2010 18:55:19 +0000 (11:55 -0700)]
Add linux topology support

Solaris recently introduced the idea of drive topology because
where a drive is located does matter.  I have already handled
this with udev/blkid integration under Linux so I'm hopeful
this case can simply be removed but for now I've just stubbed
out what is needed in libspl and commented out the rest here.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoAdd linux compatibility
Brian Behlendorf [Thu, 26 Aug 2010 18:54:51 +0000 (11:54 -0700)]
Add linux compatibility

Resolve minor Linux compatibility issues.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoAdd linux spa thread support
Brian Behlendorf [Thu, 26 Aug 2010 18:52:20 +0000 (11:52 -0700)]
Add linux spa thread support

Disable the spa thread under Linux until it can be implemented.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoAdd linux sha2 support
Brian Behlendorf [Thu, 26 Aug 2010 18:52:05 +0000 (11:52 -0700)]
Add linux sha2 support

The upstream ZFS code has correctly moved to a faster native sha2
implementation.  Unfortunately, under Linux that's going to be a little
problematic so we revert the code to the more portable version contained
in earlier ZFS releases.  Using the native sha2 implementation in Linux
is possible but the API is slightly different in kernel version user
space depending on which libraries are used.  Ideally, we need a fast
implementation of SHA256 which builds as part of ZFS this shouldn't be
that hard to do but it will take some effort.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoAdd linux libspl support
Brian Behlendorf [Thu, 26 Aug 2010 18:50:56 +0000 (11:50 -0700)]
Add linux libspl support

All changes needed for the libspl layer.  This includes modifications
to files directly copied from OpenSolaris and the addition of new
files needed to fill in the gaps.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoAdd linux kernel module support
Brian Behlendorf [Thu, 26 Aug 2010 18:49:16 +0000 (11:49 -0700)]
Add linux kernel module support

Setup linux kernel module support, this includes:
- zfs context for kernel/user
- kernel module build system integration
- kernel module macros
- kernel module symbol export
- kernel module options

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoAdd linux kernel memory support
Brian Behlendorf [Thu, 26 Aug 2010 18:46:09 +0000 (11:46 -0700)]
Add linux kernel memory support

Required kmem/vmem changes

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoAdd linux kernel disk support
Brian Behlendorf [Thu, 26 Aug 2010 18:45:02 +0000 (11:45 -0700)]
Add linux kernel disk support

Native Linux vdev disk interfaces

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoAdd linux kernel device support
Brian Behlendorf [Thu, 26 Aug 2010 18:44:39 +0000 (11:44 -0700)]
Add linux kernel device support

This branch contains the majority of the changes required to cleanly
intergrate with Linux style special devices (/dev/zfs).  Mainly this
means dropping all the Solaris style callbacks and replacing them
with the Linux equivilants.

This patch also adds the onexit infrastructure needed to track
some minimal state between ioctls.  Under Linux it would be easy
to do this simply using the file->private_data.  But under Solaris
they apparent need to pass the file descriptor as part of the ioctl
data and then perform a lookup in the kernel.  Once again to keep
code change to a minimum I've implemented the Solaris solution.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoAdd linux spl debug support
Brian Behlendorf [Thu, 26 Aug 2010 18:44:12 +0000 (11:44 -0700)]
Add linux spl debug support

Use spl debug if HAVE_SPL defined

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoAdd linux mntent support
Brian Behlendorf [Thu, 26 Aug 2010 18:43:58 +0000 (11:43 -0700)]
Add linux mntent support

Use mount entry if HAVE_SETMNTENT defined

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoAdd linux mlslabel support
Brian Behlendorf [Thu, 26 Aug 2010 18:43:42 +0000 (11:43 -0700)]
Add linux mlslabel support

The ZFS update to onnv_141 brought with it support for a
security label attribute called mlslabel.  This feature
depends on zones to work correctly and thus I am disabling
it under Linux.  Equivilant functionality could be added
at some point in the future.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoAdd linux idmap support
Brian Behlendorf [Thu, 26 Aug 2010 18:43:07 +0000 (11:43 -0700)]
Add linux idmap support

Use idmap service if available.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoAdd linux events
Brian Behlendorf [Thu, 26 Aug 2010 18:42:43 +0000 (11:42 -0700)]
Add linux events

This topic branch leverages the Solaris style FMA call points
in ZFS to create a user space visible event notification system
under Linux.  This new system is called zevent and it unifies
all previous Solaris style ereports and sysevent notifications.

Under this Linux specific scheme when a sysevent or ereport event
occurs an nvlist describing the event is created which looks almost
exactly like a Solaris ereport.  These events are queued up in the
kernel when they occur and conditionally logged to the console.
It is then up to a user space application to consume the events
and do whatever it likes with them.

To make this possible the existing /dev/zfs ABI has been extended
with two new ioctls which behave as follows.

* ZFS_IOC_EVENTS_NEXT
Get the next pending event.  The kernel will keep track of the last
event consumed by the file descriptor and provide the next one if
available.  If no new events are available the ioctl() will block
waiting for the next event.  This ioctl may also be called in a
non-blocking mode by setting zc.zc_guid = ZEVENT_NONBLOCK.  In the
non-blocking case if no events are available ENOENT will be returned.
It is possible that ESHUTDOWN will be returned if the ioctl() is
called while module unloading is in progress.  And finally ENOMEM
may occur if the provided nvlist buffer is not large enough to
contain the entire event.

* ZFS_IOC_EVENTS_CLEAR
Clear are events queued by the kernel.  The kernel will keep a fairly
large number of recent events queued, use this ioctl to clear the
in kernel list.  This will effect all user space processes consuming
events.

The zpool command has been extended to use this events ABI with the
'events' subcommand.  You may run 'zpool events -v' to output a
verbose log of all recent events.  This is very similar to the
Solaris 'fmdump -ev' command with the key difference being it also
includes what would be considered sysevents under Solaris.  You
may also run in follow mode with the '-f' option.  To clear the
in kernel event queue use the '-c' option.

$ sudo cmd/zpool/zpool events -fv
TIME                        CLASS
May 13 2010 16:31:15.777711000 ereport.fs.zfs.config.sync
        class = "ereport.fs.zfs.config.sync"
        ena = 0x40982b7897700001
        detector = (embedded nvlist)
                version = 0x0
                scheme = "zfs"
                pool = 0xed976600de75dfa6
        (end detector)

        time = 0x4bec8bc3 0x2e5aed98
        pool = "zpios"
        pool_guid = 0xed976600de75dfa6
        pool_context = 0x0

While the 'zpool events' command is handy for interactive debugging
it is not expected to be the primary consumer of zevents.  This ABI
was primarily added to facilitate the addition of a user space
monitoring daemon.  This daemon would consume all events posted by
the kernel and based on the type of event perform an action.  For
most events simply forwarding them on to syslog is likely enough.
But this interface also cleanly allows for more sophisticated
actions to be taken such as generating an email for a failed drive.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoAdd build system
Brian Behlendorf [Thu, 26 Aug 2010 18:22:58 +0000 (11:22 -0700)]
Add build system

Add autoconf style build infrastructure to the ZFS tree.  This
includes autogen.sh, configure.ac, m4 macros, some scripts/*,
and makefiles for all the core ZFS components.

13 years agoFix stack ztest
Brian Behlendorf [Thu, 26 Aug 2010 18:13:05 +0000 (11:13 -0700)]
Fix stack ztest

While ztest does run in user space we run it with the same stack
restrictions it would have in kernel space.  This ensures that any
stack related issues which would be hit in the kernel can be caught
and debugged in user space instead.

This patch is a first pass to limit the stack usage of every ztest
function to 1024 bytes.  Subsequent updates can further reduce this.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix stack traverse_visitbp()
Brian Behlendorf [Fri, 27 Aug 2010 23:48:18 +0000 (16:48 -0700)]
Fix stack traverse_visitbp()

Due to  limited stack space recursive functions are frowned upon in
the Linux kernel.  However, they often are the most elegant solution
to a problem.  The following code preserves the recursive function
traverse_visitbp() but moves the local variables AND function
arguments to the heap to minimize the stack frame size.  Enough
space is initially allocated on the stack for 20 levels of recursion.
This change does ugly-up-the-code but it reduces the worst case
usage from roughly 4160 bytes to 960 bytes on x86_64 archs.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix stack zio_execute()
Ned Bass [Thu, 26 Aug 2010 18:38:38 +0000 (11:38 -0700)]
Fix stack zio_execute()

Implement zio_execute() as a wrapper around the static function
__zio_execute() so that we can force  __zio_execute() to be inlined.
This reduces stack overhead which is important because __zio_execute()
is called recursively in several zio code paths.  zio_execute() itself
cannot be inlined because it is externally visible.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix stack zio_done()
Brian Behlendorf [Thu, 26 Aug 2010 18:04:17 +0000 (11:04 -0700)]
Fix stack zio_done()

Eliminated local variables pointing to members of the zio struct.
Just refer to the struct members directly.  This saved about 32 bytes per
call, but this function can be called recurisvely up to 19 levels deep,
so we potentially save up to 608 bytes.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix stack vn_open()
Brian Behlendorf [Thu, 26 Aug 2010 18:03:04 +0000 (11:03 -0700)]
Fix stack vn_open()

We should not put a 4k maxpathlen buffer on the stack, instead
locate it to the heap.  Even in user space we run ztest with 8K
stacks to verify correctness

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix stack vdev_cache_read()
Brian Behlendorf [Thu, 26 Aug 2010 18:00:46 +0000 (11:00 -0700)]
Fix stack vdev_cache_read()

Moving the vdev_cache_entry_t struct ve_search from the stack to
the heap saves ~100 bytes.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix stack traverse_impl()
Brian Behlendorf [Thu, 26 Aug 2010 17:58:47 +0000 (10:58 -0700)]
Fix stack traverse_impl()

Stack use reduced from 560 bytes to 128 bytes.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix stack noinline
Brian Behlendorf [Thu, 26 Aug 2010 17:58:36 +0000 (10:58 -0700)]
Fix stack noinline

Certain function must never be automatically inlined by gcc because
they are stack heavy or called recursively.  This patch flags all
such functions I've found as 'noinline' to prevent gcc from making
the optimization.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix stack lzjb
Brian Behlendorf [Thu, 26 Aug 2010 17:58:19 +0000 (10:58 -0700)]
Fix stack lzjb

Reduce kernel stack usage by lzjb_compress() by moving uint16 array
off the stack and on to the heap.  The exact performance implications
of this I have not measured but we absolutely need to keep stack
usage to a minimum.  If/when this becomes and issue we optimize.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix stack inline
Brian Behlendorf [Thu, 26 Aug 2010 17:58:00 +0000 (10:58 -0700)]
Fix stack inline

Decrease stack usage for various call paths by forcing certain
functions to be inlined.  By inlining the functions the overhead
of a new stack frame is removed at the cost of increased code size.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix stack dsl_scan_visitbp()
Brian Behlendorf [Thu, 26 Aug 2010 17:53:43 +0000 (10:53 -0700)]
Fix stack dsl_scan_visitbp()

To reduce stack overhead this topic branch moves the 128 byte
blkptr_t data strucutre in dsl_scan_visitbp() to the heap.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix stack dsl_dir_open_spa()
Brian Behlendorf [Thu, 26 Aug 2010 17:53:31 +0000 (10:53 -0700)]
Fix stack dsl_dir_open_spa()

Reduce stack usage by 256 bytes by moving buf char array from
the stack to the heap.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix stack dsl_deleg_get()
Brian Behlendorf [Thu, 26 Aug 2010 17:53:19 +0000 (10:53 -0700)]
Fix stack dsl_deleg_get()

Reduce stack usage in dsl_deleg_get, gcc flagged it as consuming a
whopping 1040 bytes or potentially 1/4 of a 4K stack.  This patch
moves all the large structures and buffer off the stack and on to
the heap.  This includes 2 zap_cursor_t structs each 52 bytes in
size, 2 zap_attribute_t structs each 280 bytes in size, and 1
256 byte char array.  The total saves on the stack is 880 bytes
after you account for the 5 new pointers added.

Also the source buffer length has been increased from MAXNAMELEN
to MAXNAMELEN+strlen(MOS_DIR_NAME)+1 as described by the comment in
dsl_dir_name().  A buffer overrun may have been possible with the
slightly smaller buffer.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix stack dsl_dataset_destroy()
Brian Behlendorf [Thu, 26 Aug 2010 17:52:40 +0000 (10:52 -0700)]
Fix stack dsl_dataset_destroy()

Move dsl_dataset_t local variable from the stack to the heap.
This reduces the stack usage of this function from 2048 bytes
to 176 bytes for x84_64 arches.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix stack dmu_objset_snapshot()
Brian Behlendorf [Thu, 26 Aug 2010 17:52:23 +0000 (10:52 -0700)]
Fix stack dmu_objset_snapshot()

Reduce stack usage by 276 bytes by moving the snaparg struct from the
stack to the heap.  We have limited stack space we must not waste.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix stack dbuf_hold_impl()
Brian Behlendorf [Thu, 26 Aug 2010 17:52:00 +0000 (10:52 -0700)]
Fix stack dbuf_hold_impl()

This commit preserves the recursive function dbuf_hold_impl() but moves
the local variables and function arguments to the heap to minimize
the stack frame size.  Enough space is initially allocated on the
stack for 20 levels of recursion.  This technique was based on commit
34229a2f2ac07363f64ddd63e014964fff2f0671 which reduced stack usage of
traverse_visitbp().

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix dnode_move() scope
Brian Behlendorf [Fri, 27 Aug 2010 17:55:07 +0000 (10:55 -0700)]
Fix dnode_move() scope

The dnode_move() functionality is only used in the kernel build.
As such we should be careful to wrap all of the related code
with '#ifdef _KERNEL' to avoid gcc warnings about unused code.

13 years agoFix Solaris thread dependency by using pthreads
Brian Behlendorf [Thu, 26 Aug 2010 17:43:27 +0000 (10:43 -0700)]
Fix Solaris thread dependency by using pthreads

This is a portability change which removes the dependence of the Solaris
thread library.  All locations where Solaris thread API was used before
have been replaced with equivilant Solaris kernel style thread calls.
In user space the kernel style threading API is implemented in term of
the portable pthreads library.  This includes all threads, mutexs,
condition variables, reader/writer locks, and taskqs.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix zfs_ioc_objset_stats
Brian Behlendorf [Thu, 26 Aug 2010 17:34:33 +0000 (10:34 -0700)]
Fix zfs_ioc_objset_stats

Interestingly this looks like an upstream bug as well.  If for some
reason we are unable to get a zvols statistics, because perhaps the
zpool is hopelessly corrupt, we would trigger the VERIFY.  This
commit adds the proper error handling just to propagate the error
back to user space.  Now the user space tools still must handle this
properly but in the worst case the tool will crash or perhaps have
some missing output.  That's far far better than crashing the host.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix zio_taskq_dispatch to use TQ_NOSLEEP
Brian Behlendorf [Thu, 26 Aug 2010 17:32:23 +0000 (10:32 -0700)]
Fix zio_taskq_dispatch to use TQ_NOSLEEP

The zio_taskq_dispatch() function may be called at interrupt time
and it is critical that we never sleep.

Additionally, wrap taskq_dispatch() in a while loop because it may
fail.  This is non optimal but is OK for now.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix strncat usage
Brian Behlendorf [Thu, 26 Aug 2010 17:31:53 +0000 (10:31 -0700)]
Fix strncat usage

This look like a typo.  The intention was to use strlcat() however
strncat() was used instead accidentally this may lead to a buffer
overflow.  This was caught by gcc -D_FORTIFY_SOURCE=2.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix rw_init() usage
Brian Behlendorf [Thu, 26 Aug 2010 17:30:13 +0000 (10:30 -0700)]
Fix rw_init() usage

Properly initialize rwlock primitives.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix zmod.h usage in userspace
Brian Behlendorf [Thu, 26 Aug 2010 17:29:11 +0000 (10:29 -0700)]
Fix zmod.h usage in userspace

Do not use zmod.h in userspace.

This has also been filed with the ZFS team. It makes the userspace
libzpool code use the zlib API, instead of the Solaris-only and
non-standard zmod.h.  The zlib API is almost identical and is a de
facto standard, so this is a no-brainer.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix missing newlines
Brian Behlendorf [Thu, 26 Aug 2010 17:28:31 +0000 (10:28 -0700)]
Fix missing newlines

Add missing \n's to dprintf()s

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix metaslab
Brian Behlendorf [Thu, 26 Aug 2010 17:27:53 +0000 (10:27 -0700)]
Fix metaslab

If your only going to allow one allocator to be used and it is defined
at compile time there is no point including the others in the build.
This patch could/should be refined for Linux to make the metaslab
configurable at run time.  That might be a bit tricky however since
you would need to quiese all IO.  Short of that making it configurable
as a module load option would be a reasonable compromise.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix list handling to only use the API
Brian Behlendorf [Thu, 26 Aug 2010 17:26:44 +0000 (10:26 -0700)]
Fix list handling to only use the API

Remove all instances of list handling where the API is not used
and instead list data members are directly accessed.  Doing this
sort of thing is bad for portability.

Additionally, ensure that list_link_init() is called on newly
created list nodes.  This ensures the node is properly initialized
and does not rely on the assumption that zero'ing the list_node_t
via kmem_zalloc() is the same as proper initialization.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix kstat xuio
Brian Behlendorf [Thu, 26 Aug 2010 17:26:05 +0000 (10:26 -0700)]
Fix kstat xuio

Move xiou stat structures from a header to the dmu.c source as is
done with all the other kstat interfaces.  This information is local
to dmu.c registered the xuio kstat and should stay that way.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix dbuf eviction assertion
Brian Behlendorf [Thu, 26 Aug 2010 17:24:44 +0000 (10:24 -0700)]
Fix dbuf eviction assertion

Replace non-fatal assertion with warning.  This was being observed
during testing and it should not be fatal.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix vn_open/vn_rdwr error handling
Ricardo M. Correia [Thu, 26 Aug 2010 17:21:44 +0000 (10:21 -0700)]
Fix vn_open/vn_rdwr error handling

1) In vn_open(), if fstat64() returned an error, the real errno
was being obscured by calling close().

2) Add error handling for both pwrite64() calls in vn_rdwr().

Signed-off-by: Ricardo M. Correia <Ricardo.M.Correia@Sun.COM>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix deadcode
Brian Behlendorf [Thu, 26 Aug 2010 17:19:48 +0000 (10:19 -0700)]
Fix deadcode

Remove deadcode.  It's possible the code should be in use
somewhere, but as the source code is laid out it currently
is not.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix dbuf_dirty_record_t leaks
Brian Behlendorf [Thu, 26 Aug 2010 17:19:04 +0000 (10:19 -0700)]
Fix dbuf_dirty_record_t leaks

Fix two leaks with dbuf_dirty_record_t

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix variables named current
Brian Behlendorf [Thu, 26 Aug 2010 17:18:06 +0000 (10:18 -0700)]
Fix variables named current

In the linux kernel 'current' is defined to mean the current process
and can never be used as a local variable in a function.  Simply
replace all usage of 'current' with 'curr' in this function.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix commit callbacks
Ricardo M. Correia [Thu, 26 Aug 2010 17:17:18 +0000 (10:17 -0700)]
Fix commit callbacks

The upstream commit cb code had a few bugs:

1) The arguments of the list_move_tail() call in txg_dispatch_callbacks()
were reversed by mistake. This caused the commit callbacks to not be
called at all.

2) ztest had a bug in ztest_dmu_commit_callbacks() where "error" was not
initialized correctly. This seems to have caused the test to always take
the simulated error code path, which made ztest unable to detect whether
commit cbs were being called for transactions that successfuly complete.

3) ztest had another bug in ztest_dmu_commit_callbacks() where the commit
cb threshold was not being compared correctly.

4) The commit cb taskq was using 'max_ncpus * 2' as the maxalloc argument
of taskq_create(), which could have caused unnecessary delays in the txg
sync thread.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix minor acl issue
Brian Behlendorf [Thu, 26 Aug 2010 17:10:35 +0000 (10:10 -0700)]
Fix minor acl issue

Minor fixes for newly introduced acl support.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix gcc uninitialized variable warnings
Brian Behlendorf [Thu, 26 Aug 2010 16:58:04 +0000 (09:58 -0700)]
Fix gcc uninitialized variable warnings

Gcc -Wall warn: 'uninitialized variable'

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix gcc unused variable warnings
Brian Behlendorf [Thu, 26 Aug 2010 16:53:00 +0000 (09:53 -0700)]
Fix gcc unused variable warnings

Gcc -Wall warn: 'unused variable'

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix gcc missing parenthesis warnings
Brian Behlendorf [Thu, 26 Aug 2010 16:52:42 +0000 (09:52 -0700)]
Fix gcc missing parenthesis warnings

Gcc -Wall warn: 'missing parenthesis'

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix gcc missing case warnings
Brian Behlendorf [Thu, 26 Aug 2010 16:52:41 +0000 (09:52 -0700)]
Fix gcc missing case warnings

Gcc ASSERT() missing cases are impossible

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix gcc missing braces warnings
Brian Behlendorf [Thu, 26 Aug 2010 16:52:41 +0000 (09:52 -0700)]
Fix gcc missing braces warnings

Resolve compiler warnings concerning missing braces.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix gcc invalid prototype warnings
Brian Behlendorf [Thu, 26 Aug 2010 16:52:41 +0000 (09:52 -0700)]
Fix gcc invalid prototype warnings

Gcc -Wall warn: 'invalid prototype'

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix gcc init pragma warnings
Brian Behlendorf [Thu, 26 Aug 2010 16:52:40 +0000 (09:52 -0700)]
Fix gcc init pragma warnings

Use constructor attribute on non-Solaris platforms.

The #pragma init/fini ->__attribute__((constructor/destructor))
conversions, these should go upstream.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix gcc ident pragma warnings
Ricardo M. Correia [Thu, 26 Aug 2010 16:52:40 +0000 (09:52 -0700)]
Fix gcc ident pragma warnings

Remove all ident pragmas which are unknown to gcc.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix gcc fortify source warnings
Brian Behlendorf [Thu, 26 Aug 2010 16:52:40 +0000 (09:52 -0700)]
Fix gcc fortify source warnings

Resolve issues uncovered by -D_FORTIFY_SOURCE=2, the default redhat
macro's file adds this option to the cflags.  This causes warnings
of the following type designed to keep the developer honest:

        warning: ignoring return value of 'foo', declared
                 with attribute warn_unused_result

The short term fix is to wrap these calls in VERIFY() to check the
return code.  The code was already assusing these would never fail.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix gcc useless debug warnings
Brian Behlendorf [Thu, 26 Aug 2010 16:52:40 +0000 (09:52 -0700)]
Fix gcc useless debug warnings

Gcc useless debugging.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix gcc cast warnings
Brian Behlendorf [Thu, 26 Aug 2010 16:52:39 +0000 (09:52 -0700)]
Fix gcc cast warnings

Gcc -Wall warn: 'lacks a cast'
Gcc -Wall warn: 'comparison between pointer and integer'

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix gcc c90 compliance warnings
Brian Behlendorf [Thu, 26 Aug 2010 16:52:39 +0000 (09:52 -0700)]
Fix gcc c90 compliance warnings

Fix non-c90 compliant code, for the most part these changes
simply deal with where a particular variable is declared.
Under c90 it must alway be done at the very start of a block.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoFix gcc 64-bit constant warnings
Ricardo M. Correia [Thu, 26 Aug 2010 16:52:39 +0000 (09:52 -0700)]
Fix gcc 64-bit constant warnings

Add 'ull' suffix to 64-bit constants.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoUpdate to onnv_147
Brian Behlendorf [Thu, 26 Aug 2010 21:24:34 +0000 (14:24 -0700)]
Update to onnv_147

This is the last official OpenSolaris tag before the public
development tree was closed.

13 years agoRemove GIT notes
Brian Behlendorf [Thu, 26 Aug 2010 20:45:31 +0000 (13:45 -0700)]
Remove GIT notes

These notes describe how to use TopGit with this repo.  As of
this point TopGit is no longer used so the notes have been removed.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 years agoAdd basic README
Brian Behlendorf [Tue, 29 Jun 2010 21:35:21 +0000 (14:35 -0700)]
Add basic README

A simple README with a short summary of the project and a link
directing people to the online documentation.

14 years agoUpdate core ZFS code from build 121 to build 141.
Brian Behlendorf [Fri, 28 May 2010 20:45:14 +0000 (13:45 -0700)]
Update core ZFS code from build 121 to build 141.

14 years agoAdd AUTHORS to master branch
Brian Behlendorf [Tue, 18 May 2010 21:55:01 +0000 (14:55 -0700)]
Add AUTHORS to master branch

14 years agoUpdate COPYRIGHT to reference zpios CDDL exceptions.
Brian Behlendorf [Tue, 18 May 2010 21:25:28 +0000 (14:25 -0700)]
Update COPYRIGHT to reference zpios CDDL exceptions.

14 years agoUpdate COPYRIGHT to include release id LLNL-CODE-403049.
Brian Behlendorf [Tue, 18 May 2010 18:06:56 +0000 (11:06 -0700)]
Update COPYRIGHT to include release id LLNL-CODE-403049.

14 years agoUpdate COPYRIGHT and DISCLAIMER.
Brian Behlendorf [Tue, 18 May 2010 17:32:23 +0000 (10:32 -0700)]
Update COPYRIGHT and DISCLAIMER.

Update the COPYRIGHT and DISCLAIMER in an attempt to be clear about
the copyright and licensing issues.

14 years agoUpdate nvpair's to include nv_alloc_fixed support
Brian Behlendorf [Thu, 29 Apr 2010 18:59:41 +0000 (11:59 -0700)]
Update nvpair's to include nv_alloc_fixed support

14 years agoAdd Solaris FMA style support
Brian Behlendorf [Thu, 29 Apr 2010 17:37:15 +0000 (10:37 -0700)]
Add Solaris FMA style support

14 years agoRename update-zfs.sh -> zfs-update.sh for consistency
Brian Behlendorf [Thu, 11 Mar 2010 17:53:59 +0000 (09:53 -0800)]
Rename update-zfs.sh -> zfs-update.sh for consistency

14 years agoIgnore unsigned module build products
Brian Behlendorf [Tue, 9 Mar 2010 22:14:09 +0000 (14:14 -0800)]
Ignore unsigned module build products

Along with the addition of signed kernel modules in newer kernel
we have a few new build products we need to ignore.   LKLM has the
whole thread for those interested: http://lkml.org/lkml/2007/2/14/164

14 years agoAdd .gitignore files to exclude build products
Brian Behlendorf [Fri, 8 Jan 2010 19:35:17 +0000 (11:35 -0800)]
Add .gitignore files to exclude build products

14 years agoPull in latest man pages as part of update-zfs.sh
Brian Behlendorf [Sat, 12 Dec 2009 00:15:33 +0000 (16:15 -0800)]
Pull in latest man pages as part of update-zfs.sh

The script has been updated to download the latest documentations
packages for Solaris and extract the needed ZFS man pages.  These
will still need a little markup to handle changes between the
Solaris and Linux versions of ZFS.  Howver, they should be pretty
minor I've tried hard to keep the interface the same.

In additional to the script update the zdb, zfs, and zpool man
pages have been added to the repo.

14 years agoRemove zvol.c when updating in update-zfs.sh Linux version available.
Brian Behlendorf [Mon, 16 Nov 2009 00:20:01 +0000 (16:20 -0800)]
Remove zvol.c when updating in update-zfs.sh Linux version available.

14 years agoScript update-zfs.sh updated to include libefi library
Brian Behlendorf [Fri, 9 Oct 2009 22:37:29 +0000 (15:37 -0700)]
Script update-zfs.sh updated to include libefi library

14 years agoRebase master to b121
Brian Behlendorf [Tue, 18 Aug 2009 18:43:27 +0000 (11:43 -0700)]
Rebase master to b121

14 years agoRebase master to b117
Brian Behlendorf [Thu, 2 Jul 2009 22:44:48 +0000 (15:44 -0700)]
Rebase master to b117

15 years agoRebase master to b108
Brian Behlendorf [Wed, 18 Feb 2009 20:51:31 +0000 (12:51 -0800)]
Rebase master to b108

15 years agoRefresh type in topgit git://* reference
Brian Behlendorf [Tue, 27 Jan 2009 05:58:32 +0000 (21:58 -0800)]
Refresh type in topgit git://* reference

15 years agoAdd GIT to master
Brian Behlendorf [Tue, 20 Jan 2009 23:43:44 +0000 (15:43 -0800)]
Add GIT to master

15 years agoRebase master to b105
Brian Behlendorf [Thu, 15 Jan 2009 21:59:39 +0000 (13:59 -0800)]
Rebase master to b105

15 years agoAdd unicode library
Brian Behlendorf [Mon, 5 Jan 2009 20:03:23 +0000 (12:03 -0800)]
Add unicode library

15 years agoRemove zdump, it's an unrelateds command which I added simply due to the z* command...
Brian Behlendorf [Mon, 5 Jan 2009 19:10:13 +0000 (11:10 -0800)]
Remove zdump, it's an unrelateds command which I added simply due to the z* command convention

15 years agoRemove zcommon reference merged in to zpool
Brian Behlendorf [Fri, 12 Dec 2008 21:41:20 +0000 (13:41 -0800)]
Remove zcommon reference merged in to zpool

15 years agoMoving lib/libspl to linux-libspl branch
Brian Behlendorf [Thu, 11 Dec 2008 23:38:59 +0000 (15:38 -0800)]
Moving lib/libspl to linux-libspl branch

15 years agoScript updates
Brian Behlendorf [Thu, 11 Dec 2008 22:21:14 +0000 (14:21 -0800)]
Script updates

15 years agoMove library files to lib
Brian Behlendorf [Thu, 11 Dec 2008 22:16:55 +0000 (14:16 -0800)]
Move library files to lib

15 years agoFix libspl move to the wrong place
Brian Behlendorf [Thu, 11 Dec 2008 19:22:02 +0000 (11:22 -0800)]
Fix libspl move to the wrong place

15 years agoFix typo
Brian Behlendorf [Thu, 11 Dec 2008 19:16:38 +0000 (11:16 -0800)]
Fix typo

15 years agoAdd a few missing files
Brian Behlendorf [Thu, 11 Dec 2008 19:14:49 +0000 (11:14 -0800)]
Add a few missing files

15 years agoMove the world out of /zfs/ and seperate out module build tree
Brian Behlendorf [Thu, 11 Dec 2008 19:08:09 +0000 (11:08 -0800)]
Move the world out of /zfs/ and seperate out module build tree

15 years agoRemove libumem, we will try and remove this dependency entirely. If we can't then...
Brian Behlendorf [Wed, 10 Dec 2008 20:43:20 +0000 (12:43 -0800)]
Remove libumem, we will try and remove this dependency entirely.  If we can't then the best move will simply be to use the official library, or build it as a convenience library

15 years agoMove vmem* to libumem
Brian Behlendorf [Tue, 9 Dec 2008 22:14:00 +0000 (14:14 -0800)]
Move vmem* to libumem