From be8bc8c0d3ff16888f046e8523051b514ad285e0 Mon Sep 17 00:00:00 2001 From: Turbo Fredriksson Date: Tue, 2 Apr 2013 09:27:52 -0700 Subject: [PATCH] Add smb_available() sanity checks Do basic sanity checks in smb_available() to verify that the 'net' command and the usershare directory exists. Signed-off-by: Brian Behlendorf Closes #1124 --- lib/libshare/smb.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/libshare/smb.c b/lib/libshare/smb.c index e34d142..a545bfb 100644 --- a/lib/libshare/smb.c +++ b/lib/libshare/smb.c @@ -423,7 +423,15 @@ static const sa_share_ops_t smb_shareops = { static boolean_t smb_available(void) { - /* TODO: Sanity check NET_CMD_PATH and SHARE_DIR */ + struct stat statbuf; + + if (lstat(SHARE_DIR, &statbuf) != 0 || + !S_ISDIR(statbuf.st_mode)) + return B_FALSE; + + if (access(NET_CMD_PATH, F_OK) != 0) + return B_FALSE; + return B_TRUE; } -- 1.8.3.1