Constify structures containing function pointers
authorRichard Yao <ryao@cs.stonybrook.edu>
Fri, 15 Feb 2013 04:37:43 +0000 (23:37 -0500)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Mon, 4 Mar 2013 16:49:32 +0000 (08:49 -0800)
commitb01615d5ac86913da1e092d0378bfb8f0e72af30
tree905cd8431cce678140c8e3d1bbf35800cffe4e66
parentc38367c73f592ca9729ba0d5e70b5e3bc67e0745
Constify structures containing function pointers

The PaX team modified the kernel's modpost to report writeable function
pointers as section mismatches because they are potential exploit
targets. We could ignore the warnings, but their presence can obscure
actual issues. Proper const correctness can also catch programming
mistakes.

Building the kernel modules against a PaX/GrSecurity patched Linux 3.4.2
kernel reports 133 section mismatches prior to this patch. This patch
eliminates 130 of them. The quantity of writeable function pointers
eliminated by constifying each structure is as follows:

vdev_opts_t             52
zil_replay_func_t       24
zio_compress_info_t     24
zio_checksum_info_t     9
space_map_ops_t         7
arc_byteswap_func_t     5

The remaining 3 writeable function pointers cannot be addressed by this
patch. 2 of them are in zpl_fs_type. The kernel's sget function requires
that this be non-const. The final writeable function pointer is created
by SPL_SHRINKER_DECLARE. The kernel's set_shrinker() and
remove_shrinker() functions also require that this be non-const.

Signed-off-by: Richard Yao <ryao@cs.stonybrook.edu>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #1300
13 files changed:
cmd/ztest/ztest.c
include/sys/dmu.h
include/sys/space_map.h
include/sys/vdev_impl.h
include/sys/zfs_znode.h
include/sys/zil.h
include/sys/zio_checksum.h
include/sys/zio_compress.h
module/zfs/arc.c
module/zfs/sa.c
module/zfs/zfs_replay.c
module/zfs/zil.c
module/zfs/zvol.c