git://git.camperquake.de
/
xmlrtorrent.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (from parent 1:
feda283
)
fix parameter usage
author
Christian Garbs
<mitch@cgarbs.de>
Sun, 28 Dec 2008 00:46:09 +0000
(
01:46
+0100)
committer
Ralf Ertzinger
<sun@lain.camperquake.de>
Sun, 28 Dec 2008 21:16:02 +0000
(22:16 +0100)
xmlrtorrent/HTTPTalker.pm
patch
|
blob
|
history
diff --git
a/xmlrtorrent/HTTPTalker.pm
b/xmlrtorrent/HTTPTalker.pm
index
9160f8f
..
d8b9340
100644
(file)
--- a/
xmlrtorrent/HTTPTalker.pm
+++ b/
xmlrtorrent/HTTPTalker.pm
@@
-35,19
+35,23
@@
sub send_request {
my $self = shift;
my @params = @_;
my $self = shift;
my @params = @_;
- unless (exists($self->{'_PARAMS'}->{'XMLURL'}) and defined($self->{'_PARAMS'}->{'XMLURL'})) {
+ my $xmlurl = $self->_getval('XMLURL');
+
+ unless (defined($xmlurl) and $xmlurl ne '') {
return 'http talker: XMLURL not set';
}
return 'http talker: XMLURL not set';
}
- if ($
self->{'_PARAMS'}->{'XMLURL'}
ne $self->{'_LASTXMLURL'}) {
- $self->{'_LASTXMLURL'} = $
self->{'_PARAMS'}->{'XMLURL'}
;
- $self->{'__RPCClient'} = RPC::XML::Client->new($
self->{'_PARAMS'}->{'XMLURL'}
);
+ if ($
xmlurl
ne $self->{'_LASTXMLURL'}) {
+ $self->{'_LASTXMLURL'} = $
xmlurl
;
+ $self->{'__RPCClient'} = RPC::XML::Client->new($
xmlurl
);
}
}
- if ((exists($self->{'_PARAMS'}->{'USERNAME'}) and exists($self->{'_PARAMS'}->{'PASSWORD'})) and
- ($self->{'_PARAMS'}->{'USERNAME'} ne '')) {
+ my $username = $self->_getval('USERNAME');
+ my $password = $self->_getval('PASSWORD');
+
+ if (defined $username and defined $password and $username ne '') {
# mitch: let me guess, the realm must be configurable, too!
# mitch: let me guess, the realm must be configurable, too!
- $self->{'__RPCClient'}->credentials('', $
self->{'_PARAMS'}->{'USERNAME'}, $self->{'_PARAMS'}->{'PASSWORD'}
);
+ $self->{'__RPCClient'}->credentials('', $
username, $password
);
}
return $self->{'__RPCClient'}->send_request(@params);
}
return $self->{'__RPCClient'}->send_request(@params);