kmem_zalloc(..., KM_SLEEP) will never fail
authorshenyan1 <shenyanxxxy@qq.com>
Sat, 29 Jun 2013 11:07:45 +0000 (19:07 +0800)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Mon, 1 Jul 2013 21:51:48 +0000 (14:51 -0700)
By definitition these allocations will never fail.  For
consistency with the rest of the code remove this dead error
handling code.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #1558

module/zfs/zfs_ioctl.c
module/zfs/zvol.c

index e1b8543..1226b2c 100644 (file)
@@ -5136,8 +5136,6 @@ zfsdev_state_init(struct file *filp)
                 return (ENXIO);
 
        zs = kmem_zalloc( sizeof(zfsdev_state_t), KM_SLEEP);
-       if (zs == NULL)
-               return (ENOMEM);
 
        zs->zs_file = filp;
        zs->zs_minor = minor;
index b41eeb2..43a7bb6 100644 (file)
@@ -1214,8 +1214,6 @@ zvol_alloc(dev_t dev, const char *name)
        int error = 0;
 
        zv = kmem_zalloc(sizeof (zvol_state_t), KM_SLEEP);
-       if (zv == NULL)
-               goto out;
 
        zv->zv_queue = blk_init_queue(zvol_request, &zv->zv_lock);
        if (zv->zv_queue == NULL)
@@ -1267,7 +1265,7 @@ out_queue:
        blk_cleanup_queue(zv->zv_queue);
 out_kmem:
        kmem_free(zv, sizeof (zvol_state_t));
-out:
+
        return NULL;
 }